| Message ID | 20190916204158.6889-24-efremov@linux.com (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | [RESEND,v3,01/26] PCI: Add define for the number of standard PCI BARs | expand |
On Mon, 16 Sep 2019 at 22:47, Denis Efremov <efremov@linux.com> wrote: > > Use define PCI_STD_NUM_BARS instead of PCI_ROM_RESOURCE for the number of > PCI BARs. > > Cc: Maxim Levitsky <maximlevitsky@gmail.com> > Cc: Alex Dubov <oakad@yahoo.com> > Cc: Ulf Hansson <ulf.hansson@linaro.org> > Signed-off-by: Denis Efremov <efremov@linux.com> Assuming this depends on other changes in the series? Thus this is probably for PCI maintainers to pick up? Acked-by: Ulf Hansson <ulf.hansson@linaro.org> Kind regards Uffe > --- > drivers/memstick/host/jmb38x_ms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c > index 32747425297d..fd281c1d39b1 100644 > --- a/drivers/memstick/host/jmb38x_ms.c > +++ b/drivers/memstick/host/jmb38x_ms.c > @@ -848,7 +848,7 @@ static int jmb38x_ms_count_slots(struct pci_dev *pdev) > { > int cnt, rc = 0; > > - for (cnt = 0; cnt < PCI_ROM_RESOURCE; ++cnt) { > + for (cnt = 0; cnt < PCI_STD_NUM_BARS; ++cnt) { > if (!(IORESOURCE_MEM & pci_resource_flags(pdev, cnt))) > break; > > -- > 2.21.0 >
On 20.09.2019 10:42, Ulf Hansson wrote: > On Mon, 16 Sep 2019 at 22:47, Denis Efremov <efremov@linux.com> wrote: >> >> Use define PCI_STD_NUM_BARS instead of PCI_ROM_RESOURCE for the number of >> PCI BARs. >> >> Cc: Maxim Levitsky <maximlevitsky@gmail.com> >> Cc: Alex Dubov <oakad@yahoo.com> >> Cc: Ulf Hansson <ulf.hansson@linaro.org> >> Signed-off-by: Denis Efremov <efremov@linux.com> > > Assuming this depends on other changes in the series? Yes, the first patch introduce define PCI_STD_NUM_BARS. > Thus this is > probably for PCI maintainers to pick up? Yes, this is for Bjorn's tree. > > Acked-by: Ulf Hansson <ulf.hansson@linaro.org> > > Kind regards > Uffe > >> --- >> drivers/memstick/host/jmb38x_ms.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c >> index 32747425297d..fd281c1d39b1 100644 >> --- a/drivers/memstick/host/jmb38x_ms.c >> +++ b/drivers/memstick/host/jmb38x_ms.c >> @@ -848,7 +848,7 @@ static int jmb38x_ms_count_slots(struct pci_dev *pdev) >> { >> int cnt, rc = 0; >> >> - for (cnt = 0; cnt < PCI_ROM_RESOURCE; ++cnt) { >> + for (cnt = 0; cnt < PCI_STD_NUM_BARS; ++cnt) { >> if (!(IORESOURCE_MEM & pci_resource_flags(pdev, cnt))) >> break; >> >> -- >> 2.21.0 >>
diff --git a/drivers/memstick/host/jmb38x_ms.c b/drivers/memstick/host/jmb38x_ms.c index 32747425297d..fd281c1d39b1 100644 --- a/drivers/memstick/host/jmb38x_ms.c +++ b/drivers/memstick/host/jmb38x_ms.c @@ -848,7 +848,7 @@ static int jmb38x_ms_count_slots(struct pci_dev *pdev) { int cnt, rc = 0; - for (cnt = 0; cnt < PCI_ROM_RESOURCE; ++cnt) { + for (cnt = 0; cnt < PCI_STD_NUM_BARS; ++cnt) { if (!(IORESOURCE_MEM & pci_resource_flags(pdev, cnt))) break;
Use define PCI_STD_NUM_BARS instead of PCI_ROM_RESOURCE for the number of PCI BARs. Cc: Maxim Levitsky <maximlevitsky@gmail.com> Cc: Alex Dubov <oakad@yahoo.com> Cc: Ulf Hansson <ulf.hansson@linaro.org> Signed-off-by: Denis Efremov <efremov@linux.com> --- drivers/memstick/host/jmb38x_ms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)