| Message ID | 20190920145518.1721180-1-arnd@arndb.de (mailing list archive) |
|---|---|
| State | New, archived |
| Delegated to: | Bjorn Helgaas |
| Headers | show |
| Series | PCI: tegra: include linux/pinctrl/consumer.h | expand |
On Fri, Sep 20, 2019 at 04:55:05PM +0200, Arnd Bergmann wrote: > Without this, we can run into a build failure: > > drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration] > > Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Thanks for this. Another fix for this came in earlier today: https://patchwork.ozlabs.org/patch/1165139/ Reviewed-by: Andrew Murray <andrew.murray@arm.com> Thanks, Andrew Murray > --- > drivers/pci/controller/dwc/pcie-tegra194.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > index 09ed8e473cff..f89f5acee72d 100644 > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > @@ -22,6 +22,7 @@ > #include <linux/of_pci.h> > #include <linux/pci.h> > #include <linux/phy/phy.h> > +#include <linux/pinctrl/consumer.h> > #include <linux/platform_device.h> > #include <linux/pm_runtime.h> > #include <linux/random.h> > -- > 2.20.0 >
On Fri, Sep 20, 2019 at 04:07:14PM +0100, Andrew Murray wrote: > On Fri, Sep 20, 2019 at 04:55:05PM +0200, Arnd Bergmann wrote: > > Without this, we can run into a build failure: > > > > drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration] > > > > Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Thanks for this. Another fix for this came in earlier today: > > https://patchwork.ozlabs.org/patch/1165139/ I have applied it since it came in earlier. Thanks, Lorenzo > Reviewed-by: Andrew Murray <andrew.murray@arm.com> > > Thanks, > > Andrew Murray > > > --- > > drivers/pci/controller/dwc/pcie-tegra194.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c > > index 09ed8e473cff..f89f5acee72d 100644 > > --- a/drivers/pci/controller/dwc/pcie-tegra194.c > > +++ b/drivers/pci/controller/dwc/pcie-tegra194.c > > @@ -22,6 +22,7 @@ > > #include <linux/of_pci.h> > > #include <linux/pci.h> > > #include <linux/phy/phy.h> > > +#include <linux/pinctrl/consumer.h> > > #include <linux/platform_device.h> > > #include <linux/pm_runtime.h> > > #include <linux/random.h> > > -- > > 2.20.0 > >
diff --git a/drivers/pci/controller/dwc/pcie-tegra194.c b/drivers/pci/controller/dwc/pcie-tegra194.c index 09ed8e473cff..f89f5acee72d 100644 --- a/drivers/pci/controller/dwc/pcie-tegra194.c +++ b/drivers/pci/controller/dwc/pcie-tegra194.c @@ -22,6 +22,7 @@ #include <linux/of_pci.h> #include <linux/pci.h> #include <linux/phy/phy.h> +#include <linux/pinctrl/consumer.h> #include <linux/platform_device.h> #include <linux/pm_runtime.h> #include <linux/random.h>
Without this, we can run into a build failure: drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function 'pinctrl_pm_select_default_state' [-Werror,-Wimplicit-function-declaration] Fixes: ab2a50e7602b ("PCI: tegra: Add support to configure sideband pins") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/pci/controller/dwc/pcie-tegra194.c | 1 + 1 file changed, 1 insertion(+)