| Message ID | 20190926074637.77721-1-dwagner@suse.de (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | scsi: qla2xxx: Remove WARN_ON_ONCE in qla2x00_status_cont_entry() | expand |
On 9/26/19 9:46 AM, Daniel Wagner wrote: > Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not > called from the completion path") introduced the WARN_ON_ONCE in > qla2x00_status_cont_entry(). The assumption was that there is only one > status continuations element. According to the firmware documentation > it is possible that multiple status continuations are emitted by the > firmware. > > Cc: Bart Van Assche <bvanassche@acm.org> > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > drivers/scsi/qla2xxx/qla_isr.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > index 4c26630c1c3e..009fd5a33fcd 100644 > --- a/drivers/scsi/qla2xxx/qla_isr.c > +++ b/drivers/scsi/qla2xxx/qla_isr.c > @@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt) > if (sense_len == 0) { > rsp->status_srb = NULL; > sp->done(sp, cp->result); > - } else { > - WARN_ON_ONCE(true); > } > } > > Not that I can speak for firmware documentation, but: Reviewed-by: Hannes Reinecke <hare@suse.com> Cheers, Hannes
On 2019-09-26 00:46, Daniel Wagner wrote: > Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not > called from the completion path") introduced the WARN_ON_ONCE in > qla2x00_status_cont_entry(). The assumption was that there is only one > status continuations element. According to the firmware documentation > it is possible that multiple status continuations are emitted by the > firmware. > > Cc: Bart Van Assche <bvanassche@acm.org> > Signed-off-by: Daniel Wagner <dwagner@suse.de> > --- > drivers/scsi/qla2xxx/qla_isr.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > index 4c26630c1c3e..009fd5a33fcd 100644 > --- a/drivers/scsi/qla2xxx/qla_isr.c > +++ b/drivers/scsi/qla2xxx/qla_isr.c > @@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt) > if (sense_len == 0) { > rsp->status_srb = NULL; > sp->done(sp, cp->result); > - } else { > - WARN_ON_ONCE(true); > } > } Should the following be added? Fixes: 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") Anyway: Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Hi, > Should the following be added? > > Fixes: 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not > called from the completion path") Good point. Just send out and updated version > Anyway: > > Reviewed-by: Bart Van Assche <bvanassche@acm.org> Thanks! Daniel
diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c index 4c26630c1c3e..009fd5a33fcd 100644 --- a/drivers/scsi/qla2xxx/qla_isr.c +++ b/drivers/scsi/qla2xxx/qla_isr.c @@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt) if (sense_len == 0) { rsp->status_srb = NULL; sp->done(sp, cp->result); - } else { - WARN_ON_ONCE(true); } }
Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not called from the completion path") introduced the WARN_ON_ONCE in qla2x00_status_cont_entry(). The assumption was that there is only one status continuations element. According to the firmware documentation it is possible that multiple status continuations are emitted by the firmware. Cc: Bart Van Assche <bvanassche@acm.org> Signed-off-by: Daniel Wagner <dwagner@suse.de> --- drivers/scsi/qla2xxx/qla_isr.c | 2 -- 1 file changed, 2 deletions(-)