| Message ID | 20191001074628.8122-1-linus.walleij@linaro.org (mailing list archive) |
|---|---|
| State | Queued |
| Commit | cdee3b60af594403bd389e6e8239bcd0b4a159fc |
| Headers | show |
| Series | ARM: dts: ux500: Fix up the CPU thermal zone | expand |
On 01/10/2019 09:46, Linus Walleij wrote: > This fixes up the default ux500 CPU thermal zone: > > - Set polling delay to 0 and explain why > - Set passive polling delay to 250 > - Remove restrictions from the CPU cooling device, > we should use all cpufreq steps to cool down if > needed. > > Fixes: b786a05f6ce4 ("ARM: dts: ux500: Update thermal zone") > Suggested-by: Daniel Lezcano <daniel.lezcano@linaro.org> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org> > --- > ARM SoC folks: please apply this directly for fixes. > It addresses some review comments I missed in the patches > that went in to the merge window. > --- > arch/arm/boot/dts/ste-dbx5x0.dtsi | 11 ++++++++--- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/ste-dbx5x0.dtsi b/arch/arm/boot/dts/ste-dbx5x0.dtsi > index a53657b83288..bda454d12150 100644 > --- a/arch/arm/boot/dts/ste-dbx5x0.dtsi > +++ b/arch/arm/boot/dts/ste-dbx5x0.dtsi > @@ -8,6 +8,7 @@ > #include <dt-bindings/mfd/dbx500-prcmu.h> > #include <dt-bindings/arm/ux500_pm_domains.h> > #include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/thermal/thermal.h> > > / { > #address-cells = <1>; > @@ -59,8 +60,12 @@ > * cooling. > */ > cpu_thermal: cpu-thermal { > - polling-delay-passive = <0>; > - polling-delay = <1000>; > + polling-delay-passive = <250>; > + /* > + * This sensor fires interrupts to update the thermal > + * zone, so no polling is needed. > + */ > + polling-delay = <0>; > > thermal-sensors = <&thermal>; > > @@ -79,7 +84,7 @@ > > cooling-maps { > trip = <&cpu_alert>; > - cooling-device = <&CPU0 0 2>; > + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > contribution = <100>; > }; > }; >
diff --git a/arch/arm/boot/dts/ste-dbx5x0.dtsi b/arch/arm/boot/dts/ste-dbx5x0.dtsi index a53657b83288..bda454d12150 100644 --- a/arch/arm/boot/dts/ste-dbx5x0.dtsi +++ b/arch/arm/boot/dts/ste-dbx5x0.dtsi @@ -8,6 +8,7 @@ #include <dt-bindings/mfd/dbx500-prcmu.h> #include <dt-bindings/arm/ux500_pm_domains.h> #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/thermal/thermal.h> / { #address-cells = <1>; @@ -59,8 +60,12 @@ * cooling. */ cpu_thermal: cpu-thermal { - polling-delay-passive = <0>; - polling-delay = <1000>; + polling-delay-passive = <250>; + /* + * This sensor fires interrupts to update the thermal + * zone, so no polling is needed. + */ + polling-delay = <0>; thermal-sensors = <&thermal>; @@ -79,7 +84,7 @@ cooling-maps { trip = <&cpu_alert>; - cooling-device = <&CPU0 0 2>; + cooling-device = <&CPU0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; contribution = <100>; }; };
This fixes up the default ux500 CPU thermal zone: - Set polling delay to 0 and explain why - Set passive polling delay to 250 - Remove restrictions from the CPU cooling device, we should use all cpufreq steps to cool down if needed. Fixes: b786a05f6ce4 ("ARM: dts: ux500: Update thermal zone") Suggested-by: Daniel Lezcano <daniel.lezcano@linaro.org> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- ARM SoC folks: please apply this directly for fixes. It addresses some review comments I missed in the patches that went in to the merge window. --- arch/arm/boot/dts/ste-dbx5x0.dtsi | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-)