| Message ID | 20190920151247.25128-1-mihail.atanassov@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm/komeda: Use IRQ_RETVAL shorthand in d71_irq_handler | expand |
On Fri, Sep 20, 2019 at 03:13:08PM +0000, Mihail Atanassov wrote: > No change in behaviour; IRQ_RETVAL is about twice as popular as > manually writing out the ternary. > > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> > --- > drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > index d567ab7ed314..1b42095969e7 100644 > --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > @@ -195,7 +195,7 @@ d71_irq_handler(struct komeda_dev *mdev, struct komeda_events *evts) > if (gcu_status & GLB_IRQ_STATUS_PIPE1) > evts->pipes[1] |= get_pipeline_event(d71->pipes[1], gcu_status); > > - return gcu_status ? IRQ_HANDLED : IRQ_NONE; > + return IRQ_RETVAL(gcu_status); Hi Mihail: Thank you for the patch. Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com> > } > > #define ENABLED_GCU_IRQS (GCU_IRQ_CVAL0 | GCU_IRQ_CVAL1 | \ > -- > 2.23.0
On Mon, Sep 23, 2019 at 02:41:44AM +0000, james qian wang (Arm Technology China) wrote: > On Fri, Sep 20, 2019 at 03:13:08PM +0000, Mihail Atanassov wrote: > > No change in behaviour; IRQ_RETVAL is about twice as popular as > > manually writing out the ternary. > > > > Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> > > --- > > drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > > index d567ab7ed314..1b42095969e7 100644 > > --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > > +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c > > @@ -195,7 +195,7 @@ d71_irq_handler(struct komeda_dev *mdev, struct komeda_events *evts) > > if (gcu_status & GLB_IRQ_STATUS_PIPE1) > > evts->pipes[1] |= get_pipeline_event(d71->pipes[1], gcu_status); > > > > - return gcu_status ? IRQ_HANDLED : IRQ_NONE; > > + return IRQ_RETVAL(gcu_status); > > Hi Mihail: > > Thank you for the patch. > > Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.com> Pushed to drm-misc-next - 4b39582a8fb3c749f0fa96ec920d138f61bf00d6 > > > } > > > > #define ENABLED_GCU_IRQS (GCU_IRQ_CVAL0 | GCU_IRQ_CVAL1 | \ > > -- > > 2.23.0 > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c index d567ab7ed314..1b42095969e7 100644 --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c @@ -195,7 +195,7 @@ d71_irq_handler(struct komeda_dev *mdev, struct komeda_events *evts) if (gcu_status & GLB_IRQ_STATUS_PIPE1) evts->pipes[1] |= get_pipeline_event(d71->pipes[1], gcu_status); - return gcu_status ? IRQ_HANDLED : IRQ_NONE; + return IRQ_RETVAL(gcu_status); } #define ENABLED_GCU_IRQS (GCU_IRQ_CVAL0 | GCU_IRQ_CVAL1 | \
No change in behaviour; IRQ_RETVAL is about twice as popular as manually writing out the ternary. Signed-off-by: Mihail Atanassov <mihail.atanassov@arm.com> --- drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)