| Message ID | 20191001090152.1770-2-david@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | dde3285ffa1a75dbd67c6a61e5f3eba2267c6593 |
| Headers | show |
| Series | xen/balloon: PG_offline cleanups | expand |
On 10/1/19 5:01 AM, David Hildenbrand wrote: > Let's simply use balloon_append() directly. > > Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: Stefano Stabellini <sstabellini@kernel.org> > Signed-off-by: David Hildenbrand <david@redhat.com> For the series (and your earlier patch) Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
On 01.10.19 19:45, Boris Ostrovsky wrote: > On 10/1/19 5:01 AM, David Hildenbrand wrote: >> Let's simply use balloon_append() directly. >> >> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> >> Cc: Juergen Gross <jgross@suse.com> >> Cc: Stefano Stabellini <sstabellini@kernel.org> >> Signed-off-by: David Hildenbrand <david@redhat.com> > > For the series (and your earlier patch) > > Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> Thanks! Who's the lucky winner to eventually pick the four patches up? :)
On 02.10.19 09:47, David Hildenbrand wrote: > On 01.10.19 19:45, Boris Ostrovsky wrote: >> On 10/1/19 5:01 AM, David Hildenbrand wrote: >>> Let's simply use balloon_append() directly. >>> >>> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> >>> Cc: Juergen Gross <jgross@suse.com> >>> Cc: Stefano Stabellini <sstabellini@kernel.org> >>> Signed-off-by: David Hildenbrand <david@redhat.com> >> >> For the series (and your earlier patch) >> >> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> > > Thanks! Who's the lucky winner to eventually pick the four patches up? :) They will be taken through the Xen tree. Juergen
diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c index 91cba70b69df..37443c5fda99 100644 --- a/drivers/xen/balloon.c +++ b/drivers/xen/balloon.c @@ -156,7 +156,7 @@ static DECLARE_DELAYED_WORK(balloon_worker, balloon_process); (GFP_HIGHUSER | __GFP_NOWARN | __GFP_NORETRY | __GFP_NOMEMALLOC) /* balloon_append: add the given page to the balloon. */ -static void __balloon_append(struct page *page) +static void balloon_append(struct page *page) { /* Lowmem is re-populated first, so highmem pages go at list tail. */ if (PageHighMem(page)) { @@ -169,11 +169,6 @@ static void __balloon_append(struct page *page) wake_up(&balloon_wq); } -static void balloon_append(struct page *page) -{ - __balloon_append(page); -} - /* balloon_retrieve: rescue a page from the balloon, if it is not empty. */ static struct page *balloon_retrieve(bool require_lowmem) { @@ -378,7 +373,7 @@ static void xen_online_page(struct page *page, unsigned int order) p = pfn_to_page(start_pfn + i); __online_page_set_limits(p); __SetPageOffline(p); - __balloon_append(p); + balloon_append(p); } mutex_unlock(&balloon_mutex); } @@ -689,7 +684,7 @@ static void __init balloon_add_region(unsigned long start_pfn, include the boot-time balloon extension, so don't subtract from it. */ __SetPageOffline(page); - __balloon_append(page); + balloon_append(page); } balloon_stats.total_pages += extra_pfn_end - start_pfn;
Let's simply use balloon_append() directly. Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Juergen Gross <jgross@suse.com> Cc: Stefano Stabellini <sstabellini@kernel.org> Signed-off-by: David Hildenbrand <david@redhat.com> --- drivers/xen/balloon.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)