| Message ID | 1570163038-32067-1-git-send-email-anshuman.khandual@arm.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 6ec939f8b809cb06ba7802e17ef7024d1bc0ee84 |
| Headers | show |
| Series | arm64/mm: Poison initmem while freeing with free_reserved_area() | expand |
On 04/10/2019 05:23, Anshuman Khandual wrote: > Platform implementation for free_initmem() should poison the memory while > freeing it up. Hence pass across POISON_FREE_INITMEM while calling into > free_reserved_area(). The same is being followed in the generic fallback > for free_initmem() and some other platforms overriding it. > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> Is there a good reason you haven't made a similar change to free_initrd_mem() - the same logic seems to apply. However this change looks fine to me. Reviewed-by: Steven Price <steven.price@arm.com> > --- > arch/arm64/mm/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > index 45c00a54909c..ea7d38011e83 100644 > --- a/arch/arm64/mm/init.c > +++ b/arch/arm64/mm/init.c > @@ -571,7 +571,7 @@ void free_initmem(void) > { > free_reserved_area(lm_alias(__init_begin), > lm_alias(__init_end), > - 0, "unused kernel"); > + POISON_FREE_INITMEM, "unused kernel"); > /* > * Unmap the __init region but leave the VM area in place. This > * prevents the region from being reused for kernel modules, which >
On 10/04/2019 03:49 PM, Steven Price wrote: > On 04/10/2019 05:23, Anshuman Khandual wrote: >> Platform implementation for free_initmem() should poison the memory while >> freeing it up. Hence pass across POISON_FREE_INITMEM while calling into >> free_reserved_area(). The same is being followed in the generic fallback >> for free_initmem() and some other platforms overriding it. >> >> Cc: Catalin Marinas <catalin.marinas@arm.com> >> Cc: Will Deacon <will@kernel.org> >> Cc: Mark Rutland <mark.rutland@arm.com> >> Cc: linux-kernel@vger.kernel.org >> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> > > Is there a good reason you haven't made a similar change to > free_initrd_mem() - the same logic seems to apply. However this change > looks fine to me. We will use generic free_initrd_mem() going forward as proposed in a recent patch which does call free_reserved_area() with POISON_FREE_INITMEM. https://patchwork.kernel.org/patch/11165379/ > > Reviewed-by: Steven Price <steven.price@arm.com> > >> --- >> arch/arm64/mm/init.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c >> index 45c00a54909c..ea7d38011e83 100644 >> --- a/arch/arm64/mm/init.c >> +++ b/arch/arm64/mm/init.c >> @@ -571,7 +571,7 @@ void free_initmem(void) >> { >> free_reserved_area(lm_alias(__init_begin), >> lm_alias(__init_end), >> - 0, "unused kernel"); >> + POISON_FREE_INITMEM, "unused kernel"); >> /* >> * Unmap the __init region but leave the VM area in place. This >> * prevents the region from being reused for kernel modules, which >> > >
On 04/10/2019 11:48, Anshuman Khandual wrote: > > > On 10/04/2019 03:49 PM, Steven Price wrote: >> On 04/10/2019 05:23, Anshuman Khandual wrote: >>> Platform implementation for free_initmem() should poison the memory while >>> freeing it up. Hence pass across POISON_FREE_INITMEM while calling into >>> free_reserved_area(). The same is being followed in the generic fallback >>> for free_initmem() and some other platforms overriding it. >>> >>> Cc: Catalin Marinas <catalin.marinas@arm.com> >>> Cc: Will Deacon <will@kernel.org> >>> Cc: Mark Rutland <mark.rutland@arm.com> >>> Cc: linux-kernel@vger.kernel.org >>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> >> >> Is there a good reason you haven't made a similar change to >> free_initrd_mem() - the same logic seems to apply. However this change >> looks fine to me. > > We will use generic free_initrd_mem() going forward as proposed in a recent > patch which does call free_reserved_area() with POISON_FREE_INITMEM. > > https://patchwork.kernel.org/patch/11165379/ Great - that sounds like a very good reason! Thanks, Steve >> >> Reviewed-by: Steven Price <steven.price@arm.com> >> >>> --- >>> arch/arm64/mm/init.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c >>> index 45c00a54909c..ea7d38011e83 100644 >>> --- a/arch/arm64/mm/init.c >>> +++ b/arch/arm64/mm/init.c >>> @@ -571,7 +571,7 @@ void free_initmem(void) >>> { >>> free_reserved_area(lm_alias(__init_begin), >>> lm_alias(__init_end), >>> - 0, "unused kernel"); >>> + POISON_FREE_INITMEM, "unused kernel"); >>> /* >>> * Unmap the __init region but leave the VM area in place. This >>> * prevents the region from being reused for kernel modules, which >>> >> >> > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >
On Fri, Oct 04, 2019 at 09:53:58AM +0530, Anshuman Khandual wrote: > Platform implementation for free_initmem() should poison the memory while > freeing it up. Hence pass across POISON_FREE_INITMEM while calling into > free_reserved_area(). The same is being followed in the generic fallback > for free_initmem() and some other platforms overriding it. > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> > --- > arch/arm64/mm/init.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c > index 45c00a54909c..ea7d38011e83 100644 > --- a/arch/arm64/mm/init.c > +++ b/arch/arm64/mm/init.c > @@ -571,7 +571,7 @@ void free_initmem(void) > { > free_reserved_area(lm_alias(__init_begin), > lm_alias(__init_end), > - 0, "unused kernel"); > + POISON_FREE_INITMEM, "unused kernel"); Acked-by: Will Deacon <will@kernel.org> Will
On Fri, Oct 04, 2019 at 09:53:58AM +0530, Anshuman Khandual wrote: > Platform implementation for free_initmem() should poison the memory while > freeing it up. Hence pass across POISON_FREE_INITMEM while calling into > free_reserved_area(). The same is being followed in the generic fallback > for free_initmem() and some other platforms overriding it. > > Cc: Catalin Marinas <catalin.marinas@arm.com> > Cc: Will Deacon <will@kernel.org> > Cc: Mark Rutland <mark.rutland@arm.com> > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> Queued for 5.5. Thanks.
diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c index 45c00a54909c..ea7d38011e83 100644 --- a/arch/arm64/mm/init.c +++ b/arch/arm64/mm/init.c @@ -571,7 +571,7 @@ void free_initmem(void) { free_reserved_area(lm_alias(__init_begin), lm_alias(__init_end), - 0, "unused kernel"); + POISON_FREE_INITMEM, "unused kernel"); /* * Unmap the __init region but leave the VM area in place. This * prevents the region from being reused for kernel modules, which
Platform implementation for free_initmem() should poison the memory while freeing it up. Hence pass across POISON_FREE_INITMEM while calling into free_reserved_area(). The same is being followed in the generic fallback for free_initmem() and some other platforms overriding it. Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Will Deacon <will@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: linux-kernel@vger.kernel.org Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com> --- arch/arm64/mm/init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)