mbox series

[v4,0/2] mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS issue

Message ID 1565112345-28754-1-git-send-email-jane.chu@oracle.com (mailing list archive)
Headers show
Series mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS issue | expand

Message

Jane Chu Aug. 6, 2019, 5:25 p.m. UTC
Change in v4:
 - remove trailing white space

Changes in v3:
 - move **tk cleanup to its own patch

Changes in v2:
 - move 'tk' allocations internal to add_to_kill(), suggested by Dan;
 - ran checkpatch.pl check, pointed out by Matthew;
 - Noaya pointed out that v1 would have missed the SIGKILL
   if "tk->addr == -EFAULT", since the code returns early.
   Incorporated Noaya's suggestion, also, skip VMAs where
   "tk->size_shift == 0" for zone device page, and deliver SIGBUS
   when "tk->size_shift != 0" so the payload is helpful;
 - added Suggested-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>

Jane Chu (2):
  mm/memory-failure.c clean up around tk pre-allocation
  mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS if
    mmaped more than once

 mm/memory-failure.c | 62 ++++++++++++++++++++++-------------------------------
 1 file changed, 26 insertions(+), 36 deletions(-)

Comments

Jane Chu Oct. 8, 2019, 6:13 p.m. UTC | #1
Hi, Naoya,

What is the status of the patches?
Is there anything I need to do from my end ?

Regards,
-jane

On 8/6/2019 10:25 AM, Jane Chu wrote:
> Change in v4:
>   - remove trailing white space
> 
> Changes in v3:
>   - move **tk cleanup to its own patch
> 
> Changes in v2:
>   - move 'tk' allocations internal to add_to_kill(), suggested by Dan;
>   - ran checkpatch.pl check, pointed out by Matthew;
>   - Noaya pointed out that v1 would have missed the SIGKILL
>     if "tk->addr == -EFAULT", since the code returns early.
>     Incorporated Noaya's suggestion, also, skip VMAs where
>     "tk->size_shift == 0" for zone device page, and deliver SIGBUS
>     when "tk->size_shift != 0" so the payload is helpful;
>   - added Suggested-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> 
> Jane Chu (2):
>    mm/memory-failure.c clean up around tk pre-allocation
>    mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS if
>      mmaped more than once
> 
>   mm/memory-failure.c | 62 ++++++++++++++++++++++-------------------------------
>   1 file changed, 26 insertions(+), 36 deletions(-)
>
Naoya Horiguchi Oct. 8, 2019, 11:18 p.m. UTC | #2
Hi Jane,

I think that this patchset is good enough and ready to be merged.
Andrew, could you consider queuing this series into your tree?

Thanks,
Naoya Horiguchi

On Tue, Oct 08, 2019 at 11:13:23AM -0700, Jane Chu wrote:
> Hi, Naoya,
> 
> What is the status of the patches?
> Is there anything I need to do from my end ?
> 
> Regards,
> -jane
> 
> On 8/6/2019 10:25 AM, Jane Chu wrote:
> > Change in v4:
> >   - remove trailing white space
> > 
> > Changes in v3:
> >   - move **tk cleanup to its own patch
> > 
> > Changes in v2:
> >   - move 'tk' allocations internal to add_to_kill(), suggested by Dan;
> >   - ran checkpatch.pl check, pointed out by Matthew;
> >   - Noaya pointed out that v1 would have missed the SIGKILL
> >     if "tk->addr == -EFAULT", since the code returns early.
> >     Incorporated Noaya's suggestion, also, skip VMAs where
> >     "tk->size_shift == 0" for zone device page, and deliver SIGBUS
> >     when "tk->size_shift != 0" so the payload is helpful;
> >   - added Suggested-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> > 
> > Jane Chu (2):
> >    mm/memory-failure.c clean up around tk pre-allocation
> >    mm/memory-failure: Poison read receives SIGKILL instead of SIGBUS if
> >      mmaped more than once
> > 
> >   mm/memory-failure.c | 62 ++++++++++++++++++++++-------------------------------
> >   1 file changed, 26 insertions(+), 36 deletions(-)
> > 
>
Andrew Morton Oct. 9, 2019, 11:55 p.m. UTC | #3
On Tue, 8 Oct 2019 23:18:31 +0000 Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:

> I think that this patchset is good enough and ready to be merged.
> Andrew, could you consider queuing this series into your tree?

I'll treat that as an acked-by:.

Do you think 2/2 should be backported into -stable trees?
Naoya Horiguchi Oct. 10, 2019, 1:22 a.m. UTC | #4
On Wed, Oct 09, 2019 at 04:55:10PM -0700, Andrew Morton wrote:
> On Tue, 8 Oct 2019 23:18:31 +0000 Naoya Horiguchi <n-horiguchi@ah.jp.nec.com> wrote:
> 
> > I think that this patchset is good enough and ready to be merged.
> > Andrew, could you consider queuing this series into your tree?
> 
> I'll treat that as an acked-by:.

thanks.

> 
> Do you think 2/2 should be backported into -stable trees?

Yes, I think so. Please add Cc: stable.

Thanks,
Naoya Horiguchi