| Message ID | 20191010043809.27594-1-yzhai003@ucr.edu (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: sm750fb: Potential uninitialized field in "pll" | expand |
On Wed, Oct 09, 2019 at 09:38:08PM -0700, Yizhuo wrote: > Inside function set_chip_clock(), struct pll is supposed to be > initialized in sm750_calc_pll_value(), if condition > "diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled, > then some field of pll will not be initialized but used in > function sm750_format_pll_reg(), which is potentially unsafe. > > Signed-off-by: Yizhuo <yzhai003@ucr.edu> > --- > drivers/staging/sm750fb/ddk750_chip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c > index 5a317cc98a4b..31b3cf9c2d8b 100644 > --- a/drivers/staging/sm750fb/ddk750_chip.c > +++ b/drivers/staging/sm750fb/ddk750_chip.c > @@ -55,7 +55,7 @@ static unsigned int get_mxclk_freq(void) > */ > static void set_chip_clock(unsigned int frequency) > { > - struct pll_value pll; > + struct pll_value pll = {}; > unsigned int actual_mx_clk; > > /* Cheok_0509: For SM750LE, the chip clock is fixed. Nothing to set. */ This doesn't apply to my tree at all. Please rebase it against the staging-next branch of staging.git and resend. thanks, greg k-h
On Wed, Oct 09, 2019 at 09:38:08PM -0700, Yizhuo wrote: > Inside function set_chip_clock(), struct pll is supposed to be > initialized in sm750_calc_pll_value(), if condition > "diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled, > then some field of pll will not be initialized but used in > function sm750_format_pll_reg(), which is potentially unsafe. > > Signed-off-by: Yizhuo <yzhai003@ucr.edu> The patch is correct, but it doesn't apply to linux-next any more. Can you re-write it on top of the most recent staging-next and resend? regards, dan carpenter
Sorry about that, let me resend it . On Thu, Oct 10, 2019 at 2:53 AM Dan Carpenter <dan.carpenter@oracle.com> wrote: > > On Wed, Oct 09, 2019 at 09:38:08PM -0700, Yizhuo wrote: > > Inside function set_chip_clock(), struct pll is supposed to be > > initialized in sm750_calc_pll_value(), if condition > > "diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled, > > then some field of pll will not be initialized but used in > > function sm750_format_pll_reg(), which is potentially unsafe. > > > > Signed-off-by: Yizhuo <yzhai003@ucr.edu> > > The patch is correct, but it doesn't apply to linux-next any more. Can > you re-write it on top of the most recent staging-next and resend? > > regards, > dan carpenter >
diff --git a/drivers/staging/sm750fb/ddk750_chip.c b/drivers/staging/sm750fb/ddk750_chip.c index 5a317cc98a4b..31b3cf9c2d8b 100644 --- a/drivers/staging/sm750fb/ddk750_chip.c +++ b/drivers/staging/sm750fb/ddk750_chip.c @@ -55,7 +55,7 @@ static unsigned int get_mxclk_freq(void) */ static void set_chip_clock(unsigned int frequency) { - struct pll_value pll; + struct pll_value pll = {}; unsigned int actual_mx_clk; /* Cheok_0509: For SM750LE, the chip clock is fixed. Nothing to set. */
Inside function set_chip_clock(), struct pll is supposed to be initialized in sm750_calc_pll_value(), if condition "diff < mini_diff" in sm750_calc_pll_value() cannot be fulfilled, then some field of pll will not be initialized but used in function sm750_format_pll_reg(), which is potentially unsafe. Signed-off-by: Yizhuo <yzhai003@ucr.edu> --- drivers/staging/sm750fb/ddk750_chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)