diff mbox series

[bringup] ath11k: fix tkip mic error reporting to cfg80211

Message ID 1570777352-25385-1-git-send-email-murugana@codeaurora.org (mailing list archive)
State Accepted
Commit e44597a02dad14573f7c80ed833a6c2327b166e7
Delegated to: Kalle Valo
Headers show
Series [bringup] ath11k: fix tkip mic error reporting to cfg80211 | expand

Commit Message

Sathishkumar Muruganandam Oct. 11, 2019, 7:02 a.m. UTC
ieee80211_rx_status flag was not updated with MMIC_STRIPPED and DECRYPTED
bits during TKIP MIC error detection from RxDMA and hence this is not
getting reported to cfg80211_michael_mic_failure() for WPA countermeasures.

Signed-off-by: Sathishkumar Muruganandam <murugana@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/dp_rx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Kalle Valo Oct. 15, 2019, 12:49 p.m. UTC | #1
Sathishkumar Muruganandam <murugana@codeaurora.org> wrote:

> ieee80211_rx_status flag was not updated with MMIC_STRIPPED and DECRYPTED
> bits during TKIP MIC error detection from RxDMA and hence this is not
> getting reported to cfg80211_michael_mic_failure() for WPA countermeasures.
> 
> Signed-off-by: Sathishkumar Muruganandam <murugana@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath11k-bringup branch of ath.git, thanks.

e44597a02dad ath11k: fix tkip mic error reporting to cfg80211
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c
index faea5b12a2d6..9491a479fab5 100644
--- a/drivers/net/wireless/ath/ath11k/dp_rx.c
+++ b/drivers/net/wireless/ath/ath11k/dp_rx.c
@@ -3021,7 +3021,8 @@  static void ath11k_dp_rx_h_tkip_mic_err(struct ath11k *ar, struct sk_buff *msdu,
 
 	ath11k_dp_rx_h_ppdu(ar, desc, status);
 
-	status->flag |= RX_FLAG_MMIC_ERROR;
+	status->flag |= (RX_FLAG_MMIC_STRIPPED | RX_FLAG_MMIC_ERROR |
+			 RX_FLAG_DECRYPTED);
 
 	ath11k_dp_rx_h_undecap(ar, msdu, desc,
 			       HAL_ENCRYPT_TYPE_TKIP_MIC, status, false);