diff mbox series

[01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops

Message ID 20191008123453.1651-1-ben.dooks@codethink.co.uk (mailing list archive)
State New, archived
Headers show
Series [01/11] ARM: bcm2836: include local platsmp.h for bcm2836_smp_ops | expand

Commit Message

Ben Dooks Oct. 8, 2019, 12:34 p.m. UTC
Include platsmp.h for the definition of bcm2836_smp_ops to fix
the following warning:

arch/arm/mach-bcm/platsmp.c:334:29: warning: symbol 'bcm2836_smp_ops' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: bcm-kernel-feedback-list@broadcom.com
---
 arch/arm/mach-bcm/platsmp.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Scott Branden Oct. 8, 2019, 5:56 p.m. UTC | #1
On 2019-10-08 5:34 a.m., Ben Dooks wrote:
> Include platsmp.h for the definition of bcm2836_smp_ops to fix
> the following warning:
>
> arch/arm/mach-bcm/platsmp.c:334:29: warning: symbol 'bcm2836_smp_ops' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Acked-by: Scott Branden <scott.branden@broadcom.com>
> ---
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: bcm-kernel-feedback-list@broadcom.com
> ---
>   arch/arm/mach-bcm/platsmp.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
> index 47f8053d0240..21400b3fa5fe 100644
> --- a/arch/arm/mach-bcm/platsmp.c
> +++ b/arch/arm/mach-bcm/platsmp.c
> @@ -22,6 +22,8 @@
>   #include <asm/smp_plat.h>
>   #include <asm/smp_scu.h>
>   
> +#include "platsmp.h"
> +
>   /* Size of mapped Cortex A9 SCU address space */
>   #define CORTEX_A9_SCU_SIZE	0x58
>
Florian Fainelli Oct. 15, 2019, 11:16 p.m. UTC | #2
On Tue,  8 Oct 2019 13:34:43 +0100, Ben Dooks <ben.dooks@codethink.co.uk> wrote:
> Include platsmp.h for the definition of bcm2836_smp_ops to fix
> the following warning:
> 
> arch/arm/mach-bcm/platsmp.c:334:29: warning: symbol 'bcm2836_smp_ops' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---

Applied to soc/next, thanks!
--
Florian
diff mbox series

Patch

diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c
index 47f8053d0240..21400b3fa5fe 100644
--- a/arch/arm/mach-bcm/platsmp.c
+++ b/arch/arm/mach-bcm/platsmp.c
@@ -22,6 +22,8 @@ 
 #include <asm/smp_plat.h>
 #include <asm/smp_scu.h>
 
+#include "platsmp.h"
+
 /* Size of mapped Cortex A9 SCU address space */
 #define CORTEX_A9_SCU_SIZE	0x58