mbox series

[v8,0/6] Enable Transcoder port sync for Tiled displays

Message ID 20191015230519.15022-1-manasi.d.navare@intel.com (mailing list archive)
Headers show
Series Enable Transcoder port sync for Tiled displays | expand

Message

Navare, Manasi Oct. 15, 2019, 11:05 p.m. UTC
This set of patches enables transcoder port sync to synchronize tiled displays
across multiple SST DP ports using the master-slave model.
This has been tested with kms_dp_tiled_display.c IGT test which validates
the page flip synchronization.

This set of patches addresses the final set of comments from Ville
and Maarten.

Manasi Navare (6):
  drm/i915/display/icl: Save Master transcoder in slave's crtc_state for
    Transcoder Port Sync
  drm/i915/display/icl: Enable TRANSCODER PORT SYNC for tiled displays
    across separate ports
  drm/i915/display/icl: HW state readout for transcoder port sync config
  drm/i915/display/icl: Enable master-slaves in trans port sync
  drm/i915/display/icl: Disable transcoder port sync as part of
    crtc_disable() sequence
  drm/i915/display/icl: In port sync mode disable slaves first then
    master

 drivers/gpu/drm/i915/display/intel_ddi.c      |   3 +-
 drivers/gpu/drm/i915/display/intel_display.c  | 428 +++++++++++++++++-
 drivers/gpu/drm/i915/display/intel_display.h  |   4 +
 .../drm/i915/display/intel_display_types.h    |   6 +
 4 files changed, 431 insertions(+), 10 deletions(-)

Comments

Ville Syrjälä Oct. 16, 2019, 2:20 p.m. UTC | #1
On Wed, Oct 16, 2019 at 01:02:08AM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: Enable Transcoder port sync for Tiled displays (rev2)
> URL   : https://patchwork.freedesktop.org/series/68062/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_7100 -> Patchwork_14824
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_14824 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_14824, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/index.html
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_14824:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@runner@aborted:
>     - fi-ilk-650:         NOTRUN -> [FAIL][1]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-ilk-650/igt@runner@aborted.html
>     - fi-gdg-551:         NOTRUN -> [FAIL][2]
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-gdg-551/igt@runner@aborted.html
>     - fi-snb-2520m:       NOTRUN -> [FAIL][3]
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-snb-2520m/igt@runner@aborted.html
>     - fi-ivb-3770:        NOTRUN -> [FAIL][4]
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-ivb-3770/igt@runner@aborted.html
>     - fi-blb-e6850:       NOTRUN -> [FAIL][5]
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-blb-e6850/igt@runner@aborted.html
>     - fi-bsw-kefka:       NOTRUN -> [FAIL][6]
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-bsw-kefka/igt@runner@aborted.html
>     - fi-elk-e7500:       NOTRUN -> [FAIL][7]
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-elk-e7500/igt@runner@aborted.html

Still missing the master_transcoder "readout" for pre-hsw.
Navare, Manasi Oct. 16, 2019, 6:13 p.m. UTC | #2
On Wed, Oct 16, 2019 at 05:20:10PM +0300, Ville Syrjälä wrote:
> On Wed, Oct 16, 2019 at 01:02:08AM -0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: Enable Transcoder port sync for Tiled displays (rev2)
> > URL   : https://patchwork.freedesktop.org/series/68062/
> > State : failure
> > 
> > == Summary ==
> > 
> > CI Bug Log - changes from CI_DRM_7100 -> Patchwork_14824
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **FAILURE**
> > 
> >   Serious unknown changes coming with Patchwork_14824 absolutely need to be
> >   verified manually.
> >   
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in Patchwork_14824, please notify your bug team to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> > 
> >   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/index.html
> > 
> > Possible new issues
> > -------------------
> > 
> >   Here are the unknown changes that may have been introduced in Patchwork_14824:
> > 
> > ### IGT changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * igt@runner@aborted:
> >     - fi-ilk-650:         NOTRUN -> [FAIL][1]
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-ilk-650/igt@runner@aborted.html
> >     - fi-gdg-551:         NOTRUN -> [FAIL][2]
> >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-gdg-551/igt@runner@aborted.html
> >     - fi-snb-2520m:       NOTRUN -> [FAIL][3]
> >    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-snb-2520m/igt@runner@aborted.html
> >     - fi-ivb-3770:        NOTRUN -> [FAIL][4]
> >    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-ivb-3770/igt@runner@aborted.html
> >     - fi-blb-e6850:       NOTRUN -> [FAIL][5]
> >    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-blb-e6850/igt@runner@aborted.html
> >     - fi-bsw-kefka:       NOTRUN -> [FAIL][6]
> >    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-bsw-kefka/igt@runner@aborted.html
> >     - fi-elk-e7500:       NOTRUN -> [FAIL][7]
> >    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_14824/fi-elk-e7500/igt@runner@aborted.html
> 
> Still missing the master_transcoder "readout" for pre-hsw.
>

Yes I added the master_trans initialization to -1 to the haswell_get_config hook, but looks like
I need to just add it to verify_crtc_state() before calling the get_config() for any platform.
That should possibly fix it

manasi
 
> -- 
> Ville Syrjälä
> Intel