| Message ID | 20191017123007.26335-1-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: actions: owl-sps: include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg | expand |
Hello Ben, Am Donnerstag, den 17.10.2019, 13:30 +0100 schrieb Ben Dooks (Codethink): > Include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg > declaration to fix the following sparse warning: > > drivers/soc/actions/owl-sps-helper.c:16:5: warning: symbol > 'owl_sps_set_pg' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> > --- > Cc: "Andreas Färber" <afaerber@suse.de> > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/soc/actions/owl-sps-helper.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/soc/actions/owl-sps-helper.c > b/drivers/soc/actions/owl-sps-helper.c > index 291a206d6f04..f35cf3c6d23c 100644 > --- a/drivers/soc/actions/owl-sps-helper.c > +++ b/drivers/soc/actions/owl-sps-helper.c > @@ -11,6 +11,8 @@ > #include <linux/delay.h> > #include <linux/io.h> > > +#include <linux/soc/actions/owl-sps.h> Any reason for the white line before? Also, could you explain why we did not get that warning during earlier builds? Should there be a Fixes? Thanks, Andreas > + > #define OWL_SPS_PG_CTL 0x0 > > int owl_sps_set_pg(void __iomem *base, u32 pwr_mask, u32 ack_mask, > bool enable)
On 17/10/2019 15:43, Andreas Färber wrote: > Hello Ben, > > Am Donnerstag, den 17.10.2019, 13:30 +0100 schrieb Ben Dooks > (Codethink): >> Include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg >> declaration to fix the following sparse warning: >> >> drivers/soc/actions/owl-sps-helper.c:16:5: warning: symbol >> 'owl_sps_set_pg' was not declared. Should it be static? >> >> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> >> --- >> Cc: "Andreas Färber" <afaerber@suse.de> >> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >> Cc: linux-arm-kernel@lists.infradead.org >> --- >> drivers/soc/actions/owl-sps-helper.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/soc/actions/owl-sps-helper.c >> b/drivers/soc/actions/owl-sps-helper.c >> index 291a206d6f04..f35cf3c6d23c 100644 >> --- a/drivers/soc/actions/owl-sps-helper.c >> +++ b/drivers/soc/actions/owl-sps-helper.c >> @@ -11,6 +11,8 @@ >> #include <linux/delay.h> >> #include <linux/io.h> >> >> +#include <linux/soc/actions/owl-sps.h> > > Any reason for the white line before? I added it as some people tend to when moving onto a new group of includes in a different directory. > Also, could you explain why we did not get that warning during earlier > builds? Should there be a Fixes? It is a warning from sparse, so not run as standard when building. I've not been putting fixes on as it isn't really a bug. > Thanks, > Andreas > >> + >> #define OWL_SPS_PG_CTL 0x0 >> >> int owl_sps_set_pg(void __iomem *base, u32 pwr_mask, u32 ack_mask, >> bool enable)
diff --git a/drivers/soc/actions/owl-sps-helper.c b/drivers/soc/actions/owl-sps-helper.c index 291a206d6f04..f35cf3c6d23c 100644 --- a/drivers/soc/actions/owl-sps-helper.c +++ b/drivers/soc/actions/owl-sps-helper.c @@ -11,6 +11,8 @@ #include <linux/delay.h> #include <linux/io.h> +#include <linux/soc/actions/owl-sps.h> + #define OWL_SPS_PG_CTL 0x0 int owl_sps_set_pg(void __iomem *base, u32 pwr_mask, u32 ack_mask, bool enable)
Include <linux/soc/actions/owl-sps.h> for owl_sps_set_pg declaration to fix the following sparse warning: drivers/soc/actions/owl-sps-helper.c:16:5: warning: symbol 'owl_sps_set_pg' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: "Andreas Färber" <afaerber@suse.de> Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Cc: linux-arm-kernel@lists.infradead.org --- drivers/soc/actions/owl-sps-helper.c | 2 ++ 1 file changed, 2 insertions(+)