mbox series

[0/2] PCI/PM: Use dev_printk() when possible

Message ID 20191017212851.54237-1-helgaas@kernel.org (mailing list archive)
Headers show
Series PCI/PM: Use dev_printk() when possible | expand

Message

Bjorn Helgaas Oct. 17, 2019, 9:28 p.m. UTC
From: Bjorn Helgaas <bhelgaas@google.com>

Some PM messages, e.g., "PCI PM: Device state not saved by %pS\n", had no
indication of what device was affected.  Add pci_WARN() and use it.

Bjorn Helgaas (2):
  PCI/PM: Use PCI dev_printk() wrappers for consistency
  PCI/PM: Use pci_WARN() to include device information

 drivers/pci/pci-driver.c | 45 ++++++++++++++++++++--------------------
 include/linux/pci.h      |  8 +++++++
 2 files changed, 31 insertions(+), 22 deletions(-)

Comments

Rafael J. Wysocki Oct. 18, 2019, 10:26 a.m. UTC | #1
On Thursday, October 17, 2019 11:28:49 PM CEST Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Some PM messages, e.g., "PCI PM: Device state not saved by %pS\n", had no
> indication of what device was affected.  Add pci_WARN() and use it.
> 
> Bjorn Helgaas (2):
>   PCI/PM: Use PCI dev_printk() wrappers for consistency
>   PCI/PM: Use pci_WARN() to include device information
> 
>  drivers/pci/pci-driver.c | 45 ++++++++++++++++++++--------------------
>  include/linux/pci.h      |  8 +++++++
>  2 files changed, 31 insertions(+), 22 deletions(-)
> 
> 

Good cleanups!

For both

Reviewed-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>