| Message ID | 20191018095823.15282-1-jthumshirn@suse.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | Small coding style cleanups | expand |
On 18.10.19 г. 12:58 ч., Johannes Thumshirn wrote: > Here are some minor coding style cleanups which I think are neat as they make > some functions a bit easier to read. > > None of these patches is really needed though. > > The patches have no regressions with regrads to the basline > btrfs-devel/misc-next on an xfstests -g auto run. > > A gitweb preview can be found at > https://git.kernel.org/pub/scm/linux/kernel/git/jth/linux.git/log/?h=btrfs-raid-cleanups > > Note I did rebase the branch because one patch did not have a changelog. > > Johannes Thumshirn (4): > btrfs: reduce indentation in lock_stripe_add > btrfs: remove pointless local variable in lock_stripe_add() > btrfs: reduce indentation in btrfs_may_alloc_data_chunk > btrfs: remove pointless indentation in btrfs_read_sys_array() > > fs/btrfs/raid56.c | 95 ++++++++++++++++++++++----------------------- > fs/btrfs/volumes.c | 112 +++++++++++++++++++++++++++-------------------------- > 2 files changed, 103 insertions(+), 104 deletions(-) > Patches 2-4 LGTM you can add, : Reviewed-by: Nikolay Borisov <nborisov@suse.com>
On 18/10/2019 14:02, Nikolay Borisov wrote:
[...]
> Patches 2-4 LGTM you can add, :
What's wrong with 1/4?
On 21.10.19 г. 11:06 ч., Johannes Thumshirn wrote: > On 18/10/2019 14:02, Nikolay Borisov wrote: > [...] > >> Patches 2-4 LGTM you can add, : > > What's wrong with 1/4? Nothing per-se but it looked ugly and my brain refused to make sense of it so I haven't really reviewed it :) . > > >
On 21/10/2019 14:32, Nikolay Borisov wrote: > > > On 21.10.19 г. 11:06 ч., Johannes Thumshirn wrote: >> On 18/10/2019 14:02, Nikolay Borisov wrote: >> [...] >> >>> Patches 2-4 LGTM you can add, : >> >> What's wrong with 1/4? > > Nothing per-se but it looked ugly and my brain refused to make sense of > it so I haven't really reviewed it :) . It will look less ugly after the patch is applied ;-) https://git.kernel.org/pub/scm/linux/kernel/git/jth/linux.git/tree/fs/btrfs/raid56.c?h=btrfs-raid-cleanups&id=ad33a49606b6f31c7fe20aa089f5603ad3065bd5#n684
On Fri, Oct 18, 2019 at 11:58:19AM +0200, Johannes Thumshirn wrote: > Here are some minor coding style cleanups which I think are neat as they make > some functions a bit easier to read. > > None of these patches is really needed though. > > The patches have no regressions with regrads to the basline > btrfs-devel/misc-next on an xfstests -g auto run. > > A gitweb preview can be found at > https://git.kernel.org/pub/scm/linux/kernel/git/jth/linux.git/log/?h=btrfs-raid-cleanups > > Note I did rebase the branch because one patch did not have a changelog. > > Johannes Thumshirn (4): > btrfs: reduce indentation in lock_stripe_add > btrfs: remove pointless local variable in lock_stripe_add() > btrfs: reduce indentation in btrfs_may_alloc_data_chunk > btrfs: remove pointless indentation in btrfs_read_sys_array() Added to misc-next, thanks.