| Message ID | 20190823140855.4222-1-jeff.kubascik@dornerworks.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | MAINTAINERS: Add DornerWorks maintainers email | expand |
> On Aug 23, 2019, at 3:08 PM, Jeff Kubascik <jeff.kubascik@dornerworks.com> wrote: > > We would like to have a common maintainers email address for DornerWorks > maintained code, which currently is the ARINC653 scheduler. This will > enable us to better monitor and respond to the Xen community. This patch > adds a maintainer line with the DornerWorks maintainers email address. > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 77413e0d9e..3cce253931 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -168,6 +168,7 @@ F: xen/common/argo.c > ARINC653 SCHEDULER > M: Josh Whitehead <josh.whitehead@dornerworks.com> > M: Robert VanVossen <robert.vanvossen@dornerworks.com> > +M: DornerWorks Xen-Devel <xen-devel@dornerworks.com> Maintainership implies a certain level of authority. I think you want R: here instead, which is “Designated reviewer”: you get mail, but don’t have any authority. -George
On 8/23/2019 10:11 AM, George Dunlap wrote: > CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. > >> On Aug 23, 2019, at 3:08 PM, Jeff Kubascik <jeff.kubascik@dornerworks.com> wrote: >> >> We would like to have a common maintainers email address for DornerWorks >> maintained code, which currently is the ARINC653 scheduler. This will >> enable us to better monitor and respond to the Xen community. This patch >> adds a maintainer line with the DornerWorks maintainers email address. >> --- >> MAINTAINERS | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 77413e0d9e..3cce253931 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -168,6 +168,7 @@ F: xen/common/argo.c >> ARINC653 SCHEDULER >> M: Josh Whitehead <josh.whitehead@dornerworks.com> >> M: Robert VanVossen <robert.vanvossen@dornerworks.com> >> +M: DornerWorks Xen-Devel <xen-devel@dornerworks.com> > > Maintainership implies a certain level of authority. I think you want R: here instead, which is “Designated reviewer”: you get mail, but don’t have any authority. > > -George > That is a fair point, I will update the patch accordingly. -Jeff
On Fri, Aug 23, 2019 at 10:08:55AM -0400, Jeff Kubascik wrote: > We would like to have a common maintainers email address for DornerWorks > maintained code, which currently is the ARINC653 scheduler. This will > enable us to better monitor and respond to the Xen community. This patch > adds a maintainer line with the DornerWorks maintainers email address. > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 77413e0d9e..3cce253931 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -168,6 +168,7 @@ F: xen/common/argo.c > ARINC653 SCHEDULER > M: Josh Whitehead <josh.whitehead@dornerworks.com> > M: Robert VanVossen <robert.vanvossen@dornerworks.com> > +M: DornerWorks Xen-Devel <xen-devel@dornerworks.com> The correct symbol here is L. L: Mailing list that is relevant to this area > S: Supported > F: xen/common/sched_arinc653.c > F: tools/libxc/xc_arinc653.c > -- > 2.17.1 >
On 8/30/19 10:28 AM, Wei Liu wrote: > On Fri, Aug 23, 2019 at 10:08:55AM -0400, Jeff Kubascik wrote: >> We would like to have a common maintainers email address for DornerWorks >> maintained code, which currently is the ARINC653 scheduler. This will >> enable us to better monitor and respond to the Xen community. This patch >> adds a maintainer line with the DornerWorks maintainers email address. >> --- >> MAINTAINERS | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index 77413e0d9e..3cce253931 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -168,6 +168,7 @@ F: xen/common/argo.c >> ARINC653 SCHEDULER >> M: Josh Whitehead <josh.whitehead@dornerworks.com> >> M: Robert VanVossen <robert.vanvossen@dornerworks.com> >> +M: DornerWorks Xen-Devel <xen-devel@dornerworks.com> > > The correct symbol here is L. > > L: Mailing list that is relevant to this area But this isn't exactly a mailing list, is it? The 'L:' tag is normally for things like the Linux Arm mailing list, the Linux Net mailing list, and so on -- *public* lists where discussions about that subsystem happen. This isn't a public list where discussion happens. At the moment, in fact, it looks like it might be a *single email account*, to which several people have access; at best it would be an alias that would go to a number of interested parties. That seems closer to 'R:'. I admit this is getting into the minutia of technicalities here. :-) -George
On Mon, Oct 21, 2019 at 12:29:45PM +0100, George Dunlap wrote: > On 8/30/19 10:28 AM, Wei Liu wrote: > > On Fri, Aug 23, 2019 at 10:08:55AM -0400, Jeff Kubascik wrote: > >> We would like to have a common maintainers email address for DornerWorks > >> maintained code, which currently is the ARINC653 scheduler. This will > >> enable us to better monitor and respond to the Xen community. This patch > >> adds a maintainer line with the DornerWorks maintainers email address. > >> --- > >> MAINTAINERS | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/MAINTAINERS b/MAINTAINERS > >> index 77413e0d9e..3cce253931 100644 > >> --- a/MAINTAINERS > >> +++ b/MAINTAINERS > >> @@ -168,6 +168,7 @@ F: xen/common/argo.c > >> ARINC653 SCHEDULER > >> M: Josh Whitehead <josh.whitehead@dornerworks.com> > >> M: Robert VanVossen <robert.vanvossen@dornerworks.com> > >> +M: DornerWorks Xen-Devel <xen-devel@dornerworks.com> > > > > The correct symbol here is L. > > > > L: Mailing list that is relevant to this area > > But this isn't exactly a mailing list, is it? The 'L:' tag is normally > for things like the Linux Arm mailing list, the Linux Net mailing list, > and so on -- *public* lists where discussions about that subsystem happen. > > This isn't a public list where discussion happens. At the moment, in > fact, it looks like it might be a *single email account*, to which > several people have access; at best it would be an alias that would go > to a number of interested parties. That seems closer to 'R:'. > > I admit this is getting into the minutia of technicalities here. :-) > My understanding is that the list being public is a not a requirement. For example, Linux has this: L: sparmaintainer@unisys.com (Unisys internal) An alias for several people still qualifies as a list to me. Anyway, either R or L works. I don't want to bikeshed further... Wei. > -George
On 10/21/2019 7:43 AM, Wei Liu wrote: > CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. > > On Mon, Oct 21, 2019 at 12:29:45PM +0100, George Dunlap wrote: >> On 8/30/19 10:28 AM, Wei Liu wrote: >>> On Fri, Aug 23, 2019 at 10:08:55AM -0400, Jeff Kubascik wrote: >>>> We would like to have a common maintainers email address for DornerWorks >>>> maintained code, which currently is the ARINC653 scheduler. This will >>>> enable us to better monitor and respond to the Xen community. This patch >>>> adds a maintainer line with the DornerWorks maintainers email address. >>>> --- >>>> MAINTAINERS | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index 77413e0d9e..3cce253931 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -168,6 +168,7 @@ F: xen/common/argo.c >>>> ARINC653 SCHEDULER >>>> M: Josh Whitehead <josh.whitehead@dornerworks.com> >>>> M: Robert VanVossen <robert.vanvossen@dornerworks.com> >>>> +M: DornerWorks Xen-Devel <xen-devel@dornerworks.com> >>> >>> The correct symbol here is L. >>> >>> L: Mailing list that is relevant to this area >> >> But this isn't exactly a mailing list, is it? The 'L:' tag is normally >> for things like the Linux Arm mailing list, the Linux Net mailing list, >> and so on -- *public* lists where discussions about that subsystem happen. >> >> This isn't a public list where discussion happens. At the moment, in >> fact, it looks like it might be a *single email account*, to which >> several people have access; at best it would be an alias that would go >> to a number of interested parties. That seems closer to 'R:'. >> >> I admit this is getting into the minutia of technicalities here. :-) >> > > My understanding is that the list being public is a not a requirement. > For example, Linux has this: > > L: sparmaintainer@unisys.com (Unisys internal) > > An alias for several people still qualifies as a list to me. > > Anyway, either R or L works. I don't want to bikeshed further... > > Wei. > >> -George We would like to remove our current two developers who are listed as M: for the ARINC653 scheduler code. Since M: is just a "Mail patches to" designation, I'm now leaning towards the L: designation, as the two appear roughly equivalent in their role. Does that sound reasonable? -Jeff K
Hi, Jumping into the conversation. On 24/10/2019 14:06, Jeff Kubascik wrote: > On 10/21/2019 7:43 AM, Wei Liu wrote: >> CAUTION: This email originated from outside the organization. Do not click links or open attachments unless you recognize the sender and know the content is safe. >> >> On Mon, Oct 21, 2019 at 12:29:45PM +0100, George Dunlap wrote: >>> On 8/30/19 10:28 AM, Wei Liu wrote: >>>> On Fri, Aug 23, 2019 at 10:08:55AM -0400, Jeff Kubascik wrote: >>>>> We would like to have a common maintainers email address for DornerWorks >>>>> maintained code, which currently is the ARINC653 scheduler. This will >>>>> enable us to better monitor and respond to the Xen community. This patch >>>>> adds a maintainer line with the DornerWorks maintainers email address. >>>>> --- >>>>> MAINTAINERS | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>>> index 77413e0d9e..3cce253931 100644 >>>>> --- a/MAINTAINERS >>>>> +++ b/MAINTAINERS >>>>> @@ -168,6 +168,7 @@ F: xen/common/argo.c >>>>> ARINC653 SCHEDULER >>>>> M: Josh Whitehead <josh.whitehead@dornerworks.com> >>>>> M: Robert VanVossen <robert.vanvossen@dornerworks.com> >>>>> +M: DornerWorks Xen-Devel <xen-devel@dornerworks.com> >>>> >>>> The correct symbol here is L. >>>> >>>> L: Mailing list that is relevant to this area >>> >>> But this isn't exactly a mailing list, is it? The 'L:' tag is normally >>> for things like the Linux Arm mailing list, the Linux Net mailing list, >>> and so on -- *public* lists where discussions about that subsystem happen. >>> >>> This isn't a public list where discussion happens. At the moment, in >>> fact, it looks like it might be a *single email account*, to which >>> several people have access; at best it would be an alias that would go >>> to a number of interested parties. That seems closer to 'R:'. >>> >>> I admit this is getting into the minutia of technicalities here. :-) >>> >> >> My understanding is that the list being public is a not a requirement. >> For example, Linux has this: >> >> L: sparmaintainer@unisys.com (Unisys internal) >> >> An alias for several people still qualifies as a list to me. >> >> Anyway, either R or L works. I don't want to bikeshed further... >> >> Wei. >> >>> -George > > We would like to remove our current two developers who are listed as M: for the > ARINC653 scheduler code. Since M: is just a "Mail patches to" designation, I'm > now leaning towards the L: designation, as the two appear roughly equivalent in > their role. Does that sound reasonable? I don't think you can treat "L:" and "M:" the same way. "M:" is a single person that we know. "L:" is a list of person that we don't know. xen-devel@dornerworks.com definitely falls into the "L:" category. That clearly raises a few questions here. - How do we know when the list of person change? - How acked-by/reviewed-by will be done? Will it be Acked-by "Dornerworks <....>"? If not, then we still need "M:" around to which acked-by is sufficient. If yes, how do we know all the person on that list can be trusted? Cheers,
On 24.10.2019 15:06, Jeff Kubascik wrote: > We would like to remove our current two developers who are listed as M: for the > ARINC653 scheduler code. Since M: is just a "Mail patches to" designation, I'm > now leaning towards the L: designation, as the two appear roughly equivalent in > their role. Does that sound reasonable? While I realize what you say matches what the description of M: says in ./MAINTAINERS, I'm afraid we also assign the meaning of "is the maintainer of" to it, i.e. L: is not a suitable equivalent (at least I don't think a list can reasonably be considered a "maintainer"). It should perhaps rather be R: the have this meaning. As a side note, in addition I notice that M: says to mail patches _to_ the listed people, which contradicts information on e.g. the wiki where people are asked to send patches _to_ the list, with maintainers _cc_-ed (personally I prefer the latter very much). Jan
On Thursday, October 24, 2019 9:37 AM, Julien Grall wrote: >Hi, > >Jumping into the conversation. > >On 24/10/2019 14:06, Jeff Kubascik wrote: >> We would like to remove our current two developers who are listed as M: for the >> ARINC653 scheduler code. Since M: is just a "Mail patches to" designation, I'm >> now leaning towards the L: designation, as the two appear roughly equivalent in >> their role. Does that sound reasonable? > >I don't think you can treat "L:" and "M:" the same way. > >"M:" is a single person that we know. > >"L:" is a list of person that we don't know. > >xen-devel@dornerworks.com definitely falls into the "L:" category. That clearly >raises a few questions here. > > - How do we know when the list of person change? > - How acked-by/reviewed-by will be done? Will it be Acked-by "Dornerworks ><....>"? If not, then we still need "M:" around to which acked-by is sufficient. >If yes, how do we know all the person on that list can be trusted? The rationale for removing Robbie and Josh is that they are currently active on other projects that don't involve Xen. I'm involved with Xen and I'm the tech lead for our product that actually uses the ARINC 653 scheduler, so I'll volunteer myself to replace Robbie and Josh. This way we will still have a real person with an M: for the ARINC 653 scheduler in MANTAINERS. We would still like to add our internal list. It seems L: is a fairly agreeable designation for the list. L: DornerWorks Xen-Devel <xen-devel@dornerworks.com> Thanks, Stew
diff --git a/MAINTAINERS b/MAINTAINERS index 77413e0d9e..3cce253931 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -168,6 +168,7 @@ F: xen/common/argo.c ARINC653 SCHEDULER M: Josh Whitehead <josh.whitehead@dornerworks.com> M: Robert VanVossen <robert.vanvossen@dornerworks.com> +M: DornerWorks Xen-Devel <xen-devel@dornerworks.com> S: Supported F: xen/common/sched_arinc653.c F: tools/libxc/xc_arinc653.c