| Message ID | 1312897232-4792-5-git-send-email-manjugk@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi On Tue, 09 Aug 2011 19:10:22 +0500 "G, Manjunath Kondaiah" <manjugk@ti.com> wrote: > From: Kevin Hilman <khilman@ti.com> > > For converting from struct device to platform_device, and from > platform_device to struct device, there are existing macros. Use > them instead of manual use of container_of(). > > Signed-off-by: Kevin Hilman <khilman@ti.com> > --- > arch/arm/plat-omap/mcbsp.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > Kevin dropped this patch and used mine that does more cleanups: http://marc.info/?l=linux-omap&m=131255627918065&w=2 Worth to check also other patches since Kevin's updated set seems to have other differences too: http://marc.info/?l=linux-omap&m=131258997416300&w=2
Manju, On 8/10/2011 9:07 AM, Jarkko Nikula wrote: > Hi > > On Tue, 09 Aug 2011 19:10:22 +0500 > "G, Manjunath Kondaiah"<manjugk@ti.com> wrote: > >> From: Kevin Hilman<khilman@ti.com> >> >> For converting from struct device to platform_device, and from >> platform_device to struct device, there are existing macros. Use >> them instead of manual use of container_of(). >> >> Signed-off-by: Kevin Hilman<khilman@ti.com> >> --- >> arch/arm/plat-omap/mcbsp.c | 6 +++--- >> 1 files changed, 3 insertions(+), 3 deletions(-) >> > Kevin dropped this patch and used mine that does more cleanups: > > http://marc.info/?l=linux-omap&m=131255627918065&w=2 > > Worth to check also other patches since Kevin's updated set seems to > have other differences too: > > http://marc.info/?l=linux-omap&m=131258997416300&w=2 In fact, you'd better point to the lastest Kevin's tree and not included the patches in this series. Benoit -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Aug 10, 2011 at 12:15:50PM +0200, Cousson, Benoit wrote: > Manju, > > On 8/10/2011 9:07 AM, Jarkko Nikula wrote: > >Hi > > > >On Tue, 09 Aug 2011 19:10:22 +0500 > >"G, Manjunath Kondaiah"<manjugk@ti.com> wrote: > > > >>From: Kevin Hilman<khilman@ti.com> > >> > >>For converting from struct device to platform_device, and from > >>platform_device to struct device, there are existing macros. Use > >>them instead of manual use of container_of(). > >> > >>Signed-off-by: Kevin Hilman<khilman@ti.com> > >>--- > >> arch/arm/plat-omap/mcbsp.c | 6 +++--- > >> 1 files changed, 3 insertions(+), 3 deletions(-) > >> > >Kevin dropped this patch and used mine that does more cleanups: > > > >http://marc.info/?l=linux-omap&m=131255627918065&w=2 > > > >Worth to check also other patches since Kevin's updated set seems to > >have other differences too: > > > >http://marc.info/?l=linux-omap&m=131258997416300&w=2 > > In fact, you'd better point to the lastest Kevin's tree and not > included the patches in this series. Yes. I have already mentioned this in PATCH 00/14 and it will be rebased during rework for review comments. Main focus here is on dt-hwmod binding and omap-i2c dt adaptation. -M -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/plat-omap/mcbsp.c b/arch/arm/plat-omap/mcbsp.c index 5587acf..3f4a45d 100644 --- a/arch/arm/plat-omap/mcbsp.c +++ b/arch/arm/plat-omap/mcbsp.c @@ -295,9 +295,9 @@ EXPORT_SYMBOL(omap_mcbsp_dma_reg_params); #ifdef CONFIG_ARCH_OMAP3 static struct omap_device *find_omap_device_by_dev(struct device *dev) { - struct platform_device *pdev = container_of(dev, - struct platform_device, dev); - return container_of(pdev, struct omap_device, pdev); + struct platform_device *pdev = to_platform_device(dev); + + return to_omap_device(pdev); } static void omap_st_on(struct omap_mcbsp *mcbsp)