diff mbox series

[v5,3/4] soc: samsung: Add Exynos Adaptive Supply Voltage driver

Message ID 20191016145756.16004-4-s.nawrocki@samsung.com (mailing list archive)
State Superseded
Headers show
Series Exynos Adaptive Supply Voltage support | expand

Commit Message

Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics Oct. 16, 2019, 2:57 p.m. UTC 
The Adaptive Supply Voltage (ASV) driver adjusts CPU cluster operating
points depending on exact revision of an SoC retrieved from the CHIPID
block or the OTP memory.  This allows for some power saving as for some
CPU clock frequencies we can lower CPU cluster's supply voltage comparing
to safe values common to all the SoC revisions.

This patch adds support for Exynos5422/5800 SoC, it is partially based
on code from https://github.com/hardkernel/linux repository,
branch odroidxu4-4.14.y, files: arch/arm/mach-exynos/exynos5422-asv.[ch].

Tested on Odroid XU3, XU4, XU3 Lite.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
---
Changes since v4:
 - Fixed include guard in drivers/soc/samsung/exynos5422-asv.h

Changes since v3:
 - instead of removing/adding OPP use dedicated API to adjust OPP's
   voltage, only exynos_asv_update_cpu_opps() function has changed,
 - added a comment describing ASV tables at beginning of
   exynos5422-asv.c file.

Changes since v2:
 - use devm_kzalloc() in probe() to avoid memory leak,
 - removed leading spaces in exynos-chipid.h,
 - removed unneeded <linux/init.h> header inclusion,
 - dropped parentheses from exynos542_asv_parse_sg(),
 - updated Kconfig entry,
 - added const attribute to struct exynos_asv_susbsys::cpu_dt_compat.

Changes since v1 (RFC):
 - removed code for parsing the ASV OPP tables from DT, the ASV OPP tables
   moved to the driver,
 - converted to use the regmap API,
 - converted to normal platform driver.

 drivers/soc/samsung/Kconfig          |  10 +
 drivers/soc/samsung/Makefile         |   3 +
 drivers/soc/samsung/exynos-asv.c     | 179 ++++++++++
 drivers/soc/samsung/exynos-asv.h     |  82 +++++
 drivers/soc/samsung/exynos5422-asv.c | 509 +++++++++++++++++++++++++++
 drivers/soc/samsung/exynos5422-asv.h |  25 ++
 6 files changed, 808 insertions(+)
 create mode 100644 drivers/soc/samsung/exynos-asv.c
 create mode 100644 drivers/soc/samsung/exynos-asv.h
 create mode 100644 drivers/soc/samsung/exynos5422-asv.c
 create mode 100644 drivers/soc/samsung/exynos5422-asv.h

--
2.17.1

Comments

Krzysztof Kozlowski Oct. 22, 2019, 7:04 p.m. UTC | #1 
On Wed, Oct 16, 2019 at 04:57:55PM +0200, Sylwester Nawrocki wrote:
> The Adaptive Supply Voltage (ASV) driver adjusts CPU cluster operating
> points depending on exact revision of an SoC retrieved from the CHIPID
> block or the OTP memory.  This allows for some power saving as for some
> CPU clock frequencies we can lower CPU cluster's supply voltage comparing
> to safe values common to all the SoC revisions.
> 
> This patch adds support for Exynos5422/5800 SoC, it is partially based
> on code from https://github.com/hardkernel/linux repository,
> branch odroidxu4-4.14.y, files: arch/arm/mach-exynos/exynos5422-asv.[ch].
> 
> Tested on Odroid XU3, XU4, XU3 Lite.
> 
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>

Hi Sylwester,

I wanted to apply this patch but spotted some unusual printk... and then started looking for more...

Sparse complains:
../drivers/soc/samsung/exynos5422-asv.c:457:5: warning: symbol 'exynos5422_asv_init' was not declared. Should it be static?


> ---
> Changes since v4:
>  - Fixed include guard in drivers/soc/samsung/exynos5422-asv.h
> 
> Changes since v3:
>  - instead of removing/adding OPP use dedicated API to adjust OPP's
>    voltage, only exynos_asv_update_cpu_opps() function has changed,
>  - added a comment describing ASV tables at beginning of
>    exynos5422-asv.c file.
> 
> Changes since v2:
>  - use devm_kzalloc() in probe() to avoid memory leak,
>  - removed leading spaces in exynos-chipid.h,
>  - removed unneeded <linux/init.h> header inclusion,
>  - dropped parentheses from exynos542_asv_parse_sg(),
>  - updated Kconfig entry,
>  - added const attribute to struct exynos_asv_susbsys::cpu_dt_compat.
> 
> Changes since v1 (RFC):
>  - removed code for parsing the ASV OPP tables from DT, the ASV OPP tables
>    moved to the driver,
>  - converted to use the regmap API,
>  - converted to normal platform driver.
> 
>  drivers/soc/samsung/Kconfig          |  10 +
>  drivers/soc/samsung/Makefile         |   3 +
>  drivers/soc/samsung/exynos-asv.c     | 179 ++++++++++
>  drivers/soc/samsung/exynos-asv.h     |  82 +++++
>  drivers/soc/samsung/exynos5422-asv.c | 509 +++++++++++++++++++++++++++
>  drivers/soc/samsung/exynos5422-asv.h |  25 ++
>  6 files changed, 808 insertions(+)
>  create mode 100644 drivers/soc/samsung/exynos-asv.c
>  create mode 100644 drivers/soc/samsung/exynos-asv.h
>  create mode 100644 drivers/soc/samsung/exynos5422-asv.c
>  create mode 100644 drivers/soc/samsung/exynos5422-asv.h
> 
> diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig
> index 33ad0de2de3c..27fc59bbb520 100644
> --- a/drivers/soc/samsung/Kconfig
> +++ b/drivers/soc/samsung/Kconfig
> @@ -7,6 +7,16 @@ menuconfig SOC_SAMSUNG
> 
>  if SOC_SAMSUNG
> 
> +config EXYNOS_ASV
> +	bool "Exynos Adaptive Supply Voltage support" if COMPILE_TEST
> +	depends on (ARCH_EXYNOS && EXYNOS_CHIPID) || COMPILE_TEST
> +	select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS
> +
> +# There is no need to enable these drivers for ARMv8
> +config EXYNOS_ASV_ARM
> +	bool "Exynos ASV ARMv7-specific driver extensions" if COMPILE_TEST
> +	depends on EXYNOS_ASV
> +
>  config EXYNOS_CHIPID
>  	bool "Exynos Chipid controller driver" if COMPILE_TEST
>  	depends on ARCH_EXYNOS || COMPILE_TEST
> diff --git a/drivers/soc/samsung/Makefile b/drivers/soc/samsung/Makefile
> index 3b6a8797416c..edd1d6ea064d 100644
> --- a/drivers/soc/samsung/Makefile
> +++ b/drivers/soc/samsung/Makefile
> @@ -1,5 +1,8 @@
>  # SPDX-License-Identifier: GPL-2.0
> 
> +obj-$(CONFIG_EXYNOS_ASV)	+= exynos-asv.o
> +obj-$(CONFIG_EXYNOS_ASV_ARM)	+= exynos5422-asv.o
> +
>  obj-$(CONFIG_EXYNOS_CHIPID)	+= exynos-chipid.o
>  obj-$(CONFIG_EXYNOS_PMU)	+= exynos-pmu.o
> 
> diff --git a/drivers/soc/samsung/exynos-asv.c b/drivers/soc/samsung/exynos-asv.c
> new file mode 100644
> index 000000000000..c6f2e4f0dcc5
> --- /dev/null
> +++ b/drivers/soc/samsung/exynos-asv.c
> @@ -0,0 +1,179 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2019 Samsung Electronics Co., Ltd.
> + *	      http://www.samsung.com/
> + * Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
> + *
> + * Samsung Exynos SoC Adaptive Supply Voltage support
> + */
> +
> +#include <linux/cpu.h>
> +#include <linux/delay.h>

Do you use this header?

> +#include <linux/device.h>
> +#include <linux/errno.h>
> +#include <linux/init.h>
> +#include <linux/mfd/syscon.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/of_device.h>
> +#include <linux/platform_device.h>
> +#include <linux/pm_opp.h>
> +#include <linux/regmap.h>
> +#include <linux/soc/samsung/exynos-chipid.h>
> +
> +#include "exynos-asv.h"
> +#include "exynos5422-asv.h"
> +
> +#define MHZ 1000000U
> +
> +static int exynos_asv_update_cpu_opps(struct exynos_asv *asv,
> +				      struct device *cpu)
> +{
> +	struct exynos_asv_subsys *subsys = NULL;
> +	struct dev_pm_opp *opp;
> +	unsigned int opp_freq;
> +	int i;
> +
> +	for (i = 0; i < ARRAY_SIZE(asv->subsys); i++) {
> +		if (of_device_is_compatible(cpu->of_node,
> +					    asv->subsys[i].cpu_dt_compat)) {
> +			subsys = &asv->subsys[i];
> +			break;
> +		}
> +	}
> +	if (!subsys)
> +		return -EINVAL;
> +
> +	for (i = 0; i < subsys->table.num_rows; i++) {
> +		unsigned int new_volt, volt;
> +		int ret;
> +
> +		opp_freq = exynos_asv_opp_get_frequency(subsys, i);
> +
> +		opp = dev_pm_opp_find_freq_exact(cpu, opp_freq * MHZ, true);
> +		if (IS_ERR(opp)) {
> +			dev_info(asv->dev, "cpu%d opp%d, freq: %u missing\n",
> +				 cpu->id, i, opp_freq);
> +
> +			continue;
> +		}
> +
> +		volt = dev_pm_opp_get_voltage(opp);
> +		new_volt = asv->opp_get_voltage(subsys, i, volt);
> +		dev_pm_opp_put(opp);
> +
> +		if (new_volt == volt)
> +			continue;
> +
> +		ret = dev_pm_opp_adjust_voltage(cpu, opp_freq * MHZ,
> +						new_volt, new_volt, new_volt);
> +		if (ret < 0)
> +			dev_err(asv->dev,
> +				"Failed to adjust OPP %u Hz/%u uV for cpu%d\n",
> +				opp_freq, new_volt, cpu->id);
> +		else
> +			dev_dbg(asv->dev,
> +				"Adjusted OPP %u Hz/%u -> %u uV, cpu%d\n",
> +				opp_freq, volt, new_volt, cpu->id);
> +	}
> +
> +	return 0;
> +}
> +
> +static int exynos_asv_update_opps(struct exynos_asv *asv)
> +{
> +	struct opp_table *last_opp_table = NULL;
> +	struct device *cpu;
> +	int ret, cpuid;
> +
> +	for_each_possible_cpu(cpuid) {
> +		struct opp_table *opp_table;
> +
> +		cpu = get_cpu_device(cpuid);
> +		if (!cpu)
> +			continue;
> +
> +		opp_table = dev_pm_opp_get_opp_table(cpu);
> +		if (IS_ERR(opp_table))
> +			continue;
> +
> +		if (!last_opp_table || opp_table != last_opp_table) {
> +			last_opp_table = opp_table;
> +
> +			ret = exynos_asv_update_cpu_opps(asv, cpu);
> +			if (ret < 0)
> +				dev_err(asv->dev, "Couldn't udate OPPs for cpu%d\n",
> +					cpuid);
> +		}
> +
> +		dev_pm_opp_put_opp_table(opp_table);
> +	}
> +
> +	return	0;
> +}
> +
> +static int exynos_asv_probe(struct platform_device *pdev)
> +{
> +	int (*probe_func)(struct exynos_asv *asv);
> +	struct exynos_asv *asv;
> +	struct device *cpu_dev;
> +	u32 product_id = 0;
> +	int ret, i;
> +
> +	cpu_dev = get_cpu_device(0);
> +	ret = dev_pm_opp_get_opp_count(cpu_dev);
> +	if (ret < 0)
> +		return -EPROBE_DEFER;
> +
> +	asv = devm_kzalloc(&pdev->dev, sizeof(*asv), GFP_KERNEL);
> +	if (!asv)
> +		return -ENOMEM;
> +
> +	asv->chipid_regmap = syscon_node_to_regmap(pdev->dev.of_node);

Since this binds to the same node as chipid, why do you need syscon for
it? Why regular IO access does not work? Eventually, if this has to be
regmap because of locking (does it?), then maybe simply
device_node_to_regmap()?

> +	if (IS_ERR(asv->chipid_regmap)) {
> +		dev_err(&pdev->dev, "Could not find syscon regmap\n");
> +		return PTR_ERR(asv->chipid_regmap);
> +	}
> +
> +	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id);
> +
> +	switch (product_id & EXYNOS_MASK) {
> +	case 0xE5422000:
> +		probe_func = exynos5422_asv_init;
> +		break;
> +	default:
> +		dev_err(&pdev->dev, "Unsupported product ID: %#x", product_id);

Is this going to scream for every Exynos matching the 4210-chipid?

> +		return -ENODEV;
> +	}
> +
> +	ret = of_property_read_u32(pdev->dev.of_node, "samsung,asv-bin",
> +				   &asv->of_bin);
> +	if (ret < 0)
> +		asv->of_bin = -EINVAL;
> +
> +	asv->dev = &pdev->dev;
> +	dev_set_drvdata(&pdev->dev, asv);
> +
> +	for (i = 0; i < ARRAY_SIZE(asv->subsys); i++)
> +		asv->subsys[i].asv = asv;
> +
> +	ret = probe_func(asv);
> +	if (ret < 0)
> +		return ret;
> +
> +	return exynos_asv_update_opps(asv);
> +}
> +
> +static const struct of_device_id exynos_asv_of_device_ids[] = {
> +	{ .compatible = "samsung,exynos4210-chipid" },
> +	{}
> +};
> +
> +static struct platform_driver exynos_asv_driver = {
> +	.driver = {
> +		.name = "exynos-asv",
> +		.of_match_table = exynos_asv_of_device_ids,
> +	},
> +	.probe	= exynos_asv_probe,
> +};
> +module_platform_driver(exynos_asv_driver);
> diff --git a/drivers/soc/samsung/exynos-asv.h b/drivers/soc/samsung/exynos-asv.h
> new file mode 100644
> index 000000000000..14b4fedf2ddd
> --- /dev/null
> +++ b/drivers/soc/samsung/exynos-asv.h
> @@ -0,0 +1,82 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2019 Samsung Electronics Co., Ltd.
> + *	      http://www.samsung.com/
> + * Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
> + *
> + * Samsung Exynos SoC Adaptive Supply Voltage support
> + */
> +#ifndef __LINUX_SOC_EXYNOS_ASV_H
> +#define __LINUX_SOC_EXYNOS_ASV_H
> +
> +enum {
> +	EXYNOS_ASV_SUBSYS_ID_ARM,
> +	EXYNOS_ASV_SUBSYS_ID_EGL = EXYNOS_ASV_SUBSYS_ID_ARM,
> +	EXYNOS_ASV_SUBSYS_ID_KFC,
> +	EXYNOS_ASV_SUBSYS_ID_INT,
> +	EXYNOS_ASV_SUBSYS_ID_MIF,
> +	EXYNOS_ASV_SUBSYS_ID_G3D,
> +	EXYNOS_ASV_SUBSYS_ID_CAM,
> +	EXYNOS_ASV_SUBSYS_ID_MAX
> +};

I cannot find usage of it in generic part of ASV driver. What's the
purpose? Isn't it specific to Exynos5422?

> +
> +struct regmap;
> +
> +/* HPM, IDS values to select target group */
> +struct asv_limit_entry {
> +	unsigned int hpm;
> +	unsigned int ids;
> +};
> +
> +struct exynos_asv_table {
> +	unsigned int num_rows;
> +	unsigned int num_cols;
> +	u32 *buf;
> +};
> +
> +struct exynos_asv_subsys {
> +	struct exynos_asv *asv;
> +	const char *cpu_dt_compat;
> +	int id;
> +	struct exynos_asv_table table;
> +
> +	unsigned int base_volt;
> +	unsigned int offset_volt_h;
> +	unsigned int offset_volt_l;
> +};
> +
> +struct exynos_asv {
> +	struct device *dev;
> +	struct regmap *chipid_regmap;
> +	struct exynos_asv_subsys subsys[2];
> +
> +	int (*opp_get_voltage)(struct exynos_asv_subsys *subs, int level,
> +			       unsigned int voltage);
> +	unsigned int group;
> +	unsigned int table;
> +
> +	/* True if SG fields from PKG_ID register should be used */
> +	bool use_sg;
> +	/* ASV bin read from DT */
> +	int of_bin;
> +};
> +
> +static inline u32 __asv_get_table_entry(struct exynos_asv_table *table,

'table' looks here like pointer to const.

> +					unsigned int row, unsigned int col)
> +{
> +	return table->buf[row * (table->num_cols) + col];
> +}
> +
> +static inline u32 exynos_asv_opp_get_voltage(struct exynos_asv_subsys *subsys,
> +					unsigned int level, unsigned int group)
> +{

The same, for subsys.

> +	return __asv_get_table_entry(&subsys->table, level, group + 1);
> +}
> +
> +static inline u32 exynos_asv_opp_get_frequency(struct exynos_asv_subsys *subsys,
> +					unsigned int level)
> +{

The same.

> +	return __asv_get_table_entry(&subsys->table, level, 0);
> +}
> +
> +#endif /* __LINUX_SOC_EXYNOS_ASV_H */
> diff --git a/drivers/soc/samsung/exynos5422-asv.c b/drivers/soc/samsung/exynos5422-asv.c
> new file mode 100644
> index 000000000000..7982f2ca0f11
> --- /dev/null
> +++ b/drivers/soc/samsung/exynos5422-asv.c
> @@ -0,0 +1,509 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2019 Samsung Electronics Co., Ltd.
> + *	      http://www.samsung.com/
> + *
> + * Samsung Exynos 5422 SoC Adaptive Supply Voltage support
> + */
> +
> +#include <linux/bitrev.h>
> +#include <linux/device.h>

Is it used?

> +#include <linux/errno.h>
> +#include <linux/of.h>

The same?

> +#include <linux/regmap.h>
> +#include <linux/soc/samsung/exynos-chipid.h>
> +#include <linux/slab.h>
> +
> +#include "exynos-asv.h"
> +
> +#define ASV_GROUPS_NUM		14
> +#define ASV_ARM_DVFS_NUM	20
> +#define ASV_ARM_BIN2_DVFS_NUM	17
> +#define ASV_KFC_DVFS_NUM	14
> +#define ASV_KFC_BIN2_DVFS_NUM	12
> +
> +/*
> + * This array is a set of 4 ASV data tables, first column of each ASV table
> + * contains frequency value in MHz and subsequent columns contain the CPU
> + * cluster's supply voltage values in uV.
> + * In order to create a set of OPPs for specific SoC revision one of the voltage
> + * columns (1...14) from one of the tables (0...3) is selected during
> + * initialization. There are separate ASV tables for the big (ARM) and little
> + * (KFC) CPU cluster. Only OPPs which are already defined in devicetree
> + * will be updated.
> + */
> +
> +static const u32 asv_arm_table[][ASV_ARM_DVFS_NUM][ASV_GROUPS_NUM + 1] = {
> +{
> +	/* ARM 0, 1 */
> +	{ 2100,    1362500, 1362500, 1350000, 1337500, 1325000, 1312500, 1300000,
> +	  1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000 },
> +	{ 2000,    1312500, 1312500, 1300000, 1287500, 1275000, 1262500, 1250000,
> +	  1237500, 1225000, 1237500, 1225000, 1212500, 1200000, 1187500 },
> +	{ 1900,    1250000, 1237500, 1225000, 1212500, 1200000, 1187500, 1175000,
> +	  1162500, 1150000, 1162500, 1150000, 1137500, 1125000, 1112500 },
> +	{ 1800,    1200000, 1187500, 1175000, 1162500, 1150000, 1137500, 1125000,
> +	  1112500, 1100000, 1112500, 1100000, 1087500, 1075000, 1062500 },
> +	{ 1700,    1162500, 1150000, 1137500, 1125000, 1112500, 1100000, 1087500,
> +	  1075000, 1062500, 1075000, 1062500, 1050000, 1037500, 1025000 },
> +	{ 1600,    1125000, 1112500, 1100000, 1087500, 1075000, 1062500, 1050000,
> +	  1037500, 1025000, 1037500, 1025000, 1012500, 1000000, 987500 },
> +	{ 1500,    1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500,
> +	  1000000, 987500,  1000000, 987500,  975000,  962500,  950000 },
> +	{ 1400,    1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500,
> +	  975000,  962500,  975000,  962500,  950000,  937500,  925000 },
> +	{ 1300,    1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000,
> +	  962500,  950000,  962500,  950000,  937500,  925000,  912500 },
> +	{ 1200,    1025000, 1012500, 1000000, 987500,  975000,  962500,  950000,
> +	  937500,  925000,  937500,  925000,  912500,  900000,  900000 },
> +	{ 1100,    1000000, 987500,  975000,  962500,  950000,  937500,  925000,
> +	  912500,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 1000,    975000,  962500,  950000,  937500,  925000,  912500,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 900,     950000,  937500,  925000,  912500,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 800,     925000,  912500,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 700,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 600,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 500,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 400,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +}, {
> +	/* ARM 2 */
> +	{ 2100,    1362500, 1362500, 1350000, 1337500, 1325000, 1312500, 1300000,
> +	  1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000 },
> +	{ 2000,    1312500, 1312500, 1312500, 1300000, 1275000, 1262500, 1250000,
> +	  1237500, 1225000, 1237500, 1225000, 1212500, 1200000, 1187500 },
> +	{ 1900,    1262500, 1250000, 1250000, 1237500, 1212500, 1200000, 1187500,
> +	  1175000, 1162500, 1175000, 1162500, 1150000, 1137500, 1125000 },
> +	{ 1800,    1212500, 1200000, 1187500, 1175000, 1162500, 1150000, 1137500,
> +	  1125000, 1112500, 1125000, 1112500, 1100000, 1087500, 1075000 },
> +	{ 1700,    1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000,
> +	  1087500, 1075000, 1087500, 1075000, 1062500, 1050000, 1037500 },
> +	{ 1600,    1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500,
> +	  1050000, 1037500, 1050000, 1037500, 1025000, 1012500, 1000000 },
> +	{ 1500,    1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000,
> +	  1012500, 1000000, 1012500, 1000000, 987500,  975000,  962500 },
> +	{ 1400,    1075000, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000,
> +	  987500,  975000,  987500,  975000,  962500,  950000,  937500 },
> +	{ 1300,    1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000,
> +	  962500,  950000,  962500,  950000,  937500,  925000,  912500 },
> +	{ 1200,    1025000, 1012500, 1000000, 987500,  975000,  962500,  950000,
> +	  937500,  925000,  937500,  925000,  912500,  900000,  900000 },
> +	{ 1100,    1000000, 987500,  975000,  962500,  950000,  937500,  925000,
> +	  912500,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 1000,    975000,  962500,  950000,  937500,  925000,  912500,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 900,     950000,  937500,  925000,  912500,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 800,     925000,  912500,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 700,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 600,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 500,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 400,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +}, {
> +	/* ARM 3 */
> +	{ 2100,    1362500, 1362500, 1350000, 1337500, 1325000, 1312500, 1300000,
> +	  1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000 },
> +	{ 2000,    1312500, 1312500, 1300000, 1287500, 1275000, 1262500, 1250000,
> +	  1237500, 1225000, 1237500, 1225000, 1212500, 1200000, 1187500 },
> +	{ 1900,    1262500, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500,
> +	  1175000, 1162500, 1175000, 1162500, 1150000, 1137500, 1125000 },
> +	{ 1800,    1212500, 1200000, 1187500, 1175000, 1162500, 1150000, 1137500,
> +	  1125000, 1112500, 1125000, 1112500, 1100000, 1087500, 1075000 },
> +	{ 1700,    1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000,
> +	  1087500, 1075000, 1087500, 1075000, 1062500, 1050000, 1037500 },
> +	{ 1600,    1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500,
> +	  1050000, 1037500, 1050000, 1037500, 1025000, 1012500, 1000000 },
> +	{ 1500,    1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000,
> +	  1012500, 1000000, 1012500, 1000000, 987500,  975000,  962500 },
> +	{ 1400,    1075000, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000,
> +	  987500,  975000,  987500,  975000,  962500,  950000,  937500 },
> +	{ 1300,    1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000,
> +	  962500,  950000,  962500,  950000,  937500,  925000,  912500 },
> +	{ 1200,    1025000, 1012500, 1000000, 987500,  975000,  962500,  950000,
> +	  937500,  925000,  937500,  925000,  912500,  900000,  900000 },
> +	{ 1100,    1000000, 987500,  975000,  962500,  950000,  937500,  925000,
> +	  912500,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 1000,    975000,  962500,  950000,  937500,  925000,  912500,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 900,     950000,  937500,  925000,  912500,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 800,     925000,  912500,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 700,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 600,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 500,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 400,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +}, {
> +	/* ARM bin 2 */
> +	{ 1800,    1237500, 1225000, 1212500, 1200000, 1187500, 1175000, 1162500,
> +	  1150000, 1137500, 1150000, 1137500, 1125000, 1112500, 1100000 },
> +	{ 1700,    1200000, 1187500, 1175000, 1162500, 1150000, 1137500, 1125000,
> +	  1112500, 1100000, 1112500, 1100000, 1087500, 1075000, 1062500 },
> +	{ 1600,    1162500, 1150000, 1137500, 1125000, 1112500, 1100000, 1087500,
> +	  1075000, 1062500, 1075000, 1062500, 1050000, 1037500, 1025000 },
> +	{ 1500,    1125000, 1112500, 1100000, 1087500, 1075000, 1062500, 1050000,
> +	  1037500, 1025000, 1037500, 1025000, 1012500, 1000000, 987500 },
> +	{ 1400,    1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000,
> +	  1012500, 1000000, 1012500, 1000000, 987500,  975000,  962500 },
> +	{ 1300,    1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500,
> +	  1000000, 987500,  1000000, 987500,  975000,  962500,  950000 },
> +	{ 1200,    1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500,
> +	  975000,  962500,  975000,  962500,  950000,  937500,  925000 },
> +	{ 1100,    1037500, 1025000, 1012500, 1000000, 987500,  975000,  962500,
> +	  950000,  937500,  950000,  937500,  925000,  912500,  900000 },
> +	{ 1000,    1012500, 1000000, 987500,  975000,  962500,  950000,  937500,
> +	  925000,  912500,  925000,  912500,  900000,  900000,  900000 },
> +	{ 900,     987500,  975000,  962500,  950000,  937500,  925000,  912500,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 800,     962500,  950000,  937500,  925000,  912500,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 700,     937500,  925000,  912500,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 600,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 500,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 400,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +}
> +};
> +
> +static const u32 asv_kfc_table[][ASV_KFC_DVFS_NUM][ASV_GROUPS_NUM + 1] = {
> +{
> +	/* KFC 0, 1 */
> +	{ 1500000, 1300000, 1300000, 1300000, 1287500, 1287500, 1287500, 1275000,
> +	  1262500, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500 },
> +	{ 1400000, 1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000,
> +	  1187500, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500 },
> +	{ 1300000, 1225000, 1212500, 1200000, 1187500, 1175000, 1162500, 1150000,
> +	  1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500 },
> +	{ 1200000, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000,
> +	  1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500 },
> +	{ 1100000, 1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500,
> +	  1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000 },
> +	{ 1000000, 1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000,
> +	  1012500, 1000000, 987500,  975000,  962500,  950000,  937500 },
> +	{ 900000,  1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500,
> +	  975000,  962500,  950000,  937500,  925000,  912500,  900000 },
> +	{ 800000,  1025000, 1012500, 1000000, 987500,  975000,  962500,  950000,
> +	  937500,  925000,  912500,  900000,  900000,  900000,  900000 },
> +	{ 700000,  987500,  975000,  962500,  950000,  937500,  925000,  912500,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 600000,  950000,  937500,  925000,  912500,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 500000,  912500,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 400000,  900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 300000,  900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 200000,  900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +}, {
> +	/* KFC 2 */
> +	{ 1500,    1300000, 1300000, 1300000, 1287500, 1287500, 1287500, 1275000,
> +	  1262500, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500 },
> +	{ 1400,    1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000,
> +	  1187500, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500 },
> +	{ 1300,    1225000, 1212500, 1200000, 1187500, 1175000, 1162500, 1150000,
> +	  1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500 },
> +	{ 1200,    1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000,
> +	  1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500 },
> +	{ 1100,    1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500,
> +	  1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000 },
> +	{ 1000,    1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000,
> +	  1012500, 1000000, 987500,  975000,  962500,  950000,  937500 },
> +	{ 900,     1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500,
> +	  975000,  962500,  950000,  937500,  925000,  912500,  900000 },
> +	{ 800,     1025000, 1012500, 1000000, 987500,  975000,  962500,  950000,
> +	  937500,  925000,  912500,  900000,  900000,  900000,  900000 },
> +	{ 700,     987500,  975000,  962500,  950000,  937500,  925000,  912500,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 600,     950000,  937500,  925000,  912500,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 500,     912500,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 400,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +}, {
> +	/* KFC 3 */
> +	{ 1500,    1300000, 1300000, 1300000, 1287500, 1287500, 1287500, 1275000,
> +	  1262500, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500 },
> +	{ 1400,    1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000,
> +	  1187500, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500 },
> +	{ 1300,    1225000, 1212500, 1200000, 1187500, 1175000, 1162500, 1150000,
> +	  1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500 },
> +	{ 1200,    1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000,
> +	  1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500 },
> +	{ 1100,    1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500,
> +	  1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000 },
> +	{ 1000,    1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000,
> +	  1012500, 1000000, 987500,  975000,  962500,  950000,  937500 },
> +	{ 900,     1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500,
> +	  975000,  962500,  950000,  937500,  925000,  912500,  900000 },
> +	{ 800,     1025000, 1012500, 1000000, 987500,  975000,  962500,  950000,
> +	  937500,  925000,  912500,  900000,  900000,  900000,  900000 },
> +	{ 700,     987500,  975000,  962500,  950000,  937500,  925000,  912500,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 600,     950000,  937500,  925000,  912500,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 500,     912500,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 400,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +}, {
> +	/* KFC bin 2 */
> +	{ 1300,    1250000, 1237500, 1225000, 1212500, 1200000, 1187500, 1175000,
> +	  1162500, 1150000, 1137500, 1125000, 1112500, 1100000, 1087500 },
> +	{ 1200,    1200000, 1187500, 1175000, 1162500, 1150000, 1137500, 1125000,
> +	  1112500, 1100000, 1087500, 1075000, 1062500, 1050000, 1037500 },
> +	{ 1100,    1162500, 1150000, 1137500, 1125000, 1112500, 1100000, 1087500,
> +	  1075000, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000 },
> +	{ 1000,    1125000, 1112500, 1100000, 1087500, 1075000, 1062500, 1050000,
> +	  1037500, 1025000, 1012500, 1000000, 987500,  975000,  962500 },
> +	{ 900,     1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500,
> +	  1000000, 987500,  975000,  962500,  950000,  937500,  925000 },
> +	{ 800,     1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000,
> +	  962500,  950000,  937500,  925000,  912500,  900000,  900000 },
> +	{ 700,     1012500, 1000000, 987500,  975000,  962500,  950000,  937500,
> +	  925000,  912500,  900000,  900000,  900000,  900000,  900000 },
> +	{ 600,     975000,  962500,  950000,  937500,  925000,  912500,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 500,     937500,  925000,  912500,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 400,     925000,  912500,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
> +	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
> +}
> +};
> +
> +static const struct asv_limit_entry __asv_limits[ASV_GROUPS_NUM] = {
> +	{ 13, 55 },
> +	{ 21, 65 },
> +	{ 25, 69 },
> +	{ 30, 72 },
> +	{ 36, 74 },
> +	{ 43, 76 },
> +	{ 51, 78 },
> +	{ 65, 80 },
> +	{ 81, 82 },
> +	{ 98, 84 },
> +	{ 119, 87 },
> +	{ 135, 89 },
> +	{ 150, 92 },
> +	{ 999, 999 },
> +};
> +
> +static int exynos5422_asv_get_group(struct exynos_asv *asv)
> +{
> +	unsigned int pkgid_reg, auxi_reg;
> +	int hpm, ids, i;
> +
> +	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PKG_ID, &pkgid_reg);
> +	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_AUX_INFO, &auxi_reg);
> +
> +	if (asv->use_sg) {
> +		u32 sga = (pkgid_reg >> EXYNOS5422_SG_A_OFFSET) &
> +			   EXYNOS5422_SG_A_MASK;
> +
> +		u32 sgb = (pkgid_reg >> EXYNOS5422_SG_B_OFFSET) &
> +			   EXYNOS5422_SG_B_MASK;
> +
> +		if ((pkgid_reg >> EXYNOS5422_SG_BSIGN_OFFSET) &
> +		     EXYNOS5422_SG_BSIGN_MASK)
> +			return sga + sgb;
> +		else
> +			return sga - sgb;
> +	}
> +
> +	hpm = (auxi_reg >> EXYNOS5422_TMCB_OFFSET) & EXYNOS5422_TMCB_MASK;
> +	ids = (pkgid_reg >> EXYNOS5422_IDS_OFFSET) & EXYNOS5422_IDS_MASK;
> +
> +	for (i = 0; i < ASV_GROUPS_NUM; i++) {
> +		if (ids <= __asv_limits[i].ids)
> +			break;
> +		if (hpm <= __asv_limits[i].hpm)
> +			break;
> +	}
> +	if (i < ASV_GROUPS_NUM)
> +		return i;
> +
> +	return 0;
> +}
> +
> +static int __asv_offset_voltage(unsigned int index)
> +{
> +	switch (index) {
> +	case 1:
> +		return 12500;
> +	case 2:
> +		return 50000;
> +	case 3:
> +		return 25000;
> +	default:
> +		return 0;
> +	};
> +}
> +
> +static void exynos5422_asv_offset_voltage_setup(struct exynos_asv *asv)
> +{
> +	struct exynos_asv_subsys *subsys;
> +	unsigned int reg, value;
> +
> +	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_AUX_INFO, &reg);
> +
> +	/* ARM offset voltage setup */
> +	subsys = &asv->subsys[EXYNOS_ASV_SUBSYS_ID_ARM];
> +
> +	subsys->base_volt = 1000000;
> +
> +	value = (reg >> EXYNOS5422_ARM_UP_OFFSET) & EXYNOS5422_ARM_UP_MASK;
> +	subsys->offset_volt_h = __asv_offset_voltage(value);
> +
> +	value = (reg >> EXYNOS5422_ARM_DN_OFFSET) & EXYNOS5422_ARM_DN_MASK;
> +	subsys->offset_volt_l = __asv_offset_voltage(value);
> +
> +	/* KFC offset voltage setup */
> +	subsys = &asv->subsys[EXYNOS_ASV_SUBSYS_ID_KFC];
> +
> +	subsys->base_volt = 1000000;
> +
> +	value = (reg >> EXYNOS5422_KFC_UP_OFFSET) & EXYNOS5422_KFC_UP_MASK;
> +	subsys->offset_volt_h = __asv_offset_voltage(value);
> +
> +	value = (reg >> EXYNOS5422_KFC_DN_OFFSET) & EXYNOS5422_KFC_DN_MASK;
> +	subsys->offset_volt_l = __asv_offset_voltage(value);
> +}
> +
> +static int exynos5422_asv_opp_get_voltage(struct exynos_asv_subsys *subsys,
> +				int level, unsigned int volt)

subsys is not modified.

> +{
> +	unsigned int asv_volt;
> +
> +	if (level >= subsys->table.num_rows)
> +		return volt;
> +
> +	asv_volt = exynos_asv_opp_get_voltage(subsys, level,
> +					      subsys->asv->group);
> +
> +	if (volt > subsys->base_volt)
> +		asv_volt += subsys->offset_volt_h;
> +	else
> +		asv_volt += subsys->offset_volt_l;
> +
> +	return asv_volt;
> +}
> +
> +static unsigned int exynos5422_asv_parse_table(struct exynos_asv *asv,
> +				      unsigned int pkg_id)
> +{

The same, for asv. Looks BTW unused...

> +	return (pkg_id >> EXYNOS5422_TABLE_OFFSET) & EXYNOS5422_TABLE_MASK;
> +}
> +
> +static bool exynos5422_asv_parse_bin2(struct exynos_asv *asv,
> +				     unsigned int pkg_id)
> +{

The same.

> +	return (pkg_id >> EXYNOS5422_BIN2_OFFSET) & EXYNOS5422_BIN2_MASK;
> +}
> +
> +static bool exynos5422_asv_parse_sg(struct exynos_asv *asv,
> +					unsigned int pkg_id)
> +{

The same.

> +	return (pkg_id >> EXYNOS5422_USESG_OFFSET) & EXYNOS5422_USESG_MASK;
> +}
> +
> +int exynos5422_asv_init(struct exynos_asv *asv)
> +{
> +	struct exynos_asv_subsys *subsys;
> +	unsigned int table_index;
> +	unsigned int pkg_id;
> +	bool bin2;
> +

How about checking if asv != null? It's a header exposed function.

Best regards,
Krzysztof


> +	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PKG_ID, &pkg_id);
> +
> +	if (asv->of_bin == 2) {
> +		bin2 = true;
> +		asv->use_sg = false;
> +	} else {
> +		asv->use_sg = exynos5422_asv_parse_sg(asv, pkg_id);
> +		bin2 = exynos5422_asv_parse_bin2(asv, pkg_id);
> +	}
> +
> +	asv->group = exynos5422_asv_get_group(asv);
> +	asv->table = exynos5422_asv_parse_table(asv, pkg_id);
> +
> +	exynos5422_asv_offset_voltage_setup(asv);
> +
> +	if (bin2) {
> +		table_index = 3;
> +	} else {
> +		if (asv->table == 2 || asv->table == 3)
> +			table_index = asv->table - 1;
> +		else
> +			table_index = 0;
> +	}
> +
> +	subsys = &asv->subsys[EXYNOS_ASV_SUBSYS_ID_ARM];
> +	subsys->cpu_dt_compat = "arm,cortex-a15";
> +	if (bin2)
> +		subsys->table.num_rows = ASV_ARM_BIN2_DVFS_NUM;
> +	else
> +		subsys->table.num_rows = ASV_ARM_DVFS_NUM;
> +	subsys->table.num_cols = ASV_GROUPS_NUM + 1;
> +	subsys->table.buf = (u32 *)asv_arm_table[table_index];
> +
> +	subsys = &asv->subsys[EXYNOS_ASV_SUBSYS_ID_KFC];
> +	subsys->cpu_dt_compat = "arm,cortex-a7";
> +	if (bin2)
> +		subsys->table.num_rows = ASV_KFC_BIN2_DVFS_NUM;
> +	else
> +		subsys->table.num_rows = ASV_KFC_DVFS_NUM;
> +	subsys->table.num_cols = ASV_GROUPS_NUM + 1;
> +	subsys->table.buf = (u32 *)asv_kfc_table[table_index];
> +
> +	asv->opp_get_voltage = exynos5422_asv_opp_get_voltage;
> +
> +	return 0;
> +}
> diff --git a/drivers/soc/samsung/exynos5422-asv.h b/drivers/soc/samsung/exynos5422-asv.h
> new file mode 100644
> index 000000000000..85218d2800fb
> --- /dev/null
> +++ b/drivers/soc/samsung/exynos5422-asv.h
> @@ -0,0 +1,25 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2019 Samsung Electronics Co., Ltd.
> + *	      http://www.samsung.com/
> + *
> + * Samsung Exynos 5422 SoC Adaptive Supply Voltage support
> + */
> +
> +#ifndef __LINUX_SOC_EXYNOS5422_ASV_H
> +#define __LINUX_SOC_EXYNOS5422_ASV_H
> +
> +#include <linux/errno.h>
> +
> +struct exynos_asv;
> +
> +#ifdef CONFIG_EXYNOS_ASV_ARM
> +int exynos5422_asv_init(struct exynos_asv *asv);
> +#else
> +static inline int exynos5422_asv_init(struct exynos_asv *asv)
> +{
> +	return -ENOTSUPP;
> +}
> +#endif
> +
> +#endif /* __LINUX_SOC_EXYNOS5422_ASV_H */
> --
> 2.17.1
>
Sylwester Nawrocki/Kernel \(PLT\) /SRPOL/Staff Engineer/Samsung Electronics Oct. 23, 2019, 10:48 a.m. UTC | #2 
Hi Krzysztof,

On 10/22/19 21:04, Krzysztof Kozlowski wrote:
 
> I wanted to apply this patch but spotted some unusual printk... 
> and then started looking for more...
> 
> Sparse complains:
> ../drivers/soc/samsung/exynos5422-asv.c:457:5: warning: symbol 
> 'exynos5422_asv_init' was not declared. Should it be static?
 
#include "exynos5422-asv.h" should be added to 
drivers/soc/samsung/exynos5422-asv.c.

>>  drivers/soc/samsung/Kconfig          |  10 +
>>  drivers/soc/samsung/Makefile         |   3 +
>>  drivers/soc/samsung/exynos-asv.c     | 179 ++++++++++
>>  drivers/soc/samsung/exynos-asv.h     |  82 +++++
>>  drivers/soc/samsung/exynos5422-asv.c | 509 +++++++++++++++++++++++++++
>>  drivers/soc/samsung/exynos5422-asv.h |  25 ++
>>  6 files changed, 808 insertions(+)
>>  create mode 100644 drivers/soc/samsung/exynos-asv.c
>>  create mode 100644 drivers/soc/samsung/exynos-asv.h
>>  create mode 100644 drivers/soc/samsung/exynos5422-asv.c
>>  create mode 100644 drivers/soc/samsung/exynos5422-asv.h
>>

>> +++ b/drivers/soc/samsung/exynos-asv.c

>> +#include <linux/cpu.h>
>> +#include <linux/delay.h>
> 
> Do you use this header?

It can be removed now, after conversion to dev_pm_opp_adjust_voltage().

>> +static int exynos_asv_probe(struct platform_device *pdev)
>> +{
>> +	int (*probe_func)(struct exynos_asv *asv);
>> +	struct exynos_asv *asv;
>> +	struct device *cpu_dev;
>> +	u32 product_id = 0;
>> +	int ret, i;
>> +
>> +	cpu_dev = get_cpu_device(0);
>> +	ret = dev_pm_opp_get_opp_count(cpu_dev);
>> +	if (ret < 0)
>> +		return -EPROBE_DEFER;
>> +
>> +	asv = devm_kzalloc(&pdev->dev, sizeof(*asv), GFP_KERNEL);
>> +	if (!asv)
>> +		return -ENOMEM;
>> +
>> +	asv->chipid_regmap = syscon_node_to_regmap(pdev->dev.of_node);
> 
> Since this binds to the same node as chipid, why do you need syscon for
> it? Why regular IO access does not work? Eventually, if this has to be
> regmap because of locking (does it?), then maybe simply
> device_node_to_regmap()?

We just need regmap available to any of the two drivers whichever needs it
first. device_node_to_regmap() sounds like a good idea. Then we could drop
"syscon" compatible from the binding.

>> +	if (IS_ERR(asv->chipid_regmap)) {
>> +		dev_err(&pdev->dev, "Could not find syscon regmap\n");
>> +		return PTR_ERR(asv->chipid_regmap);
>> +	}
>> +
>> +	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id);
>> +
>> +	switch (product_id & EXYNOS_MASK) {
>> +	case 0xE5422000:
>> +		probe_func = exynos5422_asv_init;
>> +		break;
>> +	default:
>> +		dev_err(&pdev->dev, "Unsupported product ID: %#x", product_id);
> 
> Is this going to scream for every Exynos matching the 4210-chipid?

Yes, it should really be dev_info() or removed entirely.

>> +		return -ENODEV;
>> +	}


>> +++ b/drivers/soc/samsung/exynos-asv.h

>> +enum {
>> +	EXYNOS_ASV_SUBSYS_ID_ARM,
>> +	EXYNOS_ASV_SUBSYS_ID_EGL = EXYNOS_ASV_SUBSYS_ID_ARM,
>> +	EXYNOS_ASV_SUBSYS_ID_KFC,
>> +	EXYNOS_ASV_SUBSYS_ID_INT,
>> +	EXYNOS_ASV_SUBSYS_ID_MIF,
>> +	EXYNOS_ASV_SUBSYS_ID_G3D,
>> +	EXYNOS_ASV_SUBSYS_ID_CAM,
>> +	EXYNOS_ASV_SUBSYS_ID_MAX
>> +};
> 
> I cannot find usage of it in generic part of ASV driver. What's the
> purpose? Isn't it specific to Exynos5422?

It was meant as generic enumeration of available subsystems, it's not
Exynos5422 specific. It could be moved to the exynos5422 part of the 
driver (limited to EXYNOS_ASV_SUBSYS_ID_ARM, EXYNOS_ASV_SUBSYS_ID_KFC)
until support for of ther subsystems than CPU clusters is added.
The CPUs are now matched by compatible.

>> +struct regmap;
>> +
>> +/* HPM, IDS values to select target group */

>> +struct exynos_asv_subsys {
>> +	struct exynos_asv *asv;
>> +	const char *cpu_dt_compat;
>> +	int id;
>> +	struct exynos_asv_table table;
>> +
>> +	unsigned int base_volt;
>> +	unsigned int offset_volt_h;
>> +	unsigned int offset_volt_l;
>> +};
>> +
>> +struct exynos_asv {
>> +	struct device *dev;
>> +	struct regmap *chipid_regmap;
>> +	struct exynos_asv_subsys subsys[2];
>> +
>> +	int (*opp_get_voltage)(struct exynos_asv_subsys *subs, int level,
>> +			       unsigned int voltage);
>> +	unsigned int group;
>> +	unsigned int table;
>> +
>> +	/* True if SG fields from PKG_ID register should be used */
>> +	bool use_sg;
>> +	/* ASV bin read from DT */
>> +	int of_bin;
>> +};
>> +
>> +static inline u32 __asv_get_table_entry(struct exynos_asv_table *table,
> 
> 'table' looks here like pointer to const.

Yes, const could be added here.

>> +					unsigned int row, unsigned int col)
>> +{
>> +	return table->buf[row * (table->num_cols) + col];
>> +}
>> +
>> +static inline u32 exynos_asv_opp_get_voltage(struct exynos_asv_subsys *subsys,
>> +					unsigned int level, unsigned int group)
>> +{
> 
> The same, for subsys.

Agreed.
 
>> +	return __asv_get_table_entry(&subsys->table, level, group + 1);
>> +}

>> +++ b/drivers/soc/samsung/exynos5422-asv.c

>> +#include <linux/bitrev.h>
>> +#include <linux/device.h>
> 
> Is it used?
> 
>> +#include <linux/errno.h>
>> +#include <linux/of.h>
> 
> The same?

Some might be not used now, I will check it again.

>> +#include <linux/regmap.h>
>> +#include <linux/soc/samsung/exynos-chipid.h>
>> +#include <linux/slab.h>
>> +
>> +#include "exynos-asv.h"


>> +static int exynos5422_asv_opp_get_voltage(struct exynos_asv_subsys *subsys,
>> +				int level, unsigned int volt)
> 
> subsys is not modified.
 

>> +static unsigned int exynos5422_asv_parse_table(struct exynos_asv *asv,
>> +				      unsigned int pkg_id)
>> +{
> 
> The same, for asv. Looks BTW unused...

Indeed the asv argument should be dropped now.

>> +	return (pkg_id >> EXYNOS5422_TABLE_OFFSET) & EXYNOS5422_TABLE_MASK;
>> +}

>> +int exynos5422_asv_init(struct exynos_asv *asv)
>> +{
>> +	struct exynos_asv_subsys *subsys;
>> +	unsigned int table_index;
>> +	unsigned int pkg_id;
>> +	bool bin2;
>> +
> 
> How about checking if asv != null? It's a header exposed function.

Do we really need it? The caller will ensure that asv is not null.

>> +	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PKG_ID, &pkg_id);
Krzysztof Kozlowski Oct. 23, 2019, 11:20 a.m. UTC | #3 
On Wed, Oct 23, 2019 at 12:48:34PM +0200, Sylwester Nawrocki wrote:
> Hi Krzysztof,
> 
> On 10/22/19 21:04, Krzysztof Kozlowski wrote:
>  
> > I wanted to apply this patch but spotted some unusual printk... 
> > and then started looking for more...
> > 
> > Sparse complains:
> > ../drivers/soc/samsung/exynos5422-asv.c:457:5: warning: symbol 
> > 'exynos5422_asv_init' was not declared. Should it be static?
>  
> #include "exynos5422-asv.h" should be added to 
> drivers/soc/samsung/exynos5422-asv.c.
> 
> >>  drivers/soc/samsung/Kconfig          |  10 +
> >>  drivers/soc/samsung/Makefile         |   3 +
> >>  drivers/soc/samsung/exynos-asv.c     | 179 ++++++++++
> >>  drivers/soc/samsung/exynos-asv.h     |  82 +++++
> >>  drivers/soc/samsung/exynos5422-asv.c | 509 +++++++++++++++++++++++++++
> >>  drivers/soc/samsung/exynos5422-asv.h |  25 ++
> >>  6 files changed, 808 insertions(+)
> >>  create mode 100644 drivers/soc/samsung/exynos-asv.c
> >>  create mode 100644 drivers/soc/samsung/exynos-asv.h
> >>  create mode 100644 drivers/soc/samsung/exynos5422-asv.c
> >>  create mode 100644 drivers/soc/samsung/exynos5422-asv.h
> >>
> 
> >> +++ b/drivers/soc/samsung/exynos-asv.c
> 
> >> +#include <linux/cpu.h>
> >> +#include <linux/delay.h>
> > 
> > Do you use this header?
> 
> It can be removed now, after conversion to dev_pm_opp_adjust_voltage().
> 
> >> +static int exynos_asv_probe(struct platform_device *pdev)
> >> +{
> >> +	int (*probe_func)(struct exynos_asv *asv);
> >> +	struct exynos_asv *asv;
> >> +	struct device *cpu_dev;
> >> +	u32 product_id = 0;
> >> +	int ret, i;
> >> +
> >> +	cpu_dev = get_cpu_device(0);
> >> +	ret = dev_pm_opp_get_opp_count(cpu_dev);
> >> +	if (ret < 0)
> >> +		return -EPROBE_DEFER;
> >> +
> >> +	asv = devm_kzalloc(&pdev->dev, sizeof(*asv), GFP_KERNEL);
> >> +	if (!asv)
> >> +		return -ENOMEM;
> >> +
> >> +	asv->chipid_regmap = syscon_node_to_regmap(pdev->dev.of_node);
> > 
> > Since this binds to the same node as chipid, why do you need syscon for
> > it? Why regular IO access does not work? Eventually, if this has to be
> > regmap because of locking (does it?), then maybe simply
> > device_node_to_regmap()?
> 
> We just need regmap available to any of the two drivers whichever needs it
> first. device_node_to_regmap() sounds like a good idea. Then we could drop
> "syscon" compatible from the binding.

OK, let's keep the regmap for safe access to the same region by multiple
drivers.

> 
> >> +	if (IS_ERR(asv->chipid_regmap)) {
> >> +		dev_err(&pdev->dev, "Could not find syscon regmap\n");
> >> +		return PTR_ERR(asv->chipid_regmap);
> >> +	}
> >> +
> >> +	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id);
> >> +
> >> +	switch (product_id & EXYNOS_MASK) {
> >> +	case 0xE5422000:
> >> +		probe_func = exynos5422_asv_init;
> >> +		break;
> >> +	default:
> >> +		dev_err(&pdev->dev, "Unsupported product ID: %#x", product_id);
> > 
> > Is this going to scream for every Exynos matching the 4210-chipid?
> 
> Yes, it should really be dev_info() or removed entirely.

Remove it entirely please or leave it to dev_dbg (but even then add some
calming message like "Unsupported ...., skipping ASV"). Driver binds on
many devices and lack of ASV is kind of regular (till now there was no
ASV at all).

> 
> >> +		return -ENODEV;
> >> +	}
> 
> 
> >> +++ b/drivers/soc/samsung/exynos-asv.h
> 
> >> +enum {
> >> +	EXYNOS_ASV_SUBSYS_ID_ARM,
> >> +	EXYNOS_ASV_SUBSYS_ID_EGL = EXYNOS_ASV_SUBSYS_ID_ARM,
> >> +	EXYNOS_ASV_SUBSYS_ID_KFC,
> >> +	EXYNOS_ASV_SUBSYS_ID_INT,
> >> +	EXYNOS_ASV_SUBSYS_ID_MIF,
> >> +	EXYNOS_ASV_SUBSYS_ID_G3D,
> >> +	EXYNOS_ASV_SUBSYS_ID_CAM,
> >> +	EXYNOS_ASV_SUBSYS_ID_MAX
> >> +};
> > 
> > I cannot find usage of it in generic part of ASV driver. What's the
> > purpose? Isn't it specific to Exynos5422?
> 
> It was meant as generic enumeration of available subsystems, it's not
> Exynos5422 specific. It could be moved to the exynos5422 part of the 
> driver (limited to EXYNOS_ASV_SUBSYS_ID_ARM, EXYNOS_ASV_SUBSYS_ID_KFC)
> until support for of ther subsystems than CPU clusters is added.
> The CPUs are now matched by compatible.

Then let's move it to exynos5422 part, and later make it generic if
needed.

> 
> >> +struct regmap;
> >> +
> >> +/* HPM, IDS values to select target group */
> 
> >> +struct exynos_asv_subsys {
> >> +	struct exynos_asv *asv;
> >> +	const char *cpu_dt_compat;
> >> +	int id;
> >> +	struct exynos_asv_table table;
> >> +
> >> +	unsigned int base_volt;
> >> +	unsigned int offset_volt_h;
> >> +	unsigned int offset_volt_l;
> >> +};
> >> +
> >> +struct exynos_asv {
> >> +	struct device *dev;
> >> +	struct regmap *chipid_regmap;
> >> +	struct exynos_asv_subsys subsys[2];
> >> +
> >> +	int (*opp_get_voltage)(struct exynos_asv_subsys *subs, int level,
> >> +			       unsigned int voltage);
> >> +	unsigned int group;
> >> +	unsigned int table;
> >> +
> >> +	/* True if SG fields from PKG_ID register should be used */
> >> +	bool use_sg;
> >> +	/* ASV bin read from DT */
> >> +	int of_bin;
> >> +};
> >> +
> >> +static inline u32 __asv_get_table_entry(struct exynos_asv_table *table,
> > 
> > 'table' looks here like pointer to const.
> 
> Yes, const could be added here.
> 
> >> +					unsigned int row, unsigned int col)
> >> +{
> >> +	return table->buf[row * (table->num_cols) + col];
> >> +}
> >> +
> >> +static inline u32 exynos_asv_opp_get_voltage(struct exynos_asv_subsys *subsys,
> >> +					unsigned int level, unsigned int group)
> >> +{
> > 
> > The same, for subsys.
> 
> Agreed.
>  
> >> +	return __asv_get_table_entry(&subsys->table, level, group + 1);
> >> +}
> 
> >> +++ b/drivers/soc/samsung/exynos5422-asv.c
> 
> >> +#include <linux/bitrev.h>
> >> +#include <linux/device.h>
> > 
> > Is it used?
> > 
> >> +#include <linux/errno.h>
> >> +#include <linux/of.h>
> > 
> > The same?
> 
> Some might be not used now, I will check it again.
> 
> >> +#include <linux/regmap.h>
> >> +#include <linux/soc/samsung/exynos-chipid.h>
> >> +#include <linux/slab.h>
> >> +
> >> +#include "exynos-asv.h"
> 
> 
> >> +static int exynos5422_asv_opp_get_voltage(struct exynos_asv_subsys *subsys,
> >> +				int level, unsigned int volt)
> > 
> > subsys is not modified.
>  
> 
> >> +static unsigned int exynos5422_asv_parse_table(struct exynos_asv *asv,
> >> +				      unsigned int pkg_id)
> >> +{
> > 
> > The same, for asv. Looks BTW unused...
> 
> Indeed the asv argument should be dropped now.
> 
> >> +	return (pkg_id >> EXYNOS5422_TABLE_OFFSET) & EXYNOS5422_TABLE_MASK;
> >> +}
> 
> >> +int exynos5422_asv_init(struct exynos_asv *asv)
> >> +{
> >> +	struct exynos_asv_subsys *subsys;
> >> +	unsigned int table_index;
> >> +	unsigned int pkg_id;
> >> +	bool bin2;
> >> +
> > 
> > How about checking if asv != null? It's a header exposed function.
> 
> Do we really need it? The caller will ensure that asv is not null.

Indeed, it's not needed. Skip my comment.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/soc/samsung/Kconfig b/drivers/soc/samsung/Kconfig
index 33ad0de2de3c..27fc59bbb520 100644
--- a/drivers/soc/samsung/Kconfig
+++ b/drivers/soc/samsung/Kconfig
@@ -7,6 +7,16 @@  menuconfig SOC_SAMSUNG

 if SOC_SAMSUNG

+config EXYNOS_ASV
+	bool "Exynos Adaptive Supply Voltage support" if COMPILE_TEST
+	depends on (ARCH_EXYNOS && EXYNOS_CHIPID) || COMPILE_TEST
+	select EXYNOS_ASV_ARM if ARM && ARCH_EXYNOS
+
+# There is no need to enable these drivers for ARMv8
+config EXYNOS_ASV_ARM
+	bool "Exynos ASV ARMv7-specific driver extensions" if COMPILE_TEST
+	depends on EXYNOS_ASV
+
 config EXYNOS_CHIPID
 	bool "Exynos Chipid controller driver" if COMPILE_TEST
 	depends on ARCH_EXYNOS || COMPILE_TEST
diff --git a/drivers/soc/samsung/Makefile b/drivers/soc/samsung/Makefile
index 3b6a8797416c..edd1d6ea064d 100644
--- a/drivers/soc/samsung/Makefile
+++ b/drivers/soc/samsung/Makefile
@@ -1,5 +1,8 @@ 
 # SPDX-License-Identifier: GPL-2.0

+obj-$(CONFIG_EXYNOS_ASV)	+= exynos-asv.o
+obj-$(CONFIG_EXYNOS_ASV_ARM)	+= exynos5422-asv.o
+
 obj-$(CONFIG_EXYNOS_CHIPID)	+= exynos-chipid.o
 obj-$(CONFIG_EXYNOS_PMU)	+= exynos-pmu.o

diff --git a/drivers/soc/samsung/exynos-asv.c b/drivers/soc/samsung/exynos-asv.c
new file mode 100644
index 000000000000..c6f2e4f0dcc5
--- /dev/null
+++ b/drivers/soc/samsung/exynos-asv.c
@@ -0,0 +1,179 @@ 
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2019 Samsung Electronics Co., Ltd.
+ *	      http://www.samsung.com/
+ * Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
+ *
+ * Samsung Exynos SoC Adaptive Supply Voltage support
+ */
+
+#include <linux/cpu.h>
+#include <linux/delay.h>
+#include <linux/device.h>
+#include <linux/errno.h>
+#include <linux/init.h>
+#include <linux/mfd/syscon.h>
+#include <linux/module.h>
+#include <linux/of.h>
+#include <linux/of_device.h>
+#include <linux/platform_device.h>
+#include <linux/pm_opp.h>
+#include <linux/regmap.h>
+#include <linux/soc/samsung/exynos-chipid.h>
+
+#include "exynos-asv.h"
+#include "exynos5422-asv.h"
+
+#define MHZ 1000000U
+
+static int exynos_asv_update_cpu_opps(struct exynos_asv *asv,
+				      struct device *cpu)
+{
+	struct exynos_asv_subsys *subsys = NULL;
+	struct dev_pm_opp *opp;
+	unsigned int opp_freq;
+	int i;
+
+	for (i = 0; i < ARRAY_SIZE(asv->subsys); i++) {
+		if (of_device_is_compatible(cpu->of_node,
+					    asv->subsys[i].cpu_dt_compat)) {
+			subsys = &asv->subsys[i];
+			break;
+		}
+	}
+	if (!subsys)
+		return -EINVAL;
+
+	for (i = 0; i < subsys->table.num_rows; i++) {
+		unsigned int new_volt, volt;
+		int ret;
+
+		opp_freq = exynos_asv_opp_get_frequency(subsys, i);
+
+		opp = dev_pm_opp_find_freq_exact(cpu, opp_freq * MHZ, true);
+		if (IS_ERR(opp)) {
+			dev_info(asv->dev, "cpu%d opp%d, freq: %u missing\n",
+				 cpu->id, i, opp_freq);
+
+			continue;
+		}
+
+		volt = dev_pm_opp_get_voltage(opp);
+		new_volt = asv->opp_get_voltage(subsys, i, volt);
+		dev_pm_opp_put(opp);
+
+		if (new_volt == volt)
+			continue;
+
+		ret = dev_pm_opp_adjust_voltage(cpu, opp_freq * MHZ,
+						new_volt, new_volt, new_volt);
+		if (ret < 0)
+			dev_err(asv->dev,
+				"Failed to adjust OPP %u Hz/%u uV for cpu%d\n",
+				opp_freq, new_volt, cpu->id);
+		else
+			dev_dbg(asv->dev,
+				"Adjusted OPP %u Hz/%u -> %u uV, cpu%d\n",
+				opp_freq, volt, new_volt, cpu->id);
+	}
+
+	return 0;
+}
+
+static int exynos_asv_update_opps(struct exynos_asv *asv)
+{
+	struct opp_table *last_opp_table = NULL;
+	struct device *cpu;
+	int ret, cpuid;
+
+	for_each_possible_cpu(cpuid) {
+		struct opp_table *opp_table;
+
+		cpu = get_cpu_device(cpuid);
+		if (!cpu)
+			continue;
+
+		opp_table = dev_pm_opp_get_opp_table(cpu);
+		if (IS_ERR(opp_table))
+			continue;
+
+		if (!last_opp_table || opp_table != last_opp_table) {
+			last_opp_table = opp_table;
+
+			ret = exynos_asv_update_cpu_opps(asv, cpu);
+			if (ret < 0)
+				dev_err(asv->dev, "Couldn't udate OPPs for cpu%d\n",
+					cpuid);
+		}
+
+		dev_pm_opp_put_opp_table(opp_table);
+	}
+
+	return	0;
+}
+
+static int exynos_asv_probe(struct platform_device *pdev)
+{
+	int (*probe_func)(struct exynos_asv *asv);
+	struct exynos_asv *asv;
+	struct device *cpu_dev;
+	u32 product_id = 0;
+	int ret, i;
+
+	cpu_dev = get_cpu_device(0);
+	ret = dev_pm_opp_get_opp_count(cpu_dev);
+	if (ret < 0)
+		return -EPROBE_DEFER;
+
+	asv = devm_kzalloc(&pdev->dev, sizeof(*asv), GFP_KERNEL);
+	if (!asv)
+		return -ENOMEM;
+
+	asv->chipid_regmap = syscon_node_to_regmap(pdev->dev.of_node);
+	if (IS_ERR(asv->chipid_regmap)) {
+		dev_err(&pdev->dev, "Could not find syscon regmap\n");
+		return PTR_ERR(asv->chipid_regmap);
+	}
+
+	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PRO_ID, &product_id);
+
+	switch (product_id & EXYNOS_MASK) {
+	case 0xE5422000:
+		probe_func = exynos5422_asv_init;
+		break;
+	default:
+		dev_err(&pdev->dev, "Unsupported product ID: %#x", product_id);
+		return -ENODEV;
+	}
+
+	ret = of_property_read_u32(pdev->dev.of_node, "samsung,asv-bin",
+				   &asv->of_bin);
+	if (ret < 0)
+		asv->of_bin = -EINVAL;
+
+	asv->dev = &pdev->dev;
+	dev_set_drvdata(&pdev->dev, asv);
+
+	for (i = 0; i < ARRAY_SIZE(asv->subsys); i++)
+		asv->subsys[i].asv = asv;
+
+	ret = probe_func(asv);
+	if (ret < 0)
+		return ret;
+
+	return exynos_asv_update_opps(asv);
+}
+
+static const struct of_device_id exynos_asv_of_device_ids[] = {
+	{ .compatible = "samsung,exynos4210-chipid" },
+	{}
+};
+
+static struct platform_driver exynos_asv_driver = {
+	.driver = {
+		.name = "exynos-asv",
+		.of_match_table = exynos_asv_of_device_ids,
+	},
+	.probe	= exynos_asv_probe,
+};
+module_platform_driver(exynos_asv_driver);
diff --git a/drivers/soc/samsung/exynos-asv.h b/drivers/soc/samsung/exynos-asv.h
new file mode 100644
index 000000000000..14b4fedf2ddd
--- /dev/null
+++ b/drivers/soc/samsung/exynos-asv.h
@@ -0,0 +1,82 @@ 
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2019 Samsung Electronics Co., Ltd.
+ *	      http://www.samsung.com/
+ * Author: Sylwester Nawrocki <s.nawrocki@samsung.com>
+ *
+ * Samsung Exynos SoC Adaptive Supply Voltage support
+ */
+#ifndef __LINUX_SOC_EXYNOS_ASV_H
+#define __LINUX_SOC_EXYNOS_ASV_H
+
+enum {
+	EXYNOS_ASV_SUBSYS_ID_ARM,
+	EXYNOS_ASV_SUBSYS_ID_EGL = EXYNOS_ASV_SUBSYS_ID_ARM,
+	EXYNOS_ASV_SUBSYS_ID_KFC,
+	EXYNOS_ASV_SUBSYS_ID_INT,
+	EXYNOS_ASV_SUBSYS_ID_MIF,
+	EXYNOS_ASV_SUBSYS_ID_G3D,
+	EXYNOS_ASV_SUBSYS_ID_CAM,
+	EXYNOS_ASV_SUBSYS_ID_MAX
+};
+
+struct regmap;
+
+/* HPM, IDS values to select target group */
+struct asv_limit_entry {
+	unsigned int hpm;
+	unsigned int ids;
+};
+
+struct exynos_asv_table {
+	unsigned int num_rows;
+	unsigned int num_cols;
+	u32 *buf;
+};
+
+struct exynos_asv_subsys {
+	struct exynos_asv *asv;
+	const char *cpu_dt_compat;
+	int id;
+	struct exynos_asv_table table;
+
+	unsigned int base_volt;
+	unsigned int offset_volt_h;
+	unsigned int offset_volt_l;
+};
+
+struct exynos_asv {
+	struct device *dev;
+	struct regmap *chipid_regmap;
+	struct exynos_asv_subsys subsys[2];
+
+	int (*opp_get_voltage)(struct exynos_asv_subsys *subs, int level,
+			       unsigned int voltage);
+	unsigned int group;
+	unsigned int table;
+
+	/* True if SG fields from PKG_ID register should be used */
+	bool use_sg;
+	/* ASV bin read from DT */
+	int of_bin;
+};
+
+static inline u32 __asv_get_table_entry(struct exynos_asv_table *table,
+					unsigned int row, unsigned int col)
+{
+	return table->buf[row * (table->num_cols) + col];
+}
+
+static inline u32 exynos_asv_opp_get_voltage(struct exynos_asv_subsys *subsys,
+					unsigned int level, unsigned int group)
+{
+	return __asv_get_table_entry(&subsys->table, level, group + 1);
+}
+
+static inline u32 exynos_asv_opp_get_frequency(struct exynos_asv_subsys *subsys,
+					unsigned int level)
+{
+	return __asv_get_table_entry(&subsys->table, level, 0);
+}
+
+#endif /* __LINUX_SOC_EXYNOS_ASV_H */
diff --git a/drivers/soc/samsung/exynos5422-asv.c b/drivers/soc/samsung/exynos5422-asv.c
new file mode 100644
index 000000000000..7982f2ca0f11
--- /dev/null
+++ b/drivers/soc/samsung/exynos5422-asv.c
@@ -0,0 +1,509 @@ 
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Copyright (c) 2019 Samsung Electronics Co., Ltd.
+ *	      http://www.samsung.com/
+ *
+ * Samsung Exynos 5422 SoC Adaptive Supply Voltage support
+ */
+
+#include <linux/bitrev.h>
+#include <linux/device.h>
+#include <linux/errno.h>
+#include <linux/of.h>
+#include <linux/regmap.h>
+#include <linux/soc/samsung/exynos-chipid.h>
+#include <linux/slab.h>
+
+#include "exynos-asv.h"
+
+#define ASV_GROUPS_NUM		14
+#define ASV_ARM_DVFS_NUM	20
+#define ASV_ARM_BIN2_DVFS_NUM	17
+#define ASV_KFC_DVFS_NUM	14
+#define ASV_KFC_BIN2_DVFS_NUM	12
+
+/*
+ * This array is a set of 4 ASV data tables, first column of each ASV table
+ * contains frequency value in MHz and subsequent columns contain the CPU
+ * cluster's supply voltage values in uV.
+ * In order to create a set of OPPs for specific SoC revision one of the voltage
+ * columns (1...14) from one of the tables (0...3) is selected during
+ * initialization. There are separate ASV tables for the big (ARM) and little
+ * (KFC) CPU cluster. Only OPPs which are already defined in devicetree
+ * will be updated.
+ */
+
+static const u32 asv_arm_table[][ASV_ARM_DVFS_NUM][ASV_GROUPS_NUM + 1] = {
+{
+	/* ARM 0, 1 */
+	{ 2100,    1362500, 1362500, 1350000, 1337500, 1325000, 1312500, 1300000,
+	  1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000 },
+	{ 2000,    1312500, 1312500, 1300000, 1287500, 1275000, 1262500, 1250000,
+	  1237500, 1225000, 1237500, 1225000, 1212500, 1200000, 1187500 },
+	{ 1900,    1250000, 1237500, 1225000, 1212500, 1200000, 1187500, 1175000,
+	  1162500, 1150000, 1162500, 1150000, 1137500, 1125000, 1112500 },
+	{ 1800,    1200000, 1187500, 1175000, 1162500, 1150000, 1137500, 1125000,
+	  1112500, 1100000, 1112500, 1100000, 1087500, 1075000, 1062500 },
+	{ 1700,    1162500, 1150000, 1137500, 1125000, 1112500, 1100000, 1087500,
+	  1075000, 1062500, 1075000, 1062500, 1050000, 1037500, 1025000 },
+	{ 1600,    1125000, 1112500, 1100000, 1087500, 1075000, 1062500, 1050000,
+	  1037500, 1025000, 1037500, 1025000, 1012500, 1000000, 987500 },
+	{ 1500,    1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500,
+	  1000000, 987500,  1000000, 987500,  975000,  962500,  950000 },
+	{ 1400,    1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500,
+	  975000,  962500,  975000,  962500,  950000,  937500,  925000 },
+	{ 1300,    1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000,
+	  962500,  950000,  962500,  950000,  937500,  925000,  912500 },
+	{ 1200,    1025000, 1012500, 1000000, 987500,  975000,  962500,  950000,
+	  937500,  925000,  937500,  925000,  912500,  900000,  900000 },
+	{ 1100,    1000000, 987500,  975000,  962500,  950000,  937500,  925000,
+	  912500,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 1000,    975000,  962500,  950000,  937500,  925000,  912500,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 900,     950000,  937500,  925000,  912500,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 800,     925000,  912500,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 700,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 600,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 500,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 400,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+}, {
+	/* ARM 2 */
+	{ 2100,    1362500, 1362500, 1350000, 1337500, 1325000, 1312500, 1300000,
+	  1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000 },
+	{ 2000,    1312500, 1312500, 1312500, 1300000, 1275000, 1262500, 1250000,
+	  1237500, 1225000, 1237500, 1225000, 1212500, 1200000, 1187500 },
+	{ 1900,    1262500, 1250000, 1250000, 1237500, 1212500, 1200000, 1187500,
+	  1175000, 1162500, 1175000, 1162500, 1150000, 1137500, 1125000 },
+	{ 1800,    1212500, 1200000, 1187500, 1175000, 1162500, 1150000, 1137500,
+	  1125000, 1112500, 1125000, 1112500, 1100000, 1087500, 1075000 },
+	{ 1700,    1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000,
+	  1087500, 1075000, 1087500, 1075000, 1062500, 1050000, 1037500 },
+	{ 1600,    1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500,
+	  1050000, 1037500, 1050000, 1037500, 1025000, 1012500, 1000000 },
+	{ 1500,    1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000,
+	  1012500, 1000000, 1012500, 1000000, 987500,  975000,  962500 },
+	{ 1400,    1075000, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000,
+	  987500,  975000,  987500,  975000,  962500,  950000,  937500 },
+	{ 1300,    1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000,
+	  962500,  950000,  962500,  950000,  937500,  925000,  912500 },
+	{ 1200,    1025000, 1012500, 1000000, 987500,  975000,  962500,  950000,
+	  937500,  925000,  937500,  925000,  912500,  900000,  900000 },
+	{ 1100,    1000000, 987500,  975000,  962500,  950000,  937500,  925000,
+	  912500,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 1000,    975000,  962500,  950000,  937500,  925000,  912500,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 900,     950000,  937500,  925000,  912500,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 800,     925000,  912500,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 700,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 600,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 500,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 400,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+}, {
+	/* ARM 3 */
+	{ 2100,    1362500, 1362500, 1350000, 1337500, 1325000, 1312500, 1300000,
+	  1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000 },
+	{ 2000,    1312500, 1312500, 1300000, 1287500, 1275000, 1262500, 1250000,
+	  1237500, 1225000, 1237500, 1225000, 1212500, 1200000, 1187500 },
+	{ 1900,    1262500, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500,
+	  1175000, 1162500, 1175000, 1162500, 1150000, 1137500, 1125000 },
+	{ 1800,    1212500, 1200000, 1187500, 1175000, 1162500, 1150000, 1137500,
+	  1125000, 1112500, 1125000, 1112500, 1100000, 1087500, 1075000 },
+	{ 1700,    1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000,
+	  1087500, 1075000, 1087500, 1075000, 1062500, 1050000, 1037500 },
+	{ 1600,    1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500,
+	  1050000, 1037500, 1050000, 1037500, 1025000, 1012500, 1000000 },
+	{ 1500,    1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000,
+	  1012500, 1000000, 1012500, 1000000, 987500,  975000,  962500 },
+	{ 1400,    1075000, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000,
+	  987500,  975000,  987500,  975000,  962500,  950000,  937500 },
+	{ 1300,    1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000,
+	  962500,  950000,  962500,  950000,  937500,  925000,  912500 },
+	{ 1200,    1025000, 1012500, 1000000, 987500,  975000,  962500,  950000,
+	  937500,  925000,  937500,  925000,  912500,  900000,  900000 },
+	{ 1100,    1000000, 987500,  975000,  962500,  950000,  937500,  925000,
+	  912500,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 1000,    975000,  962500,  950000,  937500,  925000,  912500,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 900,     950000,  937500,  925000,  912500,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 800,     925000,  912500,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 700,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 600,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 500,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 400,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+}, {
+	/* ARM bin 2 */
+	{ 1800,    1237500, 1225000, 1212500, 1200000, 1187500, 1175000, 1162500,
+	  1150000, 1137500, 1150000, 1137500, 1125000, 1112500, 1100000 },
+	{ 1700,    1200000, 1187500, 1175000, 1162500, 1150000, 1137500, 1125000,
+	  1112500, 1100000, 1112500, 1100000, 1087500, 1075000, 1062500 },
+	{ 1600,    1162500, 1150000, 1137500, 1125000, 1112500, 1100000, 1087500,
+	  1075000, 1062500, 1075000, 1062500, 1050000, 1037500, 1025000 },
+	{ 1500,    1125000, 1112500, 1100000, 1087500, 1075000, 1062500, 1050000,
+	  1037500, 1025000, 1037500, 1025000, 1012500, 1000000, 987500 },
+	{ 1400,    1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000,
+	  1012500, 1000000, 1012500, 1000000, 987500,  975000,  962500 },
+	{ 1300,    1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500,
+	  1000000, 987500,  1000000, 987500,  975000,  962500,  950000 },
+	{ 1200,    1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500,
+	  975000,  962500,  975000,  962500,  950000,  937500,  925000 },
+	{ 1100,    1037500, 1025000, 1012500, 1000000, 987500,  975000,  962500,
+	  950000,  937500,  950000,  937500,  925000,  912500,  900000 },
+	{ 1000,    1012500, 1000000, 987500,  975000,  962500,  950000,  937500,
+	  925000,  912500,  925000,  912500,  900000,  900000,  900000 },
+	{ 900,     987500,  975000,  962500,  950000,  937500,  925000,  912500,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 800,     962500,  950000,  937500,  925000,  912500,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 700,     937500,  925000,  912500,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 600,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 500,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 400,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+}
+};
+
+static const u32 asv_kfc_table[][ASV_KFC_DVFS_NUM][ASV_GROUPS_NUM + 1] = {
+{
+	/* KFC 0, 1 */
+	{ 1500000, 1300000, 1300000, 1300000, 1287500, 1287500, 1287500, 1275000,
+	  1262500, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500 },
+	{ 1400000, 1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000,
+	  1187500, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500 },
+	{ 1300000, 1225000, 1212500, 1200000, 1187500, 1175000, 1162500, 1150000,
+	  1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500 },
+	{ 1200000, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000,
+	  1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500 },
+	{ 1100000, 1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500,
+	  1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000 },
+	{ 1000000, 1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000,
+	  1012500, 1000000, 987500,  975000,  962500,  950000,  937500 },
+	{ 900000,  1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500,
+	  975000,  962500,  950000,  937500,  925000,  912500,  900000 },
+	{ 800000,  1025000, 1012500, 1000000, 987500,  975000,  962500,  950000,
+	  937500,  925000,  912500,  900000,  900000,  900000,  900000 },
+	{ 700000,  987500,  975000,  962500,  950000,  937500,  925000,  912500,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 600000,  950000,  937500,  925000,  912500,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 500000,  912500,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 400000,  900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 300000,  900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 200000,  900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+}, {
+	/* KFC 2 */
+	{ 1500,    1300000, 1300000, 1300000, 1287500, 1287500, 1287500, 1275000,
+	  1262500, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500 },
+	{ 1400,    1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000,
+	  1187500, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500 },
+	{ 1300,    1225000, 1212500, 1200000, 1187500, 1175000, 1162500, 1150000,
+	  1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500 },
+	{ 1200,    1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000,
+	  1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500 },
+	{ 1100,    1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500,
+	  1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000 },
+	{ 1000,    1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000,
+	  1012500, 1000000, 987500,  975000,  962500,  950000,  937500 },
+	{ 900,     1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500,
+	  975000,  962500,  950000,  937500,  925000,  912500,  900000 },
+	{ 800,     1025000, 1012500, 1000000, 987500,  975000,  962500,  950000,
+	  937500,  925000,  912500,  900000,  900000,  900000,  900000 },
+	{ 700,     987500,  975000,  962500,  950000,  937500,  925000,  912500,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 600,     950000,  937500,  925000,  912500,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 500,     912500,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 400,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+}, {
+	/* KFC 3 */
+	{ 1500,    1300000, 1300000, 1300000, 1287500, 1287500, 1287500, 1275000,
+	  1262500, 1250000, 1237500, 1225000, 1212500, 1200000, 1187500 },
+	{ 1400,    1275000, 1262500, 1250000, 1237500, 1225000, 1212500, 1200000,
+	  1187500, 1175000, 1162500, 1150000, 1137500, 1125000, 1112500 },
+	{ 1300,    1225000, 1212500, 1200000, 1187500, 1175000, 1162500, 1150000,
+	  1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500 },
+	{ 1200,    1175000, 1162500, 1150000, 1137500, 1125000, 1112500, 1100000,
+	  1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500 },
+	{ 1100,    1137500, 1125000, 1112500, 1100000, 1087500, 1075000, 1062500,
+	  1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000 },
+	{ 1000,    1100000, 1087500, 1075000, 1062500, 1050000, 1037500, 1025000,
+	  1012500, 1000000, 987500,  975000,  962500,  950000,  937500 },
+	{ 900,     1062500, 1050000, 1037500, 1025000, 1012500, 1000000, 987500,
+	  975000,  962500,  950000,  937500,  925000,  912500,  900000 },
+	{ 800,     1025000, 1012500, 1000000, 987500,  975000,  962500,  950000,
+	  937500,  925000,  912500,  900000,  900000,  900000,  900000 },
+	{ 700,     987500,  975000,  962500,  950000,  937500,  925000,  912500,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 600,     950000,  937500,  925000,  912500,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 500,     912500,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 400,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+}, {
+	/* KFC bin 2 */
+	{ 1300,    1250000, 1237500, 1225000, 1212500, 1200000, 1187500, 1175000,
+	  1162500, 1150000, 1137500, 1125000, 1112500, 1100000, 1087500 },
+	{ 1200,    1200000, 1187500, 1175000, 1162500, 1150000, 1137500, 1125000,
+	  1112500, 1100000, 1087500, 1075000, 1062500, 1050000, 1037500 },
+	{ 1100,    1162500, 1150000, 1137500, 1125000, 1112500, 1100000, 1087500,
+	  1075000, 1062500, 1050000, 1037500, 1025000, 1012500, 1000000 },
+	{ 1000,    1125000, 1112500, 1100000, 1087500, 1075000, 1062500, 1050000,
+	  1037500, 1025000, 1012500, 1000000, 987500,  975000,  962500 },
+	{ 900,     1087500, 1075000, 1062500, 1050000, 1037500, 1025000, 1012500,
+	  1000000, 987500,  975000,  962500,  950000,  937500,  925000 },
+	{ 800,     1050000, 1037500, 1025000, 1012500, 1000000, 987500,  975000,
+	  962500,  950000,  937500,  925000,  912500,  900000,  900000 },
+	{ 700,     1012500, 1000000, 987500,  975000,  962500,  950000,  937500,
+	  925000,  912500,  900000,  900000,  900000,  900000,  900000 },
+	{ 600,     975000,  962500,  950000,  937500,  925000,  912500,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 500,     937500,  925000,  912500,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 400,     925000,  912500,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 300,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+	{ 200,     900000,  900000,  900000,  900000,  900000,  900000,  900000,
+	  900000,  900000,  900000,  900000,  900000,  900000,  900000 },
+}
+};
+
+static const struct asv_limit_entry __asv_limits[ASV_GROUPS_NUM] = {
+	{ 13, 55 },
+	{ 21, 65 },
+	{ 25, 69 },
+	{ 30, 72 },
+	{ 36, 74 },
+	{ 43, 76 },
+	{ 51, 78 },
+	{ 65, 80 },
+	{ 81, 82 },
+	{ 98, 84 },
+	{ 119, 87 },
+	{ 135, 89 },
+	{ 150, 92 },
+	{ 999, 999 },
+};
+
+static int exynos5422_asv_get_group(struct exynos_asv *asv)
+{
+	unsigned int pkgid_reg, auxi_reg;
+	int hpm, ids, i;
+
+	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PKG_ID, &pkgid_reg);
+	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_AUX_INFO, &auxi_reg);
+
+	if (asv->use_sg) {
+		u32 sga = (pkgid_reg >> EXYNOS5422_SG_A_OFFSET) &
+			   EXYNOS5422_SG_A_MASK;
+
+		u32 sgb = (pkgid_reg >> EXYNOS5422_SG_B_OFFSET) &
+			   EXYNOS5422_SG_B_MASK;
+
+		if ((pkgid_reg >> EXYNOS5422_SG_BSIGN_OFFSET) &
+		     EXYNOS5422_SG_BSIGN_MASK)
+			return sga + sgb;
+		else
+			return sga - sgb;
+	}
+
+	hpm = (auxi_reg >> EXYNOS5422_TMCB_OFFSET) & EXYNOS5422_TMCB_MASK;
+	ids = (pkgid_reg >> EXYNOS5422_IDS_OFFSET) & EXYNOS5422_IDS_MASK;
+
+	for (i = 0; i < ASV_GROUPS_NUM; i++) {
+		if (ids <= __asv_limits[i].ids)
+			break;
+		if (hpm <= __asv_limits[i].hpm)
+			break;
+	}
+	if (i < ASV_GROUPS_NUM)
+		return i;
+
+	return 0;
+}
+
+static int __asv_offset_voltage(unsigned int index)
+{
+	switch (index) {
+	case 1:
+		return 12500;
+	case 2:
+		return 50000;
+	case 3:
+		return 25000;
+	default:
+		return 0;
+	};
+}
+
+static void exynos5422_asv_offset_voltage_setup(struct exynos_asv *asv)
+{
+	struct exynos_asv_subsys *subsys;
+	unsigned int reg, value;
+
+	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_AUX_INFO, &reg);
+
+	/* ARM offset voltage setup */
+	subsys = &asv->subsys[EXYNOS_ASV_SUBSYS_ID_ARM];
+
+	subsys->base_volt = 1000000;
+
+	value = (reg >> EXYNOS5422_ARM_UP_OFFSET) & EXYNOS5422_ARM_UP_MASK;
+	subsys->offset_volt_h = __asv_offset_voltage(value);
+
+	value = (reg >> EXYNOS5422_ARM_DN_OFFSET) & EXYNOS5422_ARM_DN_MASK;
+	subsys->offset_volt_l = __asv_offset_voltage(value);
+
+	/* KFC offset voltage setup */
+	subsys = &asv->subsys[EXYNOS_ASV_SUBSYS_ID_KFC];
+
+	subsys->base_volt = 1000000;
+
+	value = (reg >> EXYNOS5422_KFC_UP_OFFSET) & EXYNOS5422_KFC_UP_MASK;
+	subsys->offset_volt_h = __asv_offset_voltage(value);
+
+	value = (reg >> EXYNOS5422_KFC_DN_OFFSET) & EXYNOS5422_KFC_DN_MASK;
+	subsys->offset_volt_l = __asv_offset_voltage(value);
+}
+
+static int exynos5422_asv_opp_get_voltage(struct exynos_asv_subsys *subsys,
+				int level, unsigned int volt)
+{
+	unsigned int asv_volt;
+
+	if (level >= subsys->table.num_rows)
+		return volt;
+
+	asv_volt = exynos_asv_opp_get_voltage(subsys, level,
+					      subsys->asv->group);
+
+	if (volt > subsys->base_volt)
+		asv_volt += subsys->offset_volt_h;
+	else
+		asv_volt += subsys->offset_volt_l;
+
+	return asv_volt;
+}
+
+static unsigned int exynos5422_asv_parse_table(struct exynos_asv *asv,
+				      unsigned int pkg_id)
+{
+	return (pkg_id >> EXYNOS5422_TABLE_OFFSET) & EXYNOS5422_TABLE_MASK;
+}
+
+static bool exynos5422_asv_parse_bin2(struct exynos_asv *asv,
+				     unsigned int pkg_id)
+{
+	return (pkg_id >> EXYNOS5422_BIN2_OFFSET) & EXYNOS5422_BIN2_MASK;
+}
+
+static bool exynos5422_asv_parse_sg(struct exynos_asv *asv,
+					unsigned int pkg_id)
+{
+	return (pkg_id >> EXYNOS5422_USESG_OFFSET) & EXYNOS5422_USESG_MASK;
+}
+
+int exynos5422_asv_init(struct exynos_asv *asv)
+{
+	struct exynos_asv_subsys *subsys;
+	unsigned int table_index;
+	unsigned int pkg_id;
+	bool bin2;
+
+	regmap_read(asv->chipid_regmap, EXYNOS_CHIPID_REG_PKG_ID, &pkg_id);
+
+	if (asv->of_bin == 2) {
+		bin2 = true;
+		asv->use_sg = false;
+	} else {
+		asv->use_sg = exynos5422_asv_parse_sg(asv, pkg_id);
+		bin2 = exynos5422_asv_parse_bin2(asv, pkg_id);
+	}
+
+	asv->group = exynos5422_asv_get_group(asv);
+	asv->table = exynos5422_asv_parse_table(asv, pkg_id);
+
+	exynos5422_asv_offset_voltage_setup(asv);
+
+	if (bin2) {
+		table_index = 3;
+	} else {
+		if (asv->table == 2 || asv->table == 3)
+			table_index = asv->table - 1;
+		else
+			table_index = 0;
+	}
+
+	subsys = &asv->subsys[EXYNOS_ASV_SUBSYS_ID_ARM];
+	subsys->cpu_dt_compat = "arm,cortex-a15";
+	if (bin2)
+		subsys->table.num_rows = ASV_ARM_BIN2_DVFS_NUM;
+	else
+		subsys->table.num_rows = ASV_ARM_DVFS_NUM;
+	subsys->table.num_cols = ASV_GROUPS_NUM + 1;
+	subsys->table.buf = (u32 *)asv_arm_table[table_index];
+
+	subsys = &asv->subsys[EXYNOS_ASV_SUBSYS_ID_KFC];
+	subsys->cpu_dt_compat = "arm,cortex-a7";
+	if (bin2)
+		subsys->table.num_rows = ASV_KFC_BIN2_DVFS_NUM;
+	else
+		subsys->table.num_rows = ASV_KFC_DVFS_NUM;
+	subsys->table.num_cols = ASV_GROUPS_NUM + 1;
+	subsys->table.buf = (u32 *)asv_kfc_table[table_index];
+
+	asv->opp_get_voltage = exynos5422_asv_opp_get_voltage;
+
+	return 0;
+}
diff --git a/drivers/soc/samsung/exynos5422-asv.h b/drivers/soc/samsung/exynos5422-asv.h
new file mode 100644
index 000000000000..85218d2800fb
--- /dev/null
+++ b/drivers/soc/samsung/exynos5422-asv.h
@@ -0,0 +1,25 @@ 
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2019 Samsung Electronics Co., Ltd.
+ *	      http://www.samsung.com/
+ *
+ * Samsung Exynos 5422 SoC Adaptive Supply Voltage support
+ */
+
+#ifndef __LINUX_SOC_EXYNOS5422_ASV_H
+#define __LINUX_SOC_EXYNOS5422_ASV_H
+
+#include <linux/errno.h>
+
+struct exynos_asv;
+
+#ifdef CONFIG_EXYNOS_ASV_ARM
+int exynos5422_asv_init(struct exynos_asv *asv);
+#else
+static inline int exynos5422_asv_init(struct exynos_asv *asv)
+{
+	return -ENOTSUPP;
+}
+#endif
+
+#endif /* __LINUX_SOC_EXYNOS5422_ASV_H */