mbox series

[0/3] target: minor iSCSI parameter parsing fixes

Message ID 20190912095547.22427-1-ddiss@suse.de (mailing list archive)
Headers show
Series target: minor iSCSI parameter parsing fixes | expand

Message

David Disseldorp Sept. 12, 2019, 9:55 a.m. UTC 
This patchset includes some minor fixes for parsing iSCSI CHAP_A and
SendTargets fields. Patch 1/3 was already submitted and reviewed by
Lee.
I used the following libiscsi hacks to test for these bugs:
https://github.com/ddiss/libiscsi/commits/bogus_chap_a
https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_key
https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_val
I'll work on turning these into propper libiscsi regression tests
(pending https://github.com/sahlberg/libiscsi/issues/297).

Cheers, David

 drivers/target/iscsi/iscsi_target.c            | 14 ++++++--------
 drivers/target/iscsi/iscsi_target_auth.c       |  2 +-
 drivers/target/iscsi/iscsi_target_parameters.h |  3 ---
 3 files changed, 7 insertions(+), 12 deletions(-)

Comments

Mike Christie Oct. 21, 2019, 4:06 p.m. UTC | #1 
On 09/12/2019 04:55 AM, David Disseldorp wrote:
> This patchset includes some minor fixes for parsing iSCSI CHAP_A and
> SendTargets fields. Patch 1/3 was already submitted and reviewed by
> Lee.
> I used the following libiscsi hacks to test for these bugs:
> https://github.com/ddiss/libiscsi/commits/bogus_chap_a
> https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_key
> https://github.com/ddiss/libiscsi/commits/bogus_sendtarget_val
> I'll work on turning these into propper libiscsi regression tests
> (pending https://github.com/sahlberg/libiscsi/issues/297).
> 
> Cheers, David
> 
>  drivers/target/iscsi/iscsi_target.c            | 14 ++++++--------
>  drivers/target/iscsi/iscsi_target_auth.c       |  2 +-
>  drivers/target/iscsi/iscsi_target_parameters.h |  3 ---
>  3 files changed, 7 insertions(+), 12 deletions(-)
> 

Reviewed-by: Mike Christie <mchristi@redhat.com>
Martin K. Petersen Oct. 23, 2019, 2:14 a.m. UTC | #2 
>> This patchset includes some minor fixes for parsing iSCSI CHAP_A and
>> SendTargets fields. Patch 1/3 was already submitted and reviewed by
>> Lee.

> Reviewed-by: Mike Christie <mchristi@redhat.com>

Applied to 5.5/scsi-queue, thanks!