mbox series

[for-next,0/4] EFA RDMA read support

Message ID 20190910134301.4194-1-galpress@amazon.com (mailing list archive)
Headers show
Series EFA RDMA read support | expand

Message

Gal Pressman Sept. 10, 2019, 1:42 p.m. UTC 
Hi,

The following series introduces RDMA read support and capabilities
reporting to the EFA driver.

The first two patches aren't directly related to RDMA read, but refactor
some bits in the device capabilities struct.

The last two patches add support for remote read access in MR
registration and expose the RDMA read related attributes to the
userspace library.

PR was sent:
https://github.com/linux-rdma/rdma-core/pull/576

Thanks,
Gal

Daniel Kranzdorf (2):
  RDMA/efa: Support remote read access in MR registration
  RDMA/efa: Expose RDMA read related attributes

Gal Pressman (2):
  RDMA/efa: Fix incorrect error print
  RDMA/efa: Store network attributes in device attributes

 drivers/infiniband/hw/efa/efa.h               |  2 -
 .../infiniband/hw/efa/efa_admin_cmds_defs.h   | 29 +++++++++++--
 drivers/infiniband/hw/efa/efa_com_cmd.c       | 41 ++++++++-----------
 drivers/infiniband/hw/efa/efa_com_cmd.h       | 18 +++-----
 drivers/infiniband/hw/efa/efa_main.c          | 16 --------
 drivers/infiniband/hw/efa/efa_verbs.c         | 15 ++++---
 include/uapi/rdma/efa-abi.h                   |  3 ++
 7 files changed, 59 insertions(+), 65 deletions(-)

Comments

Gal Pressman Oct. 20, 2019, 7:03 a.m. UTC | #1 
On 10/09/2019 16:42, Gal Pressman wrote:
> Hi,
> 
> The following series introduces RDMA read support and capabilities
> reporting to the EFA driver.
> 
> The first two patches aren't directly related to RDMA read, but refactor
> some bits in the device capabilities struct.
> 
> The last two patches add support for remote read access in MR
> registration and expose the RDMA read related attributes to the
> userspace library.
> 
> PR was sent:
> https://github.com/linux-rdma/rdma-core/pull/576

Should I resubmit patches 2-4?
Jason Gunthorpe Oct. 21, 2019, 5:31 p.m. UTC | #2 
On Sun, Oct 20, 2019 at 10:03:27AM +0300, Gal Pressman wrote:
> On 10/09/2019 16:42, Gal Pressman wrote:
> > Hi,
> > 
> > The following series introduces RDMA read support and capabilities
> > reporting to the EFA driver.
> > 
> > The first two patches aren't directly related to RDMA read, but refactor
> > some bits in the device capabilities struct.
> > 
> > The last two patches add support for remote read access in MR
> > registration and expose the RDMA read related attributes to the
> > userspace library.
> > 
> > PR was sent:
> > https://github.com/linux-rdma/rdma-core/pull/576
> 
> Should I resubmit patches 2-4?

No it is still on patchworks. You said not to apply your series until
you said it was OK

Jason
Gal Pressman Oct. 23, 2019, 9:55 a.m. UTC | #3 
On 21/10/2019 20:31, Jason Gunthorpe wrote:
> On Sun, Oct 20, 2019 at 10:03:27AM +0300, Gal Pressman wrote:
>> On 10/09/2019 16:42, Gal Pressman wrote:
>>> Hi,
>>>
>>> The following series introduces RDMA read support and capabilities
>>> reporting to the EFA driver.
>>>
>>> The first two patches aren't directly related to RDMA read, but refactor
>>> some bits in the device capabilities struct.
>>>
>>> The last two patches add support for remote read access in MR
>>> registration and expose the RDMA read related attributes to the
>>> userspace library.
>>>
>>> PR was sent:
>>> https://github.com/linux-rdma/rdma-core/pull/576
>>
>> Should I resubmit patches 2-4?
> 
> No it is still on patchworks. You said not to apply your series until
> you said it was OK

Thanks, is it possible to send a mail when the series is reviewed/ready to merge
and waiting to be applied?

Specifically for this feature, it seems we are going to need a capability bit
for the RDMA read functionality, so I'll respin the kernel and userspace and
submit again.
You can drop this one from patchworks.
Jason Gunthorpe Oct. 23, 2019, 2:35 p.m. UTC | #4 
On Wed, Oct 23, 2019 at 12:55:27PM +0300, Gal Pressman wrote:
> On 21/10/2019 20:31, Jason Gunthorpe wrote:
> > On Sun, Oct 20, 2019 at 10:03:27AM +0300, Gal Pressman wrote:
> >> On 10/09/2019 16:42, Gal Pressman wrote:
> >>> Hi,
> >>>
> >>> The following series introduces RDMA read support and capabilities
> >>> reporting to the EFA driver.
> >>>
> >>> The first two patches aren't directly related to RDMA read, but refactor
> >>> some bits in the device capabilities struct.
> >>>
> >>> The last two patches add support for remote read access in MR
> >>> registration and expose the RDMA read related attributes to the
> >>> userspace library.
> >>>
> >>> PR was sent:
> >>> https://github.com/linux-rdma/rdma-core/pull/576
> >>
> >> Should I resubmit patches 2-4?
> > 
> > No it is still on patchworks. You said not to apply your series until
> > you said it was OK
> 
> Thanks, is it possible to send a mail when the series is reviewed/ready to merge
> and waiting to be applied?

Oh, I wasn't going to review anything until it was ready to apply

> You can drop this one from patchworks.

done

Jason