[net,v5,00/10] net: fix nested device bugs

Message

Taehee Yoo Oct. 21, 2019, 6:47 p.m. UTC

This patchset fixes several bugs that are related to nesting
device infrastructure.
Current nesting infrastructure code doesn't limit the depth level of
devices. nested devices could be handled recursively. at that moment,
it needs huge memory and stack overflow could occur.
Below devices type have same bug.
VLAN, BONDING, TEAM, MACSEC, MACVLAN, IPVLAN, and VXLAN.
But I couldn't test all interface types so there could be more device
types, which have similar problems.
Maybe qmi_wwan.c code could have same problem.
So, I would appreciate if someone test qmi_wwan.c and other modules.

Test commands:
    ip link add dummy0 type dummy
    ip link add vlan1 link dummy0 type vlan id 1

    for i in {2..100}
    do
	    let A=$i-1
	    ip link add name vlan$i link vlan$A type vlan id $i
    done
    ip link del dummy0

1st patch actually fixes the root cause.
It adds new common variables {upper/lower}_level that represent
depth level. upper_level variable is depth of upper devices.
lower_level variable is depth of lower devices.

      [U][L]       [U][L]
vlan1  1  5  vlan4  1  4
vlan2  2  4  vlan5  2  3
vlan3  3  3    |
  |            |
  +------------+
  |
vlan6  4  2
dummy0 5  1

After this patch, the nesting infrastructure code uses this variable to
check the depth level.

2nd patch fixes Qdisc lockdep related problem.
Before this patch, devices use static lockdep map.
So, if devices that are same types are nested, lockdep will warn about
recursive situation.
These patches make these devices use dynamic lockdep key instead of
static lock or subclass.

3rd patch fixes unexpected IFF_BONDING bit unset.
When nested bonding interface scenario, bonding interface could lost it's
IFF_BONDING flag. This should not happen.
This patch adds a condition before unsetting IFF_BONDING.

4th patch fixes nested locking problem in bonding interface
Bonding interface has own lock and this uses static lock.
Bonding interface could be nested and it uses same lockdep key.
So that unexisting lockdep warning occurs.

5th patch fixes nested locking problem in team interface
Team interface has own lock and this uses static lock.
Team interface could be nested and it uses same lockdep key.
So that unexisting lockdep warning occurs.

6th patch fixes a refcnt leak in the macsec module.
When the macsec module is unloaded, refcnt leaks occur.
But actually, that holding refcnt is unnecessary.
So this patch just removes these code.

7th patch adds ignore flag to an adjacent structure.
In order to exchange an adjacent node safely, ignore flag is needed.

8th patch makes vxlan add an adjacent link to limit depth level.
Vxlan interface could set it's lower interface and these lower interfaces
are handled recursively.
So, if the depth of lower interfaces is too deep, stack overflow could
happen.

9th patch removes unnecessary variables and callback.
After 1st patch, subclass callback and variables are unnecessary.
This patch just removes these variables and callback.

10th patch fix refcnt leaks in the virt_wifi module
Like every nested interface, the upper interface should be deleted
before the lower interface is deleted.
In order to fix this, the notifier routine is added in this patch.

v4 -> v5 :
 - Update log messages
 - Move variables position, 1st patch
 - Fix iterator routine, 1st patch
 - Add generic lockdep key code, which replaces 2, 4, 5, 6, 7 patches.
 - Log message update, 10th patch
 - Fix wrong error value in error path of __init routine, 10th patch
 - hold module refcnt when interface is created, 10th patch
v3 -> v4 :
 - Add new 12th patch to fix refcnt leaks in the virt_wifi module
 - Fix wrong usage netdev_upper_dev_link() in the vxlan.c
 - Preserve reverse christmas tree variable ordering in the vxlan.c
 - Add missing static keyword in the dev.c
 - Expose netdev_adjacent_change_{prepare/commit/abort} instead of
   netdev_adjacent_dev_{enable/disable}
v2 -> v3 :
 - Modify nesting infrastructure code to use iterator instead of recursive.
v1 -> v2 :
 - Make the 3rd patch do not add a new priv_flag.

Taehee Yoo (10):
  net: core: limit nested device depth
  net: core: add generic lockdep keys
  bonding: fix unexpected IFF_BONDING bit unset
  bonding: use dynamic lockdep key instead of subclass
  team: fix nested locking lockdep warning
  macsec: fix refcnt leak in module exit routine
  net: core: add ignore flag to netdev_adjacent structure
  vxlan: add adjacent link to limit depth level
  net: remove unnecessary variables and callback
  virt_wifi: fix refcnt leak in module exit routine

 drivers/net/bonding/bond_alb.c                |   2 +-
 drivers/net/bonding/bond_main.c               |  30 +-
 .../net/ethernet/mellanox/mlx5/core/en_tc.c   |   2 +-
 .../net/ethernet/netronome/nfp/nfp_net_repr.c |  18 -
 drivers/net/hamradio/bpqether.c               |  22 -
 drivers/net/hyperv/netvsc_drv.c               |   2 -
 drivers/net/ipvlan/ipvlan_main.c              |   2 -
 drivers/net/macsec.c                          |  18 -
 drivers/net/macvlan.c                         |  19 -
 drivers/net/ppp/ppp_generic.c                 |   2 -
 drivers/net/team/team.c                       |  16 +-
 drivers/net/vrf.c                             |   1 -
 drivers/net/vxlan.c                           |  53 +-
 .../net/wireless/intersil/hostap/hostap_hw.c  |  25 -
 drivers/net/wireless/virt_wifi.c              |  54 +-
 include/linux/if_macvlan.h                    |   1 -
 include/linux/if_team.h                       |   1 +
 include/linux/if_vlan.h                       |  11 -
 include/linux/netdevice.h                     |  61 +-
 include/net/bonding.h                         |   2 +-
 include/net/vxlan.h                           |   1 +
 net/8021q/vlan.c                              |   1 -
 net/8021q/vlan_dev.c                          |  33 -
 net/batman-adv/soft-interface.c               |  32 -
 net/bluetooth/6lowpan.c                       |   8 -
 net/bridge/br_device.c                        |   8 -
 net/core/dev.c                                | 618 +++++++++++++-----
 net/core/dev_addr_lists.c                     |  12 +-
 net/core/rtnetlink.c                          |   1 +
 net/dsa/master.c                              |   5 -
 net/dsa/slave.c                               |  12 -
 net/ieee802154/6lowpan/core.c                 |   8 -
 net/l2tp/l2tp_eth.c                           |   1 -
 net/netrom/af_netrom.c                        |  23 -
 net/rose/af_rose.c                            |  23 -
 net/sched/sch_generic.c                       |  17 +-
 net/smc/smc_core.c                            |   2 +-
 net/smc/smc_pnet.c                            |   2 +-
 38 files changed, 628 insertions(+), 521 deletions(-)

Comments

David Miller Oct. 24, 2019, 9:55 p.m. UTC | #1

From: Taehee Yoo <[e-mail]>
Date: Mon, 21 Oct 2019 18:47:10 +0000

> This patchset fixes several bugs that are related to nesting
> device infrastructure.
 ...

Series applied.

There were some inline functions in foo.c files which we don't so, we
let the compiler decide.  So I removed the inline keyword in these case
when applying this series.

Thanks.

Taehee Yoo Oct. 25, 2019, 4:53 p.m. UTC | #2

On Fri, 25 Oct 2019 at 06:55, David Miller <[e-mail]> wrote:
>
> From: Taehee Yoo <[e-mail]>
> Date: Mon, 21 Oct 2019 18:47:10 +0000
>
> > This patchset fixes several bugs that are related to nesting
> > device infrastructure.
>  ...
>
> Series applied.
>
> There were some inline functions in foo.c files which we don't so, we
> let the compiler decide.  So I removed the inline keyword in these case
> when applying this series.
>

Thank you so much for the review and for modifying this point.
Taehee Yoo

> Thanks.