| Message ID | 20191024154455.19370-2-jthumshirn@suse.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Provide an estimation of (free/total) inodes in statfs | expand |
On Thu, Oct 24, 2019 at 05:44:54PM +0200, Johannes Thumshirn wrote: > In btrfs_statfs() we cache fs_info::space_info in a local variable only > to use it once in a list_for_each_rcu() statement. > > Not only is the local variable unnecessary it even makes the code harder > to follow as it's not clear which list it is iterating. > > Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> Added to misc-next as it's not related to the statfs change itself.
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c index d5d15a19f51d..b818f764c1c9 100644 --- a/fs/btrfs/super.c +++ b/fs/btrfs/super.c @@ -2021,7 +2021,6 @@ static int btrfs_statfs(struct dentry *dentry, struct kstatfs *buf) { struct btrfs_fs_info *fs_info = btrfs_sb(dentry->d_sb); struct btrfs_super_block *disk_super = fs_info->super_copy; - struct list_head *head = &fs_info->space_info; struct btrfs_space_info *found; u64 total_used = 0; u64 total_free_data = 0; @@ -2035,7 +2034,7 @@ static int btrfs_statfs(struct dentry *dentry, struct kstatfs *buf) int mixed = 0; rcu_read_lock(); - list_for_each_entry_rcu(found, head, list) { + list_for_each_entry_rcu(found, &fs_info->space_info, list) { if (found->flags & BTRFS_BLOCK_GROUP_DATA) { int i;
In btrfs_statfs() we cache fs_info::space_info in a local variable only to use it once in a list_for_each_rcu() statement. Not only is the local variable unnecessary it even makes the code harder to follow as it's not clear which list it is iterating. Signed-off-by: Johannes Thumshirn <jthumshirn@suse.de> --- fs/btrfs/super.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)