[0/8] Face lift for st1232 touchscreen driver

Message

Dmitry Torokhov Oct. 22, 2019, 7:56 p.m. UTC

This series cleans up the driver and switches it over to the slotted
multi-touch protocol (MT-B) that should reduce the traffic between kernel
and userspace.

Note that I do not have hardware, so I would appreciate if you could try
running it and tell me if it is broken or not.

Thanks!


Dmitry Torokhov (8):
  Input: st1232 - simplify parsing of read buffer
  Input: st1232 - do not unconditionally configure as wakeup source
  Input: st1232 - rely on I2C core to configure wakeup interrupt
  Input: st1232 - do not reset the chip too early
  Input: st1232 - do not allocate fingers data separately
  Input: st1232 - do not set parent device explicitly
  Input: st1232 - note that the receive buffer is DMA-safe
  Input: st1232 - switch to using MT-B protocol

 drivers/input/touchscreen/st1232.c | 184 ++++++++++++++---------------
 1 file changed, 89 insertions(+), 95 deletions(-)

Comments

Matthias Fend Oct. 28, 2019, 7:28 a.m. UTC | #1

Hi Dmitry,

> -----Ursprüngliche Nachricht-----
> Von: Dmitry Torokhov <[e-mail]>
> Gesendet: Dienstag, 22. Oktober 2019 21:56
> An: Martin Kepplinger <[e-mail]>
> Cc: Dixit Parmar <[e-mail]>; Henrik Rydberg
> <[e-mail]>; Kuninori Morimoto
> <[e-mail]>; Matthias Fend
> <[e-mail]>; [e-mail]; linux-
> [e-mail]
> Betreff: [PATCH 0/8] Face lift for st1232 touchscreen driver
> 
> This series cleans up the driver and switches it over to the slotted
> multi-touch protocol (MT-B) that should reduce the traffic between kernel
> and userspace.
> 
> Note that I do not have hardware, so I would appreciate if you could try
> running it and tell me if it is broken or not.

Looks good. I tested the series from your st1232 branch [1] and could not see any regressions.
Note that I my 'real' application only supports ONE finger. So, the other fingers are just tested with debug output.

Thanks,
 ~Matthias

[1] git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git st1232

> 
> Thanks!
> 
> 
> Dmitry Torokhov (8):
>   Input: st1232 - simplify parsing of read buffer
>   Input: st1232 - do not unconditionally configure as wakeup source
>   Input: st1232 - rely on I2C core to configure wakeup interrupt
>   Input: st1232 - do not reset the chip too early
>   Input: st1232 - do not allocate fingers data separately
>   Input: st1232 - do not set parent device explicitly
>   Input: st1232 - note that the receive buffer is DMA-safe
>   Input: st1232 - switch to using MT-B protocol
> 
>  drivers/input/touchscreen/st1232.c | 184 ++++++++++++++---------------
>  1 file changed, 89 insertions(+), 95 deletions(-)
> 
> --
> 2.23.0.866.gb869b98d4c-goog

Dmitry Torokhov Oct. 29, 2019, 4:09 a.m. UTC | #2

On Mon, Oct 28, 2019 at 07:28:51AM +0000, Matthias Fend wrote:
> Hi Dmitry,
> 
> > -----Ursprüngliche Nachricht-----
> > Von: Dmitry Torokhov <[e-mail]>
> > Gesendet: Dienstag, 22. Oktober 2019 21:56
> > An: Martin Kepplinger <[e-mail]>
> > Cc: Dixit Parmar <[e-mail]>; Henrik Rydberg
> > <[e-mail]>; Kuninori Morimoto
> > <[e-mail]>; Matthias Fend
> > <[e-mail]>; [e-mail]; linux-
> > [e-mail]
> > Betreff: [PATCH 0/8] Face lift for st1232 touchscreen driver
> > 
> > This series cleans up the driver and switches it over to the slotted
> > multi-touch protocol (MT-B) that should reduce the traffic between kernel
> > and userspace.
> > 
> > Note that I do not have hardware, so I would appreciate if you could try
> > running it and tell me if it is broken or not.
> 
> Looks good. I tested the series from your st1232 branch [1] and could not see any regressions.
> Note that I my 'real' application only supports ONE finger. So, the other fingers are just tested with debug output.

Thank you for testing. I committed the patches.