[0/3] Add touchscreen support for TBS A711 Tablet

Message

Ondřej Jirman Oct. 29, 2019, 12:58 a.m. UTC

This is a resurrection of https://lkml.org/lkml/2018/7/25/143

Compared to v4 of Mylène's series I've dropped all attempts to
power off the chip during suspend. This patch just enables the
regulator during probe and disables it on driver rmmod.

I've tested the driver with suspend/resume and touching the
panel resumes my soc.

Please take a look.

thank you and regards,
  Ondrej Jirman


Changes since v4 of Mylène's series:
- slight whitespace improvements
- drop all modifications of suspend/resume hooks
- drop useless header include
- split the dt-bindings into a separate patch

Mylène Josserand (2):
  input: edt-ft5x06: Add support for regulator
  arm: dts: sun8i: a83t: a711: Add touchscreen node

Ondrej Jirman (1):
  dt-bindings: input: edt-ft5x06: Add regulator support

 .../bindings/input/touchscreen/edt-ft5x06.txt |  1 +
 arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts     | 16 ++++++++++
 drivers/input/touchscreen/edt-ft5x06.c        | 30 +++++++++++++++++++
 3 files changed, 47 insertions(+)

Comments

Dmitry Torokhov Oct. 29, 2019, 4:15 a.m. UTC | #1

On Tue, Oct 29, 2019 at 01:58:03AM +0100, Ondrej Jirman wrote:
> This is a resurrection of https://lkml.org/lkml/2018/7/25/143
> 
> Compared to v4 of Mylène's series I've dropped all attempts to
> power off the chip during suspend. This patch just enables the
> regulator during probe and disables it on driver rmmod.
> 
> I've tested the driver with suspend/resume and touching the
> panel resumes my soc.

OK, I guess we can revisit when someone really needs power savings in
suspend...

I folded bindings into the driver change and applied, dts changes should
go through respective tree.

Thanks.

Marco Felsch Oct. 29, 2019, 9:04 a.m. UTC | #2

Hi,

On 19-10-28 21:15, Dmitry Torokhov wrote:
> On Tue, Oct 29, 2019 at 01:58:03AM +0100, Ondrej Jirman wrote:
> > This is a resurrection of https://lkml.org/lkml/2018/7/25/143
> > 
> > Compared to v4 of Mylène's series I've dropped all attempts to
> > power off the chip during suspend. This patch just enables the
> > regulator during probe and disables it on driver rmmod.
> > 
> > I've tested the driver with suspend/resume and touching the
> > panel resumes my soc.
> 
> OK, I guess we can revisit when someone really needs power savings in
> suspend...

Please have a look on https://patchwork.kernel.org/cover/11149039/. I've
already send patches for it.

Regards,
  Marco

> I folded bindings into the driver change and applied, dts changes should
> go through respective tree.
> 
> Thanks.
> 
> -- 
> Dmitry
>