| Message ID | 20191025124508.166648-2-nuno.sa@analog.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] iio: adis16480: Fix scales factors | expand |
On Fri, 25 Oct 2019 14:45:08 +0200 Nuno Sá <nuno.sa@analog.com> wrote: > The driver is defining debugfs entries by calling > `adis16480_debugfs_init()`. However, those entries are attached to the > iio_dev debugfs entry which won't exist if no debugfs_reg_access > callback is provided. > > Signed-off-by: Nuno Sá <nuno.sa@analog.com> As you are respinning the first one and this is probably stable material as well, please add a fixes tag for v2. Thanks, Jonathan > --- > drivers/iio/imu/adis16480.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c > index 3b53bbb11bfb..94aa1c57e605 100644 > --- a/drivers/iio/imu/adis16480.c > +++ b/drivers/iio/imu/adis16480.c > @@ -921,6 +921,7 @@ static const struct iio_info adis16480_info = { > .read_raw = &adis16480_read_raw, > .write_raw = &adis16480_write_raw, > .update_scan_mode = adis_update_scan_mode, > + .debugfs_reg_access = adis_debugfs_reg_access, > }; > > static int adis16480_stop_device(struct iio_dev *indio_dev)
On Sun, 2019-10-27 at 16:37 +0000, Jonathan Cameron wrote: > On Fri, 25 Oct 2019 14:45:08 +0200 > Nuno Sá <nuno.sa@analog.com> wrote: > > > The driver is defining debugfs entries by calling > > `adis16480_debugfs_init()`. However, those entries are attached to > > the > > iio_dev debugfs entry which won't exist if no debugfs_reg_access > > callback is provided. > > > > Signed-off-by: Nuno Sá <nuno.sa@analog.com> > As you are respinning the first one and this is probably stable > material as well, please add a fixes tag for v2. > Thanks, > Will do that. Should I also cc Stable? Thanks! Nuno Sá
On Mon, 28 Oct 2019 08:25:24 +0000 "Sa, Nuno" <Nuno.Sa@analog.com> wrote: > On Sun, 2019-10-27 at 16:37 +0000, Jonathan Cameron wrote: > > On Fri, 25 Oct 2019 14:45:08 +0200 > > Nuno Sá <nuno.sa@analog.com> wrote: > > > > > The driver is defining debugfs entries by calling > > > `adis16480_debugfs_init()`. However, those entries are attached to > > > the > > > iio_dev debugfs entry which won't exist if no debugfs_reg_access > > > callback is provided. > > > > > > Signed-off-by: Nuno Sá <nuno.sa@analog.com> > > As you are respinning the first one and this is probably stable > > material as well, please add a fixes tag for v2. > > Thanks, > > > > Will do that. Should I also cc Stable? Nope, I'll add that once we are happy with it. Otherwise they'll get spammed with every version along the way. They only need to care once it hit's Linus' tree. Thanks, Jonathan > > Thanks! > Nuno Sá
On Tue, 2019-10-29 at 18:25 +0000, Jonathan Cameron wrote: > On Mon, 28 Oct 2019 08:25:24 +0000 > "Sa, Nuno" <Nuno.Sa@analog.com> wrote: > > > On Sun, 2019-10-27 at 16:37 +0000, Jonathan Cameron wrote: > > > On Fri, 25 Oct 2019 14:45:08 +0200 > > > Nuno Sá <nuno.sa@analog.com> wrote: > > > > > > > The driver is defining debugfs entries by calling > > > > `adis16480_debugfs_init()`. However, those entries are attached > > > > to > > > > the > > > > iio_dev debugfs entry which won't exist if no > > > > debugfs_reg_access > > > > callback is provided. > > > > > > > > Signed-off-by: Nuno Sá <nuno.sa@analog.com> > > > As you are respinning the first one and this is probably stable > > > material as well, please add a fixes tag for v2. > > > Thanks, > > > > > > > Will do that. Should I also cc Stable? > Nope, I'll add that once we are happy with it. Otherwise they'll > get spammed with every version along the way. They only need > to care once it hit's Linus' tree. > Ups, I already sent a v2 with stable on Cc. Sorry for that, next time I know. Nuno Sá > Thanks, > > Jonathan > > Thanks! > > Nuno Sá > >
diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c index 3b53bbb11bfb..94aa1c57e605 100644 --- a/drivers/iio/imu/adis16480.c +++ b/drivers/iio/imu/adis16480.c @@ -921,6 +921,7 @@ static const struct iio_info adis16480_info = { .read_raw = &adis16480_read_raw, .write_raw = &adis16480_write_raw, .update_scan_mode = adis_update_scan_mode, + .debugfs_reg_access = adis_debugfs_reg_access, }; static int adis16480_stop_device(struct iio_dev *indio_dev)
The driver is defining debugfs entries by calling `adis16480_debugfs_init()`. However, those entries are attached to the iio_dev debugfs entry which won't exist if no debugfs_reg_access callback is provided. Signed-off-by: Nuno Sá <nuno.sa@analog.com> --- drivers/iio/imu/adis16480.c | 1 + 1 file changed, 1 insertion(+)