| Message ID | 20191028163349.28866-2-nuno.sa@analog.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2,1/2] iio: adis16480: Fix scales factors | expand |
On Mon, 28 Oct 2019 17:33:49 +0100 Nuno Sá <nuno.sa@analog.com> wrote: > The driver is defining debugfs entries by calling > `adis16480_debugfs_init()`. However, those entries are attached to the > iio_dev debugfs entry which won't exist if no debugfs_reg_access > callback is provided. > > Fixes: 2f3abe6cbb6c ("iio:imu: Add support for the ADIS16480 and similar IMUs") > Cc: <Stable@vger.kernel.org> > > Signed-off-by: Nuno Sá <nuno.sa@analog.com> Applied to the fixes-togreg branch of iio.git. Note I dropped the cc for stable from this thread but not the patch. That should mean they pick it up from mainline once it gets there. Thanks, Jonathan > --- > Changes in v2: > * Add a Fixes tag and Cc stable. > > drivers/iio/imu/adis16480.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c > index 3b53bbb11bfb..94aa1c57e605 100644 > --- a/drivers/iio/imu/adis16480.c > +++ b/drivers/iio/imu/adis16480.c > @@ -921,6 +921,7 @@ static const struct iio_info adis16480_info = { > .read_raw = &adis16480_read_raw, > .write_raw = &adis16480_write_raw, > .update_scan_mode = adis_update_scan_mode, > + .debugfs_reg_access = adis_debugfs_reg_access, > }; > > static int adis16480_stop_device(struct iio_dev *indio_dev)
diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c index 3b53bbb11bfb..94aa1c57e605 100644 --- a/drivers/iio/imu/adis16480.c +++ b/drivers/iio/imu/adis16480.c @@ -921,6 +921,7 @@ static const struct iio_info adis16480_info = { .read_raw = &adis16480_read_raw, .write_raw = &adis16480_write_raw, .update_scan_mode = adis_update_scan_mode, + .debugfs_reg_access = adis_debugfs_reg_access, }; static int adis16480_stop_device(struct iio_dev *indio_dev)
The driver is defining debugfs entries by calling `adis16480_debugfs_init()`. However, those entries are attached to the iio_dev debugfs entry which won't exist if no debugfs_reg_access callback is provided. Fixes: 2f3abe6cbb6c ("iio:imu: Add support for the ADIS16480 and similar IMUs") Cc: <Stable@vger.kernel.org> Signed-off-by: Nuno Sá <nuno.sa@analog.com> --- Changes in v2: * Add a Fixes tag and Cc stable. drivers/iio/imu/adis16480.c | 1 + 1 file changed, 1 insertion(+)