| Message ID | 20191021164200.31051-1-l.stach@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: zii-ultra: add i210 ethernet node | expand |
On Mon, Oct 21, 2019 at 06:42:00PM +0200, Lucas Stach wrote: > Used by the bootloader to patch in the correct MAC address for > the ethernet adapter. > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > --- > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi > index 087b5b6ebe89..7933c685fe6a 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi > @@ -475,6 +475,17 @@ > <&pcie1_refclk>; > clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; > status = "okay"; > + > + host@0 { Where is the bindings documenting this child node of pcie device? > + reg = <0 0 0 0 0>; > + > + #address-cells = <3>; > + #size-cells = <2>; > + > + i210: i210@0 { Can we have generic node name for it? Shawn > + reg = <0 0 0 0 0>; > + }; > + }; > }; > > &pgc_gpu { > -- > 2.20.1 >
On Mo, 2019-10-28 at 14:15 +0800, Shawn Guo wrote: > On Mon, Oct 21, 2019 at 06:42:00PM +0200, Lucas Stach wrote: > > Used by the bootloader to patch in the correct MAC address for > > the ethernet adapter. > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > --- > > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 11 > > +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi > > b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi > > index 087b5b6ebe89..7933c685fe6a 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi > > @@ -475,6 +475,17 @@ > > <&pcie1_refclk>; > > clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; > > status = "okay"; > > + > > + host@0 { > > Where is the bindings documenting this child node of pcie device? This is part of the "PCI Bus Binding to: IEEE Std 1275-1994" document, which is referenced in Documentation/devicetree/bindings/pci/pci.txt. This is a standard PCIe topology description mapped to DT. > > + reg = <0 0 0 0 0>; > > + > > + #address-cells = <3>; > > + #size-cells = <2>; > > + > > + i210: i210@0 { > > Can we have generic node name for it? I would like to avoid this if possible. We are sharing the code to patch in the MAC address from the bootloader with the RDU2, which has the same node name and the patching code looks for the specific name. Regards, Lucas > Shawn > > > + reg = <0 0 0 0 0>; > > + }; > > + }; > > }; > > > > &pgc_gpu { > > -- > > 2.20.1 > >
On Wed, Oct 30, 2019 at 05:44:27PM +0100, Lucas Stach wrote: > On Mo, 2019-10-28 at 14:15 +0800, Shawn Guo wrote: > > On Mon, Oct 21, 2019 at 06:42:00PM +0200, Lucas Stach wrote: > > > Used by the bootloader to patch in the correct MAC address for > > > the ethernet adapter. > > > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de> > > > --- > > > arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 11 > > > +++++++++++ > > > 1 file changed, 11 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi > > > b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi > > > index 087b5b6ebe89..7933c685fe6a 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi > > > @@ -475,6 +475,17 @@ > > > <&pcie1_refclk>; > > > clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; > > > status = "okay"; > > > + > > > + host@0 { > > > > Where is the bindings documenting this child node of pcie device? > > This is part of the "PCI Bus Binding to: IEEE Std 1275-1994" document, > which is referenced in Documentation/devicetree/bindings/pci/pci.txt. > This is a standard PCIe topology description mapped to DT. Please resend the patch to include DT and PCI folks and list. Shawn > > > > + reg = <0 0 0 0 0>; > > > + > > > + #address-cells = <3>; > > > + #size-cells = <2>; > > > + > > > + i210: i210@0 { > > > > Can we have generic node name for it? > > I would like to avoid this if possible. We are sharing the code to > patch in the MAC address from the bootloader with the RDU2, which has > the same node name and the patching code looks for the specific name. > > Regards, > Lucas > > > Shawn > > > > > + reg = <0 0 0 0 0>; > > > + }; > > > + }; > > > }; > > > > > > &pgc_gpu { > > > -- > > > 2.20.1 > > > >
diff --git a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi index 087b5b6ebe89..7933c685fe6a 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi @@ -475,6 +475,17 @@ <&pcie1_refclk>; clock-names = "pcie", "pcie_aux", "pcie_phy", "pcie_bus"; status = "okay"; + + host@0 { + reg = <0 0 0 0 0>; + + #address-cells = <3>; + #size-cells = <2>; + + i210: i210@0 { + reg = <0 0 0 0 0>; + }; + }; }; &pgc_gpu {
Used by the bootloader to patch in the correct MAC address for the ethernet adapter. Signed-off-by: Lucas Stach <l.stach@pengutronix.de> --- arch/arm64/boot/dts/freescale/imx8mq-zii-ultra.dtsi | 11 +++++++++++ 1 file changed, 11 insertions(+)