mbox series

[kvm-unit-tests,v2,0/5] s390x: SCLP Unit test

Message ID 1572023194-14370-1-git-send-email-imbrenda@linux.ibm.com (mailing list archive)
Headers show
Series s390x: SCLP Unit test | expand

Message

Claudio Imbrenda Oct. 25, 2019, 5:06 p.m. UTC
This patchset contains some minor cleanup, some preparatory work and
then the SCLP unit test itself.

The unit test checks the following:
    
    * Correctly ignoring instruction bits that should be ignored
    * Privileged instruction check
    * Check for addressing exceptions
    * Specification exceptions:
      - SCCB size less than 8
      - SCCB unaligned
      - SCCB overlaps prefix or lowcore
      - SCCB address higher than 2GB
    * Return codes for
      - Invalid command
      - SCCB too short (but at least 8)
      - SCCB page boundary violation

v1 -> v2
* fix many small issues that came up during the first round of reviews
* add comments to each function
* use a static buffer for the SCCP template when used

Claudio Imbrenda (5):
  s390x: remove redundant defines
  s390x: improve error reporting for interrupts
  s390x: sclp: expose ram_size and max_ram_size
  s390x: sclp: add service call instruction wrapper
  s390x: SCLP unit test

 s390x/Makefile           |   1 +
 lib/s390x/asm/arch_def.h |  13 ++
 lib/s390x/sclp.h         |   4 +-
 lib/s390x/interrupt.c    |   4 +-
 lib/s390x/sclp.c         |  17 +-
 s390x/sclp.c             | 413 +++++++++++++++++++++++++++++++++++++++++++++++
 s390x/unittests.cfg      |   3 +
 7 files changed, 445 insertions(+), 10 deletions(-)
 create mode 100644 s390x/sclp.c

Comments

David Hildenbrand Nov. 4, 2019, 10:10 a.m. UTC | #1
On 25.10.19 19:06, Claudio Imbrenda wrote:
> This patchset contains some minor cleanup, some preparatory work and
> then the SCLP unit test itself.
> 
> The unit test checks the following:
>      
>      * Correctly ignoring instruction bits that should be ignored
>      * Privileged instruction check
>      * Check for addressing exceptions
>      * Specification exceptions:
>        - SCCB size less than 8
>        - SCCB unaligned
>        - SCCB overlaps prefix or lowcore
>        - SCCB address higher than 2GB
>      * Return codes for
>        - Invalid command
>        - SCCB too short (but at least 8)
>        - SCCB page boundary violation
> 
> v1 -> v2
> * fix many small issues that came up during the first round of reviews
> * add comments to each function
> * use a static buffer for the SCCP template when used
> 
> Claudio Imbrenda (5):
>    s390x: remove redundant defines
>    s390x: improve error reporting for interrupts
>    s390x: sclp: expose ram_size and max_ram_size
>    s390x: sclp: add service call instruction wrapper
>    s390x: SCLP unit test

Queued patch 1-3 to

https://github.com/davidhildenbrand/kvm-unit-tests.git s390x-next

Thanks!