| Message ID | 20191013121538.1782436-1-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: adc: mt6577_auxdac: use devm_platform_ioremap_resource | expand |
On Sun, 2019-10-13 at 13:15 +0100, jic23@kernel.org wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Reduces boilerplate. Identified by coccinelle > > CHECK drivers/iio/adc/mt6577_auxadc.c > drivers/iio/adc/mt6577_auxadc.c:257:1-18: WARNING: Use > devm_platform_ioremap_resource for adc_dev -> reg_base > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Zhiyong Tao <zhiyong.tao@mediatek.com> > --- > drivers/iio/adc/mt6577_auxadc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/mt6577_auxadc.c > b/drivers/iio/adc/mt6577_auxadc.c > index 7bbb64ca3b32..a4776d924f3a 100644 > --- a/drivers/iio/adc/mt6577_auxadc.c > +++ b/drivers/iio/adc/mt6577_auxadc.c > @@ -237,7 +237,6 @@ static int mt6577_auxadc_probe(struct platform_device > *pdev) > { > struct mt6577_auxadc_device *adc_dev; > unsigned long adc_clk_rate; > - struct resource *res; > struct iio_dev *indio_dev; > int ret; > > @@ -253,8 +252,7 @@ static int mt6577_auxadc_probe(struct platform_device > *pdev) > indio_dev->channels = mt6577_auxadc_iio_channels; > indio_dev->num_channels = ARRAY_SIZE(mt6577_auxadc_iio_channels); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res); > + adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0); > if (IS_ERR(adc_dev->reg_base)) { > dev_err(&pdev->dev, "failed to get auxadc base address\n"); > return PTR_ERR(adc_dev->reg_base);
On Mon, 4 Nov 2019 15:14:32 +0000 "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote: > On Sun, 2019-10-13 at 13:15 +0100, jic23@kernel.org wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > Reduces boilerplate. Identified by coccinelle > > > > CHECK drivers/iio/adc/mt6577_auxadc.c > > drivers/iio/adc/mt6577_auxadc.c:257:1-18: WARNING: Use > > devm_platform_ioremap_resource for adc_dev -> reg_base > > > > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com> Applied. Thanks, Jonathan > > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Zhiyong Tao <zhiyong.tao@mediatek.com> > > --- > > drivers/iio/adc/mt6577_auxadc.c | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/drivers/iio/adc/mt6577_auxadc.c > > b/drivers/iio/adc/mt6577_auxadc.c > > index 7bbb64ca3b32..a4776d924f3a 100644 > > --- a/drivers/iio/adc/mt6577_auxadc.c > > +++ b/drivers/iio/adc/mt6577_auxadc.c > > @@ -237,7 +237,6 @@ static int mt6577_auxadc_probe(struct platform_device > > *pdev) > > { > > struct mt6577_auxadc_device *adc_dev; > > unsigned long adc_clk_rate; > > - struct resource *res; > > struct iio_dev *indio_dev; > > int ret; > > > > @@ -253,8 +252,7 @@ static int mt6577_auxadc_probe(struct platform_device > > *pdev) > > indio_dev->channels = mt6577_auxadc_iio_channels; > > indio_dev->num_channels = ARRAY_SIZE(mt6577_auxadc_iio_channels); > > > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > - adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res); > > + adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0); > > if (IS_ERR(adc_dev->reg_base)) { > > dev_err(&pdev->dev, "failed to get auxadc base address\n"); > > return PTR_ERR(adc_dev->reg_base);
diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c index 7bbb64ca3b32..a4776d924f3a 100644 --- a/drivers/iio/adc/mt6577_auxadc.c +++ b/drivers/iio/adc/mt6577_auxadc.c @@ -237,7 +237,6 @@ static int mt6577_auxadc_probe(struct platform_device *pdev) { struct mt6577_auxadc_device *adc_dev; unsigned long adc_clk_rate; - struct resource *res; struct iio_dev *indio_dev; int ret; @@ -253,8 +252,7 @@ static int mt6577_auxadc_probe(struct platform_device *pdev) indio_dev->channels = mt6577_auxadc_iio_channels; indio_dev->num_channels = ARRAY_SIZE(mt6577_auxadc_iio_channels); - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - adc_dev->reg_base = devm_ioremap_resource(&pdev->dev, res); + adc_dev->reg_base = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(adc_dev->reg_base)) { dev_err(&pdev->dev, "failed to get auxadc base address\n"); return PTR_ERR(adc_dev->reg_base);