Message ID | 20191104151323.9883-1-crosa@redhat.com (mailing list archive) |
---|---|
Headers | show |
Series | Acceptance test: Add "boot_linux" acceptance test | expand |
Patchew URL: https://patchew.org/QEMU/20191104151323.9883-1-crosa@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [PATCH v7 0/8] Acceptance test: Add "boot_linux" acceptance test Type: series Message-id: 20191104151323.9883-1-crosa@redhat.com === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 8675afa Acceptance test: add "boot_linux" tests 409affc Acceptance tests: depend on qemu-img 58c0f47 Acceptance tests: add the build directory to the system PATH 236ecfa Acceptance tests: keep a stable reference to the QEMU build dir 6a147b4 Acceptance tests: use relative location for tests bcd92a3 Acceptance tests: use avocado tags for machine type 0f52135 Acceptance tests: introduce utility method for tags unique vals 050f1d1 Acceptance test x86_cpu_model_versions: use default vm === OUTPUT BEGIN === 1/8 Checking commit 050f1d1ea660 (Acceptance test x86_cpu_model_versions: use default vm) ERROR: line over 90 characters #47: FILE: tests/acceptance/x86_cpu_model_versions.py:248: + self.vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #61: FILE: tests/acceptance/x86_cpu_model_versions.py:256: + self.vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #76: FILE: tests/acceptance/x86_cpu_model_versions.py:265: + self.vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off,+arch-capabilities') ERROR: line over 90 characters #90: FILE: tests/acceptance/x86_cpu_model_versions.py:273: + self.vm.add_args('-cpu', 'Cascadelake-Server,x-force-features=on,check=off,enforce=off,-arch-capabilities') ERROR: line over 90 characters #105: FILE: tests/acceptance/x86_cpu_model_versions.py:282: + self.vm.add_args('-cpu', 'Cascadelake-Server-v1,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #120: FILE: tests/acceptance/x86_cpu_model_versions.py:290: + self.vm.add_args('-cpu', 'Cascadelake-Server-v2,x-force-features=on,check=off,enforce=off') ERROR: line over 90 characters #123: FILE: tests/acceptance/x86_cpu_model_versions.py:293: + 'pc-i440fx-4.0 + Cascadelake-Server-v2 should have arch-capabilities') ERROR: line over 90 characters #136: FILE: tests/acceptance/x86_cpu_model_versions.py:299: + self.vm.add_args('-cpu', 'Cascadelake-Server-v1,x-force-features=on,check=off,enforce=off,+arch-capabilities') ERROR: line over 90 characters #139: FILE: tests/acceptance/x86_cpu_model_versions.py:302: + 'pc-i440fx-4.0 + Cascadelake-Server-v1,+arch-capabilities should have arch-capabilities') ERROR: line over 90 characters #150: FILE: tests/acceptance/x86_cpu_model_versions.py:307: + self.vm.add_args('-cpu', 'Cascadelake-Server-v2,x-force-features=on,check=off,enforce=off,-arch-capabilities') total: 10 errors, 0 warnings, 134 lines checked Patch 1/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 2/8 Checking commit 0f5213583c78 (Acceptance tests: introduce utility method for tags unique vals) 3/8 Checking commit bcd92a334692 (Acceptance tests: use avocado tags for machine type) WARNING: line over 80 characters #59: FILE: tests/acceptance/avocado_qemu/__init__.py:119: + default=self._get_unique_tag_val('machine')) total: 0 errors, 1 warnings, 450 lines checked Patch 3/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 4/8 Checking commit 6a147b4b2eb1 (Acceptance tests: use relative location for tests) 5/8 Checking commit 236ecfa68ee0 (Acceptance tests: keep a stable reference to the QEMU build dir) ERROR: line over 90 characters #48: FILE: tests/acceptance/avocado_qemu/__init__.py:19: +SRC_ROOT_DIR = os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(__file__)))) total: 1 errors, 0 warnings, 8 lines checked Patch 5/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 6/8 Checking commit 58c0f475d5ec (Acceptance tests: add the build directory to the system PATH) 7/8 Checking commit 409affc034ce (Acceptance tests: depend on qemu-img) 8/8 Checking commit 8675afa0dead (Acceptance test: add "boot_linux" tests) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #42: new file mode 100644 WARNING: line over 80 characters #122: FILE: tests/acceptance/boot_linux.py:76: + console_drainer = datadrainer.LineLogger(self.vm.console_socket.fileno(), WARNING: line over 80 characters #123: FILE: tests/acceptance/boot_linux.py:77: + logger=self.log.getChild('console')) WARNING: line over 80 characters #126: FILE: tests/acceptance/boot_linux.py:80: + cloudinit.wait_for_phone_home(('0.0.0.0', self.phone_home_port), self.name) total: 0 errors, 4 warnings, 179 lines checked Patch 8/8 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20191104151323.9883-1-crosa@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Hi Cleber, On 11/4/19 1:13 PM, Cleber Rosa wrote: > This acceptance test, validates that a full blown Linux guest can > successfully boot in QEMU. In this specific case, the guest chosen is > Fedora version 31. > > * x86_64, pc and q35 machine types, with and without kvm as an > accellerator > > * aarch64 and virt machine type, with and without kvm as an > accellerator > > * ppc64 and pseries machine type > > * s390x and s390-ccw-virtio machine type > > This has been tested on x86_64 and ppc64le hosts and has been running > reliably (in my experience) on Travis CI. > > Some hopefully useful pointers for reviewers: > ============================================= > > Git Info: > - URI: https://github.com/clebergnu/qemu/tree/test_boot_linux_v7 > - Remote: https://github.com/clebergnu/qemu > - Branch: test_boot_linux_v7 > > Travis CI Info: > - Build: https://travis-ci.org/clebergnu/qemu/builds/606191094 > - Job: https://travis-ci.org/clebergnu/qemu/jobs/606191120 > > Previous version: > - v6: https://lists.gnu.org/archive/html/qemu-devel/2019-06/msg01202.html > - v5: https://lists.gnu.org/archive/html/qemu-devel/2019-03/msg04652.html > - v4: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg02032.html > - v3: https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01677.html > - v2: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04318.html > - v1: http://lists.nongnu.org/archive/html/qemu-devel/2018-09/msg02530.html > > Changes from v6: > ================ > > * Bumped Fedora to most recently released version (31). > > * Included new architectures (ppc64 and s390x), consolidating all > tests into the same commit. > > * New commit: "Acceptance tests: use avocado tags for machine type" > > * New commit: "Acceptance tests: introduce utility method for tags > unique vals" It seems 02 and 03 are re-sending of patches originally sent in the series with Message-Id: 20190924194501.9303-1-crosa@redhat.com. On the original thread you can find my reviews. - Wainer > > * New commit: "Acceptance test x86_cpu_model_versions: use default > vm", needed to normalize the use of the machine type tags > > * Added a lot of leniency to the test setup (and reliability to the > test/job), canceling the test if there are any failures while > downloading/preparing the boot images. > > * Made use of Avocado's data drainer a regular feature (dropped the > commit with RFC) and squashed it. > > * Bumped pycdlib version to 1.8.0 > > * Dropped explicit "--enable-slirp=git" (added on v5) to Travis CI > configure line, as the default configuration on Travis CI now > results in user networking capabilities. > > Changes from v5: > ================ > > * Added explicit "--enable-slirp=git" to Travis CI configure line, as > these tests depend on "-netdev user" like networking. > > * Bumped Fedora to most recently released version (30). > > * Changed "checksum" parameter to 'sha256' and use the same hashes as > provided by the Fedora project (instead of using Avocado's default > sha1 and compute and use a different hash value). > > * New commit: Add "boot_linux" test for aarch64 and virt machine type > > * New commit: [RFC]: use Avocado data drainer for console logging > > Changes from v4: > ================ > > * New commit "Acceptance tests: use relative location for tests" > > * New commit "Acceptance tests: keep a stable reference to the QEMU build dir" > > * Pinned the Fedora 29 image by adding a checksum. The goal is to > never allow more than one component to change at a time (the one > allowed to change is QEMU itself). Updates to the image should be > manual. (Based on comments from Cornelia) > > * Moved the downloading of the Fedora 29 cloud image to the test > setUp() method, canceling the test if the image can not be > downloaded. > > * Removed the ":avocado: enable" tag, given that Avocado versions > 68.0 and later operate on a "recursive by default" manner, that > is able to correctly identify this as an Avocado test. > > Changes from v3: > ================ > > * New patch "Acceptance tests: depend on qemu-img" > > Known Issues on v3 (no longer applicable): > ========================================== > > * A recent TCG performance regression[1] affects this test in a > number of ways: > - The test execution may timeout by itself > - The generation of SSH host keys in the guest's first boot is also > affected (possibly also a timeout) > - The cloud-init "phone home" feature attempts to read the host keys > and fails, causing the test to timeout and fail > > These are not observed anymore once the fix[2] is applied. > > [1] - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00338.html > [2] - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg01129.html > > Changes from v2: > ================ > > * Updated the tag to include the "arch:" key, in a similar fashion as to > the tests in the "Acceptance Tests: target architecture support": > - https://lists.gnu.org/archive/html/qemu-devel/2019-02/msg00369.html > > * Renamed the test method name to test_x86_64_pc, again, similarly to the > boot_linux_console.py tests in the series mentioned before. > > * Set the machine type explicitly, again similarly to the > boot_linux_console.py tests in the series mentioned before. > > * Added messages after the launch of the VM, to let test runners know > the test know waits for a boot confirmation from the the guest (Eduardo). > > * Updated commit message to reflect the fact that this version does > not allow for parameterization of the guest OS, version, etc. > > * Dropped the RFC prefix on patch "RFC: Acceptance tests: add the > build directory to the system PATH" > > * Changed the comments on "RFC: Acceptance tests: add the build > directory to the system PATH" to make it clear the addition of a > the build directory to the PATH may influence other utility code. > > Changes from v1: > ================ > > * The commit message was adjusted, removing the reference to the > avocado.utils.vmimage encoding issue on previous Avocado versions > (<= 64.0) and the fix that would (and was) included in Avocado > version 65.0. > > * Effectively added pycdlib==1.6.0 to the requirements.txt file, > added on a56931eef3, and adjusted the commit message was also > to reflect that. > > * Updated the default version of the guest OS, from Fedora 28 to 29. > Besides possible improvements in the (virtual) hardware coverage, > it brings a performance improvement in the order of 20% to the > test. > > * Removed all direct parameters usage. Because some parameters and > its default values implemented in the test would prevent it from > running on some environments. Example: the "accel" parameter had a > default value of "kvm", which would prevent this test, that boots a > x86_64 OS, from running on a host arch different than x86_64. I > recognize that it's desirable to make tests reusable and > parameterized (that was the reason for the first version doing so), > but the mechanism to be used to define the architectures that a > given test should support is still an open issue, and has been > discussed in other threads. I'll follow up those discussions with > a proposal, and until then, removing those aspects from this test > implementation seemed to be the best option. A caveat: this test > currently adds the same tag (x86_64) and follows other assumptions > made on "boot_linux_console.py", that is, that a x86_64 target > binary will be used to run it. If a user is in an environment that > does not have a x86_64 target binary, it could filter those tests > out with: "avocado run --filter-by-tags='-x86_64' tests/acceptance". > > * Removed most arguments to the QEMU command line for pretty much the > same reasons described above, and by following the general > perception that I could grasp from other discussions that QEMU > defaults should preferrably be used. This test, as well as others, > can and should be extended later to allow for different test > scenarios by passing well documented parameter values. That is, > they should respect well-known parameters such as "accel" mentioned > above, so that the same test can run with KVM or TCG. > > * Changed the value of the memory argument to 1024, which based on > my experimentations and observations is the minimum amount of RAM > for the Fedora 29 cloud image to sucessfully boot on QEMU. I know > there's no such thing as a "one size fits all", specially for QEMU, > but this makes me wonder wether a x86_64 machine type shouldn't > have its default_ram_size bumped to a number practical enough to > run modern operating systems. > > * Added a new patch "RFC: Acceptance tests: add the build directory > to the system PATH", which is supposed to gather feedback on how to > enable the use of built binaries, such as qemu-img, to code used by > the test code. The specific situation here is that the vmimage, > part of the avocado.utils libraries, makes use of qemu-img to create > snapshot files. Even though we could require qemu-img to be installed > as a dependency of tests, system wide, it actually goes against the > goal of testing all QEMU things from the source/build tree. This > became aparent with tests running on environments such as Travis CI, > which don't necessarily have qemu-img available elsewhere. > > Cleber Rosa (8): > Acceptance test x86_cpu_model_versions: use default vm > Acceptance tests: introduce utility method for tags unique vals > Acceptance tests: use avocado tags for machine type > Acceptance tests: use relative location for tests > Acceptance tests: keep a stable reference to the QEMU build dir > Acceptance tests: add the build directory to the system PATH > Acceptance tests: depend on qemu-img > Acceptance test: add "boot_linux" tests > > docs/devel/testing.rst | 18 +++ > tests/Makefile.include | 4 +- > tests/acceptance/avocado_qemu/__init__.py | 32 +++- > tests/acceptance/boot_linux.py | 175 +++++++++++++++++++++ > tests/acceptance/boot_linux_console.py | 19 +-- > tests/acceptance/cpu_queries.py | 2 +- > tests/acceptance/linux_initrd.py | 2 +- > tests/acceptance/linux_ssh_mips_malta.py | 5 - > tests/acceptance/machine_m68k_nextcube.py | 21 +-- > tests/acceptance/machine_sparc_leon3.py | 3 +- > tests/acceptance/ppc_prep_40p.py | 3 - > tests/acceptance/x86_cpu_model_versions.py | 137 +++++++++------- > tests/requirements.txt | 1 + > 13 files changed, 308 insertions(+), 114 deletions(-) > create mode 100644 tests/acceptance/boot_linux.py >