| Message ID | 20191029112700.14548-2-srinivas.kandagatla@linaro.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | ASoC: Add support to WCD9340/WCD9341 codec | expand |
On Tue, Oct 29, 2019 at 11:26:50AM +0000, Srinivas Kandagatla wrote: > This patch adds bindings for wcd9340/wcd9341 audio codec which can > support both SLIMbus and I2S/I2C interface. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > .../bindings/sound/qcom,wcd934x.yaml | 162 ++++++++++++++++++ > 1 file changed, 162 insertions(+) > create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml > > diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml > new file mode 100644 > index 000000000000..d6cfde6597db > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml > @@ -0,0 +1,162 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/qcom,wcd934x.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Bindings for Qualcomm WCD9340/WCD9341 Audio Codec > + > +maintainers: > + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > + > +description: | > + Qualcomm WCD9340/WCD9341 Codec is a standalone Hi-Fi audio codec IC. > + It has in-built Soundwire controller, pin controller, interrupt mux and > + supports both I2S/I2C and SLIMbus audio interfaces. > + > +properties: > + compatible: > + const: slim217,250 > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + reset-gpios: > + description: GPIO spec for reset line to use > + maxItems: 1 > + > + slim-ifc-dev: > + description: SLIMBus Interface device phandle > + $ref: '/schemas/types.yaml#/definitions/phandle' > + maxItems: 1 Replied on previous version. > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: extclk > + > + vdd-buck-supply: > + description: A reference to the 1.8V buck supply > + > + vdd-buck-sido-supply: > + description: A reference to the 1.8V SIDO buck supply > + > + vdd-rx-supply: > + description: A reference to the 1.8V rx supply > + > + vdd-tx-supply: > + description: A reference to the 1.8V tx supply > + > + vdd-vbat-supply: > + description: A reference to the vbat supply > + > + vdd-io-supply: > + description: A reference to the 1.8V I/O supply > + > + vdd-micbias-supply: > + description: A reference to the micbias supply > + > + qcom,micbias1-microvolts: The standard unit is 'microvolt', not 'microvolts'. > + description: micbias1 voltage between 1800000 - 2850000 microvolts > + > + qcom,micbias2-microvolts: > + description: micbias2 voltage between 1800000 - 2850000 microvolts > + > + qcom,micbias3-microvolts: > + description: micbias3 voltage between 1800000 - 2850000 microvolts > + > + qcom,micbias4-microvolts: > + description: micbias4 voltage between 1800000 - 2850000 microvolts > + > + clock-output-names: > + const: mclk > + > + clock-frequency: > + description: Clock frequency of output clk in Hz > + > + interrupt-controller: true > + > + '#interrupt-cells': > + const: 1 > + > + '#clock-cells': > + const: 0 > + > + '#sound-dai-cells': > + const: 1 > + > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > +patternProperties: > + "^.*@[0-9a-f]+$": > + type: object > + description: | > + WCD934x subnode for each slave devices. Bindings of each subnodes > + depends on the specific driver providing the functionality and > + documented in their respective bindings. > + > + properties: > + reg: > + maxItems: 1 > + > + required: > + - reg > + > +required: > + - compatible > + - reg > + - reset-gpios > + - slim-ifc-dev > + - interrupts > + - interrupt-controller > + - clock-frequency > + - clock-output-names > + - qcom,micbias1-microvolts > + - qcom,micbias2-microvolts > + - qcom,micbias3-microvolts > + - qcom,micbias4-microvolts > + - "#interrupt-cells" > + - "#clock-cells" > + - "#sound-dai-cells" > + - "#address-cells" > + - "#size-cells" > + > +examples: > + - | > + codec@1,0{ > + compatible = "slim217,250"; > + reg = <1 0>; > + reset-gpios = <&tlmm 64 0>; > + slim-ifc-dev = <&wcd9340_ifd>; > + #sound-dai-cells = <1>; > + interrupt-parent = <&tlmm>; > + interrupts = <54 4>; > + interrupt-controller; > + #interrupt-cells = <1>; > + #clock-cells = <0>; > + clock-frequency = <9600000>; > + clock-output-names = "mclk"; > + qcom,micbias1-microvolts = <1800000>; > + qcom,micbias2-microvolts = <1800000>; > + qcom,micbias3-microvolts = <1800000>; > + qcom,micbias4-microvolts = <1800000>; > + clock-names = "extclk"; > + clocks = <&rpmhcc 2>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + > + pinctrl@42 { > + reg = <0x42 0x2>; > + }; > + }; > + > +... > -- > 2.21.0 >
On 05/11/2019 19:31, Rob Herring wrote: >> + vdd-micbias-supply: >> + description: A reference to the micbias supply >> + >> + qcom,micbias1-microvolts: > The standard unit is 'microvolt', not 'microvolts'. > I started with microvolt but dt_bindings_check reported errors. looking at https://github.com/devicetree-org/dt-schema/blob/master/meta-schemas/vendor-props.yaml#L19 suggested microvolts should be used on vendor properties. Is this a typo in dt-schema ? thanks, --srini
On Wed, Nov 6, 2019 at 4:08 AM Srinivas Kandagatla <srinivas.kandagatla@linaro.org> wrote: > > > > On 05/11/2019 19:31, Rob Herring wrote: > >> + vdd-micbias-supply: > >> + description: A reference to the micbias supply > >> + > >> + qcom,micbias1-microvolts: > > The standard unit is 'microvolt', not 'microvolts'. > > > I started with microvolt but dt_bindings_check reported errors. > > looking at > https://github.com/devicetree-org/dt-schema/blob/master/meta-schemas/vendor-props.yaml#L19 > suggested microvolts should be used on vendor properties. > > Is this a typo in dt-schema ? Yes, even the DT maintainer gets confused. :) It's fixed now. Rob
diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml new file mode 100644 index 000000000000..d6cfde6597db --- /dev/null +++ b/Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml @@ -0,0 +1,162 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/sound/qcom,wcd934x.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Bindings for Qualcomm WCD9340/WCD9341 Audio Codec + +maintainers: + - Srinivas Kandagatla <srinivas.kandagatla@linaro.org> + +description: | + Qualcomm WCD9340/WCD9341 Codec is a standalone Hi-Fi audio codec IC. + It has in-built Soundwire controller, pin controller, interrupt mux and + supports both I2S/I2C and SLIMbus audio interfaces. + +properties: + compatible: + const: slim217,250 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + reset-gpios: + description: GPIO spec for reset line to use + maxItems: 1 + + slim-ifc-dev: + description: SLIMBus Interface device phandle + $ref: '/schemas/types.yaml#/definitions/phandle' + maxItems: 1 + + clocks: + maxItems: 1 + + clock-names: + const: extclk + + vdd-buck-supply: + description: A reference to the 1.8V buck supply + + vdd-buck-sido-supply: + description: A reference to the 1.8V SIDO buck supply + + vdd-rx-supply: + description: A reference to the 1.8V rx supply + + vdd-tx-supply: + description: A reference to the 1.8V tx supply + + vdd-vbat-supply: + description: A reference to the vbat supply + + vdd-io-supply: + description: A reference to the 1.8V I/O supply + + vdd-micbias-supply: + description: A reference to the micbias supply + + qcom,micbias1-microvolts: + description: micbias1 voltage between 1800000 - 2850000 microvolts + + qcom,micbias2-microvolts: + description: micbias2 voltage between 1800000 - 2850000 microvolts + + qcom,micbias3-microvolts: + description: micbias3 voltage between 1800000 - 2850000 microvolts + + qcom,micbias4-microvolts: + description: micbias4 voltage between 1800000 - 2850000 microvolts + + clock-output-names: + const: mclk + + clock-frequency: + description: Clock frequency of output clk in Hz + + interrupt-controller: true + + '#interrupt-cells': + const: 1 + + '#clock-cells': + const: 0 + + '#sound-dai-cells': + const: 1 + + "#address-cells": + const: 1 + + "#size-cells": + const: 1 + +patternProperties: + "^.*@[0-9a-f]+$": + type: object + description: | + WCD934x subnode for each slave devices. Bindings of each subnodes + depends on the specific driver providing the functionality and + documented in their respective bindings. + + properties: + reg: + maxItems: 1 + + required: + - reg + +required: + - compatible + - reg + - reset-gpios + - slim-ifc-dev + - interrupts + - interrupt-controller + - clock-frequency + - clock-output-names + - qcom,micbias1-microvolts + - qcom,micbias2-microvolts + - qcom,micbias3-microvolts + - qcom,micbias4-microvolts + - "#interrupt-cells" + - "#clock-cells" + - "#sound-dai-cells" + - "#address-cells" + - "#size-cells" + +examples: + - | + codec@1,0{ + compatible = "slim217,250"; + reg = <1 0>; + reset-gpios = <&tlmm 64 0>; + slim-ifc-dev = <&wcd9340_ifd>; + #sound-dai-cells = <1>; + interrupt-parent = <&tlmm>; + interrupts = <54 4>; + interrupt-controller; + #interrupt-cells = <1>; + #clock-cells = <0>; + clock-frequency = <9600000>; + clock-output-names = "mclk"; + qcom,micbias1-microvolts = <1800000>; + qcom,micbias2-microvolts = <1800000>; + qcom,micbias3-microvolts = <1800000>; + qcom,micbias4-microvolts = <1800000>; + clock-names = "extclk"; + clocks = <&rpmhcc 2>; + + #address-cells = <1>; + #size-cells = <1>; + + pinctrl@42 { + reg = <0x42 0x2>; + }; + }; + +...
This patch adds bindings for wcd9340/wcd9341 audio codec which can support both SLIMbus and I2S/I2C interface. Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- .../bindings/sound/qcom,wcd934x.yaml | 162 ++++++++++++++++++ 1 file changed, 162 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd934x.yaml