| Message ID | 20191105225751.1233-1-briannorris@chromium.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | crda: Makefile: fix .so compilation line with some compilers | expand |
On Tue, Nov 5, 2019 at 2:57 PM Brian Norris <briannorris@chromium.org> wrote: > > Write the CC rule such that it only tries to produce a single output > file (the .so). When including the .h files in the compiler invocation, > this suggests we should be producing pre-compiled headers too, which > doesn't make sense in this context, and Clang happens not to like. > > Signed-off-by: Brian Norris <briannorris@chromium.org> > --- Apparently wireless-regdb@ is subscribers only. I have since joined, but I guess my patch bounced from that list... if I don't hear back in a while, I may resend. Brian > Yes, I know CRDA is deprecated. > > Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile b/Makefile > index 6169b1f307da..6ca26f341dfa 100644 > --- a/Makefile > +++ b/Makefile > @@ -114,9 +114,9 @@ keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem) > $(NQ) ' Trusted pubkeys:' $(wildcard $(PUBKEY_DIR)/*.pem) > $(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@ > > -$(LIBREG): regdb.h reglib.h reglib.c > +$(LIBREG): reglib.c regdb.h reglib.h > $(NQ) ' CC ' $@ > - $(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $^ > + $(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $< > > install-libreg-headers: > $(NQ) ' INSTALL libreg-headers' > -- > 2.24.0.rc1.363.gb1bccd3e3d-goog >
On Tue, 2019-11-05 at 15:02 -0800, Brian Norris wrote: > On Tue, Nov 5, 2019 at 2:57 PM Brian Norris <briannorris@chromium.org> wrote: > > Write the CC rule such that it only tries to produce a single output > > file (the .so). When including the .h files in the compiler invocation, > > this suggests we should be producing pre-compiled headers too, which > > doesn't make sense in this context, and Clang happens not to like. > > > > Signed-off-by: Brian Norris <briannorris@chromium.org> > > --- > > Apparently wireless-regdb@ is subscribers only. I have since joined, > but I guess my patch bounced from that list... if I don't hear back in > a while, I may resend. The bigger question is who actually maintains crda now, if anyone ... :) johannes
On Wed, Nov 6, 2019 at 12:12 AM Johannes Berg <johannes@sipsolutions.net> wrote: > On Tue, 2019-11-05 at 15:02 -0800, Brian Norris wrote: > > Apparently wireless-regdb@ is subscribers only. I have since joined, > > but I guess my patch bounced from that list... if I don't hear back in > > a while, I may resend. > > The bigger question is who actually maintains crda now, if anyone ... :) My mailbox tells me that as of about a year ago, Luis was still merging patches. And his latest commit even claims it's "still maintained": As if kernel v4.15 CRDA is no longer needed. Annotate this. The code will still be maintained to help older kernels. Brian
On Wed, Nov 06, 2019 at 08:38:33AM -0800, Brian Norris wrote: > On Wed, Nov 6, 2019 at 12:12 AM Johannes Berg <johannes@sipsolutions.net> wrote: > > On Tue, 2019-11-05 at 15:02 -0800, Brian Norris wrote: > > > Apparently wireless-regdb@ is subscribers only. I have since joined, > > > but I guess my patch bounced from that list... if I don't hear back in > > > a while, I may resend. > > > > The bigger question is who actually maintains crda now, if anyone ... :) > > My mailbox tells me that as of about a year ago, Luis was still > merging patches. And his latest commit even claims it's "still > maintained": > > As if kernel v4.15 CRDA is no longer needed. Annotate this. The > code will still be maintained to help older kernels. Sure, send me patches. Its just not needed on older systems. Luis
diff --git a/Makefile b/Makefile index 6169b1f307da..6ca26f341dfa 100644 --- a/Makefile +++ b/Makefile @@ -114,9 +114,9 @@ keys-%.c: utils/key2pub.py $(wildcard $(PUBKEY_DIR)/*.pem) $(NQ) ' Trusted pubkeys:' $(wildcard $(PUBKEY_DIR)/*.pem) $(Q)./utils/key2pub.py --$* $(wildcard $(PUBKEY_DIR)/*.pem) $@ -$(LIBREG): regdb.h reglib.h reglib.c +$(LIBREG): reglib.c regdb.h reglib.h $(NQ) ' CC ' $@ - $(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $^ + $(Q)$(CC) $(CFLAGS) $(CPPFLAGS) -o $@ -shared -Wl,-soname,$(LIBREG) $< install-libreg-headers: $(NQ) ' INSTALL libreg-headers'
Write the CC rule such that it only tries to produce a single output file (the .so). When including the .h files in the compiler invocation, this suggests we should be producing pre-compiled headers too, which doesn't make sense in this context, and Clang happens not to like. Signed-off-by: Brian Norris <briannorris@chromium.org> --- Yes, I know CRDA is deprecated. Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)