| Message ID | 1573115572-13513-3-git-send-email-biju.das@bp.renesas.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | Add RZ/G1C SD/eMMC support | expand |
Hi! > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > > commit 254d1456560fa42d4ca901c9b9308e87c951fee1 upstream. > > When compiling the driver with CONFIG_MMC_DEBUG set, I got build > warnings. They have been 'fixed' meanwhile. However, because these debug > messages look random anyhow (some duplicate information printed etc), > let's just drop them and rather re-add something consistent if that > should ever be needed. Its too late to change that now, but 1/ fixes messages and then 2/ just deletes them. Single patch would do. Best regards, Pavel
Hi Pavel, Thanks for the feedback > -----Original Message----- > From: Pavel Machek <pavel@denx.de> > Sent: Friday, November 8, 2019 9:08 AM > To: Biju Das <biju.das@bp.renesas.com> > Cc: cip-dev@lists.cip-project.org; Nobuhiro Iwamatsu > <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>; > Chris Paterson <Chris.Paterson2@renesas.com>; Fabrizio Castro > <fabrizio.castro@bp.renesas.com> > Subject: Re: [PATCH 4.4.y-cip 02/83] mmc: tmio_dma: remove debug > messages with little information > > Hi! > > > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > > > > commit 254d1456560fa42d4ca901c9b9308e87c951fee1 upstream. > > > > When compiling the driver with CONFIG_MMC_DEBUG set, I got build > > warnings. They have been 'fixed' meanwhile. However, because these > > debug messages look random anyhow (some duplicate information printed > > etc), let's just drop them and rather re-add something consistent if > > that should ever be needed. > > Its too late to change that now, but 1/ fixes messages and then 2/ just > deletes them. Single patch would do. Are you ok to merge this patches while applying? or Do you want me to send another series fixing this? Please let me know. Regards, Biju
Hi! > > > From: Wolfram Sang <wsa+renesas@sang-engineering.com> > > > > > > commit 254d1456560fa42d4ca901c9b9308e87c951fee1 upstream. > > > > > > When compiling the driver with CONFIG_MMC_DEBUG set, I got build > > > warnings. They have been 'fixed' meanwhile. However, because these > > > debug messages look random anyhow (some duplicate information printed > > > etc), let's just drop them and rather re-add something consistent if > > > that should ever be needed. > > > > Its too late to change that now, but 1/ fixes messages and then 2/ just > > deletes them. Single patch would do. > > Are you ok to merge this patches while applying? or Do you want me to send another series fixing this? > Please let me know. I believe this is minor detail, and we can use the patches as-is. See my reply to Chris for thoughts about rest of the series. Best regards, Pavel
diff --git a/drivers/mmc/host/tmio_mmc_dma.c b/drivers/mmc/host/tmio_mmc_dma.c index 4a0d6b8..6754358 100644 --- a/drivers/mmc/host/tmio_mmc_dma.c +++ b/drivers/mmc/host/tmio_mmc_dma.c @@ -94,10 +94,7 @@ static void tmio_mmc_start_dma_rx(struct tmio_mmc_host *host) desc = NULL; ret = cookie; } - dev_dbg(&host->pdev->dev, "%s(): mapped %d -> %d, cookie %d, rq %p\n", - __func__, host->sg_len, ret, cookie, host->mrq); } - pio: if (!desc) { /* DMA failed, fall back to PIO */ @@ -115,9 +112,6 @@ pio: dev_warn(&host->pdev->dev, "DMA failed: %d, falling back to PIO\n", ret); } - - dev_dbg(&host->pdev->dev, "%s(): desc %p, sg[%d]\n", __func__, - desc, host->sg_len); } static void tmio_mmc_start_dma_tx(struct tmio_mmc_host *host) @@ -174,10 +168,7 @@ static void tmio_mmc_start_dma_tx(struct tmio_mmc_host *host) desc = NULL; ret = cookie; } - dev_dbg(&host->pdev->dev, "%s(): mapped %d -> %d, cookie %d, rq %p\n", - __func__, host->sg_len, ret, cookie, host->mrq); } - pio: if (!desc) { /* DMA failed, fall back to PIO */ @@ -195,8 +186,6 @@ pio: dev_warn(&host->pdev->dev, "DMA failed: %d, falling back to PIO\n", ret); } - - dev_dbg(&host->pdev->dev, "%s(): desc %p\n", __func__, desc); } void tmio_mmc_start_dma(struct tmio_mmc_host *host,