[0/7] drm/mcde: DSI video mode fixes

Message

Stephan Gerhold Nov. 6, 2019, 4:58 p.m. UTC

This is a collection of fixes to make DSI video mode work better
using the MCDE driver. With these changes, MCDE appears to work
properly for the video mode panel I have been testing with.

Note: The patch that fixes the DSI link register setup for
video mode [1] is still necessary; but we still need to finish it
and actually make it initialize a panel correctly.

This series contains only patches for the other parts in MCDE.
I have tested it by disabling most of the register setup in the
DSI driver, which makes it re-use the properly working DSI register
set by the bootloader.

[1]: https://lists.freedesktop.org/archives/dri-devel/2019-October/238175.html

Stephan Gerhold (7):
  drm/mcde: Provide vblank handling unconditionally
  drm/mcde: Fix frame sync setup for video mode panels
  drm/mcde: dsi: Make video mode errors more verbose
  drm/mcde: dsi: Delay start of video stream generator
  drm/mcde: dsi: Fix duplicated DSI connector
  drm/mcde: dsi: Enable clocks in pre_enable() instead of mode_set()
  drm/mcde: Handle pending vblank while disabling display

 drivers/gpu/drm/mcde/mcde_display.c  |  57 +++++----
 drivers/gpu/drm/mcde/mcde_drm.h      |   1 +
 drivers/gpu/drm/mcde/mcde_drv.c      |  18 +--
 drivers/gpu/drm/mcde/mcde_dsi.c      | 167 +++++++++++++--------------
 drivers/gpu/drm/mcde/mcde_dsi_regs.h |  10 ++
 5 files changed, 126 insertions(+), 127 deletions(-)

Comments

Linus Walleij Nov. 8, 2019, 3:52 p.m. UTC | #1

On Wed, Nov 6, 2019 at 6:01 PM Stephan Gerhold <[e-mail]> wrote:

> This is a collection of fixes to make DSI video mode work better
> using the MCDE driver. With these changes, MCDE appears to work
> properly for the video mode panel I have been testing with.
>
> Note: The patch that fixes the DSI link register setup for
> video mode [1] is still necessary; but we still need to finish it
> and actually make it initialize a panel correctly.
>
> This series contains only patches for the other parts in MCDE.
> I have tested it by disabling most of the register setup in the
> DSI driver, which makes it re-use the properly working DSI register
> set by the bootloader.
>
> [1]: https://lists.freedesktop.org/archives/dri-devel/2019-October/238175.html
>
> Stephan Gerhold (7):
>   drm/mcde: Provide vblank handling unconditionally
>   drm/mcde: Fix frame sync setup for video mode panels
>   drm/mcde: dsi: Make video mode errors more verbose
>   drm/mcde: dsi: Delay start of video stream generator
>   drm/mcde: dsi: Fix duplicated DSI connector
>   drm/mcde: dsi: Enable clocks in pre_enable() instead of mode_set()
>   drm/mcde: Handle pending vblank while disabling display

Tested all 7 on the Ux500 HREFv60plus with the command mode
panel without problems.
Tested-by: Linus Walleij <[e-mail]>

I will apply and push to DRM misc for-next with my Tested-by tag.

Yours,
Linus Walleij