diff mbox series

iio: adc: bcm_iproc_adc: drop a stray semicolon

Message ID 20191013121856.1782707-1-jic23@kernel.org (mailing list archive)
State New, archived
Headers show
Series iio: adc: bcm_iproc_adc: drop a stray semicolon | expand

Commit Message

Jonathan Cameron Oct. 13, 2019, 12:18 p.m. UTC 
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Found by coccinelle / coccicheck

CHECK   drivers/iio/adc/bcm_iproc_adc.c
drivers/iio/adc/bcm_iproc_adc.c:311:3-4: Unneeded semicolon

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
---
 drivers/iio/adc/bcm_iproc_adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexandru Ardelean Nov. 4, 2019, 3:15 p.m. UTC | #1 
On Sun, 2019-10-13 at 13:18 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Found by coccinelle / coccicheck
> 
> CHECK   drivers/iio/adc/bcm_iproc_adc.c
> drivers/iio/adc/bcm_iproc_adc.c:311:3-4: Unneeded semicolon
> 

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> ---
>  drivers/iio/adc/bcm_iproc_adc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/bcm_iproc_adc.c
> b/drivers/iio/adc/bcm_iproc_adc.c
> index 646ebdc0a8b4..5e396104ac86 100644
> --- a/drivers/iio/adc/bcm_iproc_adc.c
> +++ b/drivers/iio/adc/bcm_iproc_adc.c
> @@ -308,7 +308,7 @@ static int iproc_adc_do_read(struct iio_dev
> *indio_dev,
>  				"IntMask set failed. Read will likely
> fail.");
>  			read_len = -EIO;
>  			goto adc_err;
> -		};
> +		}
>  	}
>  	regmap_read(adc_priv->regmap, IPROC_INTERRUPT_MASK, &val_check);
>
Jonathan Cameron Nov. 9, 2019, 12:17 p.m. UTC | #2 
On Mon, 4 Nov 2019 15:15:30 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Sun, 2019-10-13 at 13:18 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Found by coccinelle / coccicheck
> > 
> > CHECK   drivers/iio/adc/bcm_iproc_adc.c
> > drivers/iio/adc/bcm_iproc_adc.c:311:3-4: Unneeded semicolon
> >   
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied thanks.

Jonathan

> 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Raveendra Padasalagi <raveendra.padasalagi@broadcom.com>
> > ---
> >  drivers/iio/adc/bcm_iproc_adc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/iio/adc/bcm_iproc_adc.c
> > b/drivers/iio/adc/bcm_iproc_adc.c
> > index 646ebdc0a8b4..5e396104ac86 100644
> > --- a/drivers/iio/adc/bcm_iproc_adc.c
> > +++ b/drivers/iio/adc/bcm_iproc_adc.c
> > @@ -308,7 +308,7 @@ static int iproc_adc_do_read(struct iio_dev
> > *indio_dev,
> >  				"IntMask set failed. Read will likely
> > fail.");
> >  			read_len = -EIO;
> >  			goto adc_err;
> > -		};
> > +		}
> >  	}
> >  	regmap_read(adc_priv->regmap, IPROC_INTERRUPT_MASK, &val_check);
> >
diff mbox series

Patch

diff --git a/drivers/iio/adc/bcm_iproc_adc.c b/drivers/iio/adc/bcm_iproc_adc.c
index 646ebdc0a8b4..5e396104ac86 100644
--- a/drivers/iio/adc/bcm_iproc_adc.c
+++ b/drivers/iio/adc/bcm_iproc_adc.c
@@ -308,7 +308,7 @@  static int iproc_adc_do_read(struct iio_dev *indio_dev,
 				"IntMask set failed. Read will likely fail.");
 			read_len = -EIO;
 			goto adc_err;
-		};
+		}
 	}
 	regmap_read(adc_priv->regmap, IPROC_INTERRUPT_MASK, &val_check);