diff mbox series

iio: adc: vf610: use devm_platform_ioremap_resource

Message ID 20191013164349.2049538-1-jic23@kernel.org (mailing list archive)
State New, archived
Headers show
Series iio: adc: vf610: use devm_platform_ioremap_resource | expand

Commit Message

Jonathan Cameron Oct. 13, 2019, 4:43 p.m. UTC 
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>

Reduces boilerplate.

Suggested by coccinelle
CHECK   drivers/iio/adc/vf610_adc.c
drivers/iio/adc/vf610_adc.c:819:1-11: WARNING: Use devm_platform_ioremap_resource for info -> regs

Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Fugang Duan <b38611@freescale.com>
---
 drivers/iio/adc/vf610_adc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Alexandru Ardelean Nov. 4, 2019, 3:19 p.m. UTC | #1 
On Sun, 2019-10-13 at 17:43 +0100, jic23@kernel.org wrote:
> From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> 
> Reduces boilerplate.
> 
> Suggested by coccinelle
> CHECK   drivers/iio/adc/vf610_adc.c
> drivers/iio/adc/vf610_adc.c:819:1-11: WARNING: Use
> devm_platform_ioremap_resource for info -> regs
> 

Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>

> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Fugang Duan <b38611@freescale.com>
> ---
>  drivers/iio/adc/vf610_adc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
> index 98b30475bbc6..cb7380bf07ca 100644
> --- a/drivers/iio/adc/vf610_adc.c
> +++ b/drivers/iio/adc/vf610_adc.c
> @@ -802,7 +802,6 @@ static int vf610_adc_probe(struct platform_device
> *pdev)
>  {
>  	struct vf610_adc *info;
>  	struct iio_dev *indio_dev;
> -	struct resource *mem;
>  	int irq;
>  	int ret;
>  
> @@ -815,8 +814,7 @@ static int vf610_adc_probe(struct platform_device
> *pdev)
>  	info = iio_priv(indio_dev);
>  	info->dev = &pdev->dev;
>  
> -	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	info->regs = devm_ioremap_resource(&pdev->dev, mem);
> +	info->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(info->regs))
>  		return PTR_ERR(info->regs);
>
Jonathan Cameron Nov. 9, 2019, 12:29 p.m. UTC | #2 
On Mon, 4 Nov 2019 15:19:13 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:

> On Sun, 2019-10-13 at 17:43 +0100, jic23@kernel.org wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 
> > Reduces boilerplate.
> > 
> > Suggested by coccinelle
> > CHECK   drivers/iio/adc/vf610_adc.c
> > drivers/iio/adc/vf610_adc.c:819:1-11: WARNING: Use
> > devm_platform_ioremap_resource for info -> regs
> >   
> 
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied,

Thanks,

J
> 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > Cc: Fugang Duan <b38611@freescale.com>
> > ---
> >  drivers/iio/adc/vf610_adc.c | 4 +---
> >  1 file changed, 1 insertion(+), 3 deletions(-)
> > 
> > diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
> > index 98b30475bbc6..cb7380bf07ca 100644
> > --- a/drivers/iio/adc/vf610_adc.c
> > +++ b/drivers/iio/adc/vf610_adc.c
> > @@ -802,7 +802,6 @@ static int vf610_adc_probe(struct platform_device
> > *pdev)
> >  {
> >  	struct vf610_adc *info;
> >  	struct iio_dev *indio_dev;
> > -	struct resource *mem;
> >  	int irq;
> >  	int ret;
> >  
> > @@ -815,8 +814,7 @@ static int vf610_adc_probe(struct platform_device
> > *pdev)
> >  	info = iio_priv(indio_dev);
> >  	info->dev = &pdev->dev;
> >  
> > -	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> > -	info->regs = devm_ioremap_resource(&pdev->dev, mem);
> > +	info->regs = devm_platform_ioremap_resource(pdev, 0);
> >  	if (IS_ERR(info->regs))
> >  		return PTR_ERR(info->regs);
> >
diff mbox series

Patch

diff --git a/drivers/iio/adc/vf610_adc.c b/drivers/iio/adc/vf610_adc.c
index 98b30475bbc6..cb7380bf07ca 100644
--- a/drivers/iio/adc/vf610_adc.c
+++ b/drivers/iio/adc/vf610_adc.c
@@ -802,7 +802,6 @@  static int vf610_adc_probe(struct platform_device *pdev)
 {
 	struct vf610_adc *info;
 	struct iio_dev *indio_dev;
-	struct resource *mem;
 	int irq;
 	int ret;
 
@@ -815,8 +814,7 @@  static int vf610_adc_probe(struct platform_device *pdev)
 	info = iio_priv(indio_dev);
 	info->dev = &pdev->dev;
 
-	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	info->regs = devm_ioremap_resource(&pdev->dev, mem);
+	info->regs = devm_platform_ioremap_resource(pdev, 0);
 	if (IS_ERR(info->regs))
 		return PTR_ERR(info->regs);