| Message ID | 20191015134012.15165-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [RESEND] drm/msm/adreno: Do not print error on "qcom, gpu-pwrlevels" absence | expand |
On Tue, Oct 15, 2019 at 7:40 AM Fabio Estevam <festevam@gmail.com> wrote: > > Booting the adreno driver on a imx53 board leads to the following > error message: > > adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels > > As the "qcom,gpu-pwrlevels" property is optional and never present on > i.MX5, turn the message into debug level instead. > > Signed-off-by: Fabio Estevam <festevam@gmail.com> Seems reasonable. Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com> > --- > > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > index 0783e4b5486a..5d7bdb4c83cc 100644 > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c > @@ -826,7 +826,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev) > > node = of_get_compatible_child(dev->of_node, "qcom,gpu-pwrlevels"); > if (!node) { > - DRM_DEV_ERROR(dev, "Could not find the GPU powerlevels\n"); > + DRM_DEV_DEBUG(dev, "Could not find the GPU powerlevels\n"); > return -ENXIO; > } > > -- > 2.17.1 > > _______________________________________________ > Freedreno mailing list > Freedreno@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/freedreno
Hi Rob, On Tue, Oct 15, 2019 at 11:19 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote: > > On Tue, Oct 15, 2019 at 7:40 AM Fabio Estevam <festevam@gmail.com> wrote: > > > > Booting the adreno driver on a imx53 board leads to the following > > error message: > > > > adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels > > > > As the "qcom,gpu-pwrlevels" property is optional and never present on > > i.MX5, turn the message into debug level instead. > > > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > > Seems reasonable. Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com> Any comments, please? Just wanted to get rid of this misleading error message on i.MX5. Thanks
On Thu, Oct 31, 2019 at 07:03:59PM -0300, Fabio Estevam wrote: > Hi Rob, > > On Tue, Oct 15, 2019 at 11:19 AM Jeffrey Hugo <jeffrey.l.hugo@gmail.com> wrote: > > > > On Tue, Oct 15, 2019 at 7:40 AM Fabio Estevam <festevam@gmail.com> wrote: > > > > > > Booting the adreno driver on a imx53 board leads to the following > > > error message: > > > > > > adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels > > > > > > As the "qcom,gpu-pwrlevels" property is optional and never present on > > > i.MX5, turn the message into debug level instead. > > > > > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > > > > Seems reasonable. Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com> > > Any comments, please? > > Just wanted to get rid of this misleading error message on i.MX5. I'm good with this. This really should only be around for compatibility with downstream device tree files which should mean nothing for I.MX5. Jordan
Hi Jordan, On Fri, Nov 1, 2019 at 11:52 AM Jordan Crouse <jcrouse@codeaurora.org> wrote: > I'm good with this. This really should only be around for > compatibility with downstream device tree files which should mean nothing for > I.MX5. May I resend it with your Reviewed-by tag? Thanks
On Tue, Nov 12, 2019 at 01:40:22PM -0300, Fabio Estevam wrote: > Hi Jordan, > > On Fri, Nov 1, 2019 at 11:52 AM Jordan Crouse <jcrouse@codeaurora.org> wrote: > > > I'm good with this. This really should only be around for > > compatibility with downstream device tree files which should mean nothing for > > I.MX5. > > May I resend it with your Reviewed-by tag? Of course. Jordan
diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c index 0783e4b5486a..5d7bdb4c83cc 100644 --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c @@ -826,7 +826,7 @@ static int adreno_get_legacy_pwrlevels(struct device *dev) node = of_get_compatible_child(dev->of_node, "qcom,gpu-pwrlevels"); if (!node) { - DRM_DEV_ERROR(dev, "Could not find the GPU powerlevels\n"); + DRM_DEV_DEBUG(dev, "Could not find the GPU powerlevels\n"); return -ENXIO; }
Booting the adreno driver on a imx53 board leads to the following error message: adreno 30000000.gpu: [drm:adreno_gpu_init] *ERROR* Could not find the GPU powerlevels As the "qcom,gpu-pwrlevels" property is optional and never present on i.MX5, turn the message into debug level instead. Signed-off-by: Fabio Estevam <festevam@gmail.com> --- drivers/gpu/drm/msm/adreno/adreno_gpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)