| Message ID | cover.1571925699.git.lukasstraub2@web.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | colo: Add support for continuous replication | expand |
On Fri, 25 Oct 2019 19:06:31 +0200 Lukas Straub <lukasstraub2@web.de> wrote: > Hello Everyone, > These Patches add support for continuous replication to colo. This means > that after the Primary fails and the Secondary did a failover, the Secondary > can then become Primary and resume replication to a new Secondary. > > Regards, > Lukas Straub > > v7: > - clarify meaning of ip's in documentation and note that active and hidden > images just need to be created once > - reverted removal of bdrv_is_root_node(top_bs) in replication and adjusted > the top-id= parameter in documentation acordingly > > v6: > - documented the position= and insert= options > - renamed replication test > - clarified documentation by using different ip's for primary and secondary > - added Reviewed-by tags > > v5: > - change syntax for the position= parameter > - fix spelling mistake > > v4: > - fix checkpatch.pl warnings > > v3: > - add test for replication changes > - check if the filter to be inserted before/behind belongs to the same interface > - fix the error message for the position= parameter > - rename term "after" -> "behind" and variable "insert_before" -> "insert_before_flag" > - document the quorum node on the secondary side > - simplify quorum parameters in documentation > - remove trailing spaces in documentation > - clarify the testing procedure in documentation > > v2: > - fix email formating > - fix checkpatch.pl warnings > - fix patchew error > - clearer commit messages > > > Lukas Straub (4): > block/replication.c: Ignore requests after failover > tests/test-replication.c: Add test for for secondary node continuing > replication > net/filter.c: Add Options to insert filters anywhere in the filter > list > colo: Update Documentation for continuous replication > > block/replication.c | 35 +++++- > docs/COLO-FT.txt | 224 +++++++++++++++++++++++++++---------- > docs/block-replication.txt | 28 +++-- > include/net/filter.h | 2 + > net/filter.c | 92 ++++++++++++++- > qemu-options.hx | 31 ++++- > tests/test-replication.c | 52 +++++++++ > 7 files changed, 389 insertions(+), 75 deletions(-) > Hello Everyone, So I guess this is ready for merging or will that have to wait until the 4.2 release is done? Regards, Lukas Straub
> -----Original Message----- > From: Lukas Straub <lukasstraub2@web.de> > Sent: Thursday, November 14, 2019 12:36 AM > To: qemu-devel <qemu-devel@nongnu.org> > Cc: Zhang, Chen <chen.zhang@intel.com>; Jason Wang > <jasowang@redhat.com>; Wen Congyang <wencongyang2@huawei.com>; > Xie Changlong <xiechanglong.d@gmail.com>; Kevin Wolf > <kwolf@redhat.com>; Max Reitz <mreitz@redhat.com>; qemu-block > <qemu-block@nongnu.org> > Subject: Re: [PATCH v7 0/4] colo: Add support for continuous replication > > On Fri, 25 Oct 2019 19:06:31 +0200 > Lukas Straub <lukasstraub2@web.de> wrote: > > > Hello Everyone, > > These Patches add support for continuous replication to colo. This > > means that after the Primary fails and the Secondary did a failover, > > the Secondary can then become Primary and resume replication to a new > Secondary. > > > > Regards, > > Lukas Straub > > > > v7: > > - clarify meaning of ip's in documentation and note that active and hidden > > images just need to be created once > > - reverted removal of bdrv_is_root_node(top_bs) in replication and > adjusted > > the top-id= parameter in documentation acordingly > > > > v6: > > - documented the position= and insert= options > > - renamed replication test > > - clarified documentation by using different ip's for primary and > > secondary > > - added Reviewed-by tags > > > > v5: > > - change syntax for the position= parameter > > - fix spelling mistake > > > > v4: > > - fix checkpatch.pl warnings > > > > v3: > > - add test for replication changes > > - check if the filter to be inserted before/behind belongs to the > > same interface > > - fix the error message for the position= parameter > > - rename term "after" -> "behind" and variable "insert_before" -> > "insert_before_flag" > > - document the quorum node on the secondary side > > - simplify quorum parameters in documentation > > - remove trailing spaces in documentation > > - clarify the testing procedure in documentation > > > > v2: > > - fix email formating > > - fix checkpatch.pl warnings > > - fix patchew error > > - clearer commit messages > > > > > > Lukas Straub (4): > > block/replication.c: Ignore requests after failover > > tests/test-replication.c: Add test for for secondary node continuing > > replication > > net/filter.c: Add Options to insert filters anywhere in the filter > > list > > colo: Update Documentation for continuous replication > > > > block/replication.c | 35 +++++- > > docs/COLO-FT.txt | 224 +++++++++++++++++++++++++++---------- > > docs/block-replication.txt | 28 +++-- > > include/net/filter.h | 2 + > > net/filter.c | 92 ++++++++++++++- > > qemu-options.hx | 31 ++++- > > tests/test-replication.c | 52 +++++++++ > > 7 files changed, 389 insertions(+), 75 deletions(-) > > > > Hello Everyone, > So I guess this is ready for merging or will that have to wait until the 4.2 > release is done? Due to Qemu 4.2 release schedule, after soft feature freeze(Oct29) the master branch does not accept feature changes. But I don't know if sub-maintainer(block or net) can queue this series first then merge it after 4.2 release? Thanks Zhang Chen > > Regards, > Lukas Straub
On 2019/11/19 下午8:28, Zhang, Chen wrote: > >> -----Original Message----- >> From: Lukas Straub <lukasstraub2@web.de> >> Sent: Thursday, November 14, 2019 12:36 AM >> To: qemu-devel <qemu-devel@nongnu.org> >> Cc: Zhang, Chen <chen.zhang@intel.com>; Jason Wang >> <jasowang@redhat.com>; Wen Congyang <wencongyang2@huawei.com>; >> Xie Changlong <xiechanglong.d@gmail.com>; Kevin Wolf >> <kwolf@redhat.com>; Max Reitz <mreitz@redhat.com>; qemu-block >> <qemu-block@nongnu.org> >> Subject: Re: [PATCH v7 0/4] colo: Add support for continuous replication >> >> On Fri, 25 Oct 2019 19:06:31 +0200 >> Lukas Straub <lukasstraub2@web.de> wrote: >> >>> Hello Everyone, >>> These Patches add support for continuous replication to colo. This >>> means that after the Primary fails and the Secondary did a failover, >>> the Secondary can then become Primary and resume replication to a new >> Secondary. >>> Regards, >>> Lukas Straub >>> >>> v7: >>> - clarify meaning of ip's in documentation and note that active and hidden >>> images just need to be created once >>> - reverted removal of bdrv_is_root_node(top_bs) in replication and >> adjusted >>> the top-id= parameter in documentation acordingly >>> >>> v6: >>> - documented the position= and insert= options >>> - renamed replication test >>> - clarified documentation by using different ip's for primary and >>> secondary >>> - added Reviewed-by tags >>> >>> v5: >>> - change syntax for the position= parameter >>> - fix spelling mistake >>> >>> v4: >>> - fix checkpatch.pl warnings >>> >>> v3: >>> - add test for replication changes >>> - check if the filter to be inserted before/behind belongs to the >>> same interface >>> - fix the error message for the position= parameter >>> - rename term "after" -> "behind" and variable "insert_before" -> >> "insert_before_flag" >>> - document the quorum node on the secondary side >>> - simplify quorum parameters in documentation >>> - remove trailing spaces in documentation >>> - clarify the testing procedure in documentation >>> >>> v2: >>> - fix email formating >>> - fix checkpatch.pl warnings >>> - fix patchew error >>> - clearer commit messages >>> >>> >>> Lukas Straub (4): >>> block/replication.c: Ignore requests after failover >>> tests/test-replication.c: Add test for for secondary node continuing >>> replication >>> net/filter.c: Add Options to insert filters anywhere in the filter >>> list >>> colo: Update Documentation for continuous replication >>> >>> block/replication.c | 35 +++++- >>> docs/COLO-FT.txt | 224 +++++++++++++++++++++++++++---------- >>> docs/block-replication.txt | 28 +++-- >>> include/net/filter.h | 2 + >>> net/filter.c | 92 ++++++++++++++- >>> qemu-options.hx | 31 ++++- >>> tests/test-replication.c | 52 +++++++++ >>> 7 files changed, 389 insertions(+), 75 deletions(-) >>> >> Hello Everyone, >> So I guess this is ready for merging or will that have to wait until the 4.2 >> release is done? > Due to Qemu 4.2 release schedule, after soft feature freeze(Oct29) the master branch does not accept feature changes. > But I don't know if sub-maintainer(block or net) can queue this series first then merge it after 4.2 release? > > Thanks > Zhang Chen Will try to queue this series. Thanks > >> Regards, >> Lukas Straub
> -----Original Message----- > From: Jason Wang <jasowang@redhat.com> > Sent: Tuesday, November 19, 2019 11:03 PM > To: Zhang, Chen <chen.zhang@intel.com>; Lukas Straub > <lukasstraub2@web.de>; qemu-devel <qemu-devel@nongnu.org> > Cc: Kevin Wolf <kwolf@redhat.com>; qemu-block <qemu- > block@nongnu.org>; Wen Congyang <wencongyang2@huawei.com>; Max > Reitz <mreitz@redhat.com>; Xie Changlong <xiechanglong.d@gmail.com> > Subject: Re: [PATCH v7 0/4] colo: Add support for continuous replication > > > On 2019/11/19 下午8:28, Zhang, Chen wrote: > > > >> -----Original Message----- > >> From: Lukas Straub <lukasstraub2@web.de> > >> Sent: Thursday, November 14, 2019 12:36 AM > >> To: qemu-devel <qemu-devel@nongnu.org> > >> Cc: Zhang, Chen <chen.zhang@intel.com>; Jason Wang > >> <jasowang@redhat.com>; Wen Congyang > <wencongyang2@huawei.com>; Xie > >> Changlong <xiechanglong.d@gmail.com>; Kevin Wolf > <kwolf@redhat.com>; > >> Max Reitz <mreitz@redhat.com>; qemu-block <qemu-block@nongnu.org> > >> Subject: Re: [PATCH v7 0/4] colo: Add support for continuous > >> replication > >> > >> On Fri, 25 Oct 2019 19:06:31 +0200 > >> Lukas Straub <lukasstraub2@web.de> wrote: > >> > >>> Hello Everyone, > >>> These Patches add support for continuous replication to colo. This > >>> means that after the Primary fails and the Secondary did a failover, > >>> the Secondary can then become Primary and resume replication to a > >>> new > >> Secondary. > >>> Regards, > >>> Lukas Straub > >>> > >>> v7: > >>> - clarify meaning of ip's in documentation and note that active and > hidden > >>> images just need to be created once > >>> - reverted removal of bdrv_is_root_node(top_bs) in replication and > >> adjusted > >>> the top-id= parameter in documentation acordingly > >>> > >>> v6: > >>> - documented the position= and insert= options > >>> - renamed replication test > >>> - clarified documentation by using different ip's for primary and > >>> secondary > >>> - added Reviewed-by tags > >>> > >>> v5: > >>> - change syntax for the position= parameter > >>> - fix spelling mistake > >>> > >>> v4: > >>> - fix checkpatch.pl warnings > >>> > >>> v3: > >>> - add test for replication changes > >>> - check if the filter to be inserted before/behind belongs to the > >>> same interface > >>> - fix the error message for the position= parameter > >>> - rename term "after" -> "behind" and variable "insert_before" -> > >> "insert_before_flag" > >>> - document the quorum node on the secondary side > >>> - simplify quorum parameters in documentation > >>> - remove trailing spaces in documentation > >>> - clarify the testing procedure in documentation > >>> > >>> v2: > >>> - fix email formating > >>> - fix checkpatch.pl warnings > >>> - fix patchew error > >>> - clearer commit messages > >>> > >>> > >>> Lukas Straub (4): > >>> block/replication.c: Ignore requests after failover > >>> tests/test-replication.c: Add test for for secondary node continuing > >>> replication > >>> net/filter.c: Add Options to insert filters anywhere in the filter > >>> list > >>> colo: Update Documentation for continuous replication > >>> > >>> block/replication.c | 35 +++++- > >>> docs/COLO-FT.txt | 224 +++++++++++++++++++++++++++--------- > - > >>> docs/block-replication.txt | 28 +++-- > >>> include/net/filter.h | 2 + > >>> net/filter.c | 92 ++++++++++++++- > >>> qemu-options.hx | 31 ++++- > >>> tests/test-replication.c | 52 +++++++++ > >>> 7 files changed, 389 insertions(+), 75 deletions(-) > >>> > >> Hello Everyone, > >> So I guess this is ready for merging or will that have to wait until > >> the 4.2 release is done? > > Due to Qemu 4.2 release schedule, after soft feature freeze(Oct29) the > master branch does not accept feature changes. > > But I don't know if sub-maintainer(block or net) can queue this series first > then merge it after 4.2 release? > > > > Thanks > > Zhang Chen > > > Will try to queue this series. Thank you Jason~ Thanks Zhang Chen > > Thanks > > > > > >> Regards, > >> Lukas Straub
Hi Jason, I noticed this series can't be merged or queued, do you met some problem about it? Thanks Zhang Chen >>>> Max Reitz <mreitz@redhat.com>; qemu-block <qemu-block@nongnu.org> >>>> Subject: Re: [PATCH v7 0/4] colo: Add support for continuous >>>> replication >>>> >>>> On Fri, 25 Oct 2019 19:06:31 +0200 >>>> Lukas Straub <lukasstraub2@web.de> wrote: >>>> >>>>> Hello Everyone, >>>>> These Patches add support for continuous replication to colo. This >>>>> means that after the Primary fails and the Secondary did a failover, >>>>> the Secondary can then become Primary and resume replication to a >>>>> new >>>> Secondary. >>>>> Regards, >>>>> Lukas Straub >>>>> >>>>> v7: >>>>> - clarify meaning of ip's in documentation and note that active and >> hidden >>>>> images just need to be created once >>>>> - reverted removal of bdrv_is_root_node(top_bs) in replication and >>>> adjusted >>>>> the top-id= parameter in documentation acordingly >>>>> >>>>> v6: >>>>> - documented the position= and insert= options >>>>> - renamed replication test >>>>> - clarified documentation by using different ip's for primary and >>>>> secondary >>>>> - added Reviewed-by tags >>>>> >>>>> v5: >>>>> - change syntax for the position= parameter >>>>> - fix spelling mistake >>>>> >>>>> v4: >>>>> - fix checkpatch.pl warnings >>>>> >>>>> v3: >>>>> - add test for replication changes >>>>> - check if the filter to be inserted before/behind belongs to the >>>>> same interface >>>>> - fix the error message for the position= parameter >>>>> - rename term "after" -> "behind" and variable "insert_before" -> >>>> "insert_before_flag" >>>>> - document the quorum node on the secondary side >>>>> - simplify quorum parameters in documentation >>>>> - remove trailing spaces in documentation >>>>> - clarify the testing procedure in documentation >>>>> >>>>> v2: >>>>> - fix email formating >>>>> - fix checkpatch.pl warnings >>>>> - fix patchew error >>>>> - clearer commit messages >>>>> >>>>> >>>>> Lukas Straub (4): >>>>> block/replication.c: Ignore requests after failover >>>>> tests/test-replication.c: Add test for for secondary node continuing >>>>> replication >>>>> net/filter.c: Add Options to insert filters anywhere in the filter >>>>> list >>>>> colo: Update Documentation for continuous replication >>>>> >>>>> block/replication.c | 35 +++++- >>>>> docs/COLO-FT.txt | 224 +++++++++++++++++++++++++++--------- >> - >>>>> docs/block-replication.txt | 28 +++-- >>>>> include/net/filter.h | 2 + >>>>> net/filter.c | 92 ++++++++++++++- >>>>> qemu-options.hx | 31 ++++- >>>>> tests/test-replication.c | 52 +++++++++ >>>>> 7 files changed, 389 insertions(+), 75 deletions(-) >>>>> >>>> Hello Everyone, >>>> So I guess this is ready for merging or will that have to wait until >>>> the 4.2 release is done? >>> Due to Qemu 4.2 release schedule, after soft feature freeze(Oct29) the >> master branch does not accept feature changes. >>> But I don't know if sub-maintainer(block or net) can queue this series first >> then merge it after 4.2 release? >>> Thanks >>> Zhang Chen >> >> Will try to queue this series. > Thank you Jason~ > > Thanks > Zhang Chen > >> Thanks >> >> >>>> Regards, >>>> Lukas Straub
On 2020/2/20 上午9:38, Zhang, Chen wrote: > Hi Jason, > > I noticed this series can't be merged or queued, do you met some > problem about it? > > > Thanks > > Zhang Chen Not, I've queued this. Thanks
Hello Everyone, These Patches add support for continuous replication to colo. This means that after the Primary fails and the Secondary did a failover, the Secondary can then become Primary and resume replication to a new Secondary. Regards, Lukas Straub v7: - clarify meaning of ip's in documentation and note that active and hidden images just need to be created once - reverted removal of bdrv_is_root_node(top_bs) in replication and adjusted the top-id= parameter in documentation acordingly v6: - documented the position= and insert= options - renamed replication test - clarified documentation by using different ip's for primary and secondary - added Reviewed-by tags v5: - change syntax for the position= parameter - fix spelling mistake v4: - fix checkpatch.pl warnings v3: - add test for replication changes - check if the filter to be inserted before/behind belongs to the same interface - fix the error message for the position= parameter - rename term "after" -> "behind" and variable "insert_before" -> "insert_before_flag" - document the quorum node on the secondary side - simplify quorum parameters in documentation - remove trailing spaces in documentation - clarify the testing procedure in documentation v2: - fix email formating - fix checkpatch.pl warnings - fix patchew error - clearer commit messages Lukas Straub (4): block/replication.c: Ignore requests after failover tests/test-replication.c: Add test for for secondary node continuing replication net/filter.c: Add Options to insert filters anywhere in the filter list colo: Update Documentation for continuous replication block/replication.c | 35 +++++- docs/COLO-FT.txt | 224 +++++++++++++++++++++++++++---------- docs/block-replication.txt | 28 +++-- include/net/filter.h | 2 + net/filter.c | 92 ++++++++++++++- qemu-options.hx | 31 ++++- tests/test-replication.c | 52 +++++++++ 7 files changed, 389 insertions(+), 75 deletions(-) -- 2.20.1