| Message ID | 20191115083415.28976-1-m.grzeschik@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ARM: dts: imx25: fix usbhost1 node | expand |
Hello Michael, On Fri, Nov 15, 2019 at 09:34:15AM +0100, Michael Grzeschik wrote: > The usb port represented by &usbhost1 uses an USB phy internal to the > SoC. We add the phy_type to the base dtsi so the board dts only have to > overwrite it if they use a different configuration. While at it we also > pin the usbhost port to host mode and limit the speed of the phy to > full-speed only, which it is only capable of. The subject line suggests this is a fix but the commit log and the actual change don't support this. Maybe better: ARM: dts: imx25: consolidate properties of usbhost1 in dtsi file ? > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > index 9a097ef014af5..40b95a290bd6b 100644 > --- a/arch/arm/boot/dts/imx25.dtsi > +++ b/arch/arm/boot/dts/imx25.dtsi > @@ -570,6 +570,9 @@ > clock-names = "ipg", "ahb", "per"; > fsl,usbmisc = <&usbmisc 1>; > fsl,usbphy = <&usbphy1>; > + maximum-speed = "full-speed"; > + phy_type = "serial"; > + dr_mode = "host"; Would it make sense to split this patch in two? One that moves phy_type and dr_mode from the dts files using imx25.dtsi (which has no effects on the resulting dtb files). And another that adds maximum-speed. Best regards Uwe
On Fri, Nov 15, 2019 at 09:14:09PM +0100, Uwe Kleine-König wrote: > Hello Michael, > > On Fri, Nov 15, 2019 at 09:34:15AM +0100, Michael Grzeschik wrote: > > The usb port represented by &usbhost1 uses an USB phy internal to the > > SoC. We add the phy_type to the base dtsi so the board dts only have to > > overwrite it if they use a different configuration. While at it we also > > pin the usbhost port to host mode and limit the speed of the phy to > > full-speed only, which it is only capable of. > > The subject line suggests this is a fix but the commit log and the > actual change don't support this. Maybe better: > > ARM: dts: imx25: consolidate properties of usbhost1 in dtsi file > Will send a new series with this suggestion. > ? > > > diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi > > index 9a097ef014af5..40b95a290bd6b 100644 > > --- a/arch/arm/boot/dts/imx25.dtsi > > +++ b/arch/arm/boot/dts/imx25.dtsi > > @@ -570,6 +570,9 @@ > > clock-names = "ipg", "ahb", "per"; > > fsl,usbmisc = <&usbmisc 1>; > > fsl,usbphy = <&usbphy1>; > > + maximum-speed = "full-speed"; > > + phy_type = "serial"; > > + dr_mode = "host"; > > Would it make sense to split this patch in two? One that moves phy_type > and dr_mode from the dts files using imx25.dtsi (which has no effects on > the resulting dtb files). And another that adds maximum-speed. And a second patch including the speed limitation change. Thanks, Michael
diff --git a/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts b/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts index 0fde90df2b546..3f38c2e60a745 100644 --- a/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts +++ b/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts @@ -165,8 +165,6 @@ }; &usbhost1 { - phy_type = "serial"; - dr_mode = "host"; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx25-pdk.dts b/arch/arm/boot/dts/imx25-pdk.dts index 05cccd12624cb..fb66884d8a2fa 100644 --- a/arch/arm/boot/dts/imx25-pdk.dts +++ b/arch/arm/boot/dts/imx25-pdk.dts @@ -304,8 +304,6 @@ }; &usbhost1 { - phy_type = "serial"; - dr_mode = "host"; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index 9a097ef014af5..40b95a290bd6b 100644 --- a/arch/arm/boot/dts/imx25.dtsi +++ b/arch/arm/boot/dts/imx25.dtsi @@ -570,6 +570,9 @@ clock-names = "ipg", "ahb", "per"; fsl,usbmisc = <&usbmisc 1>; fsl,usbphy = <&usbphy1>; + maximum-speed = "full-speed"; + phy_type = "serial"; + dr_mode = "host"; status = "disabled"; };
The usb port represented by &usbhost1 uses an USB phy internal to the SoC. We add the phy_type to the base dtsi so the board dts only have to overwrite it if they use a different configuration. While at it we also pin the usbhost port to host mode and limit the speed of the phy to full-speed only, which it is only capable of. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> --- v1 -> v2: added the maximum speed limitation of the internal phy arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts | 2 -- arch/arm/boot/dts/imx25-pdk.dts | 2 -- arch/arm/boot/dts/imx25.dtsi | 3 +++ 3 files changed, 3 insertions(+), 4 deletions(-)