| Message ID | 0101016e7ca62853-73f33b23-b1d4-4f2e-aec1-e6aa9cd34dfe-000000@us-west-2.amazonses.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | UFS driver general fixes bundle 5 | expand |
I agree with Avri, you can just drop this patch, unless you see anything affected because of not setting VDDQ/VDDQ2 as per spec. or alternatively you can have different marco of each spec and handle the same in the code as per ufs specification version. On Mon, Nov 18, 2019 at 9:25 AM Can Guo <cang@codeaurora.org> wrote: > > Per UFS 3.0 JEDEC standard, the VCCQ2 min voltage is 1.7v and the VCCQ > voltage range is 1.14v ~ 1.26v. Update their hard codes accordingly to > make sure they work in a safe range compliant for ver 1.0/2.0/2.1/3.0 > UFS devices. > > Signed-off-by: Can Guo <cang@codeaurora.org> > --- > drivers/scsi/ufs/ufs.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h > index 385bac8..9df4f4d 100644 > --- a/drivers/scsi/ufs/ufs.h > +++ b/drivers/scsi/ufs/ufs.h > @@ -500,9 +500,9 @@ struct ufs_query_res { > #define UFS_VREG_VCC_MAX_UV 3600000 /* uV */ > #define UFS_VREG_VCC_1P8_MIN_UV 1700000 /* uV */ > #define UFS_VREG_VCC_1P8_MAX_UV 1950000 /* uV */ > -#define UFS_VREG_VCCQ_MIN_UV 1100000 /* uV */ > +#define UFS_VREG_VCCQ_MIN_UV 1140000 /* uV */ > #define UFS_VREG_VCCQ_MAX_UV 1300000 /* uV */ > -#define UFS_VREG_VCCQ2_MIN_UV 1650000 /* uV */ > +#define UFS_VREG_VCCQ2_MIN_UV 1700000 /* uV */ > #define UFS_VREG_VCCQ2_MAX_UV 1950000 /* uV */ > > /* > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project >
diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 385bac8..9df4f4d 100644 --- a/drivers/scsi/ufs/ufs.h +++ b/drivers/scsi/ufs/ufs.h @@ -500,9 +500,9 @@ struct ufs_query_res { #define UFS_VREG_VCC_MAX_UV 3600000 /* uV */ #define UFS_VREG_VCC_1P8_MIN_UV 1700000 /* uV */ #define UFS_VREG_VCC_1P8_MAX_UV 1950000 /* uV */ -#define UFS_VREG_VCCQ_MIN_UV 1100000 /* uV */ +#define UFS_VREG_VCCQ_MIN_UV 1140000 /* uV */ #define UFS_VREG_VCCQ_MAX_UV 1300000 /* uV */ -#define UFS_VREG_VCCQ2_MIN_UV 1650000 /* uV */ +#define UFS_VREG_VCCQ2_MIN_UV 1700000 /* uV */ #define UFS_VREG_VCCQ2_MAX_UV 1950000 /* uV */ /*
Per UFS 3.0 JEDEC standard, the VCCQ2 min voltage is 1.7v and the VCCQ voltage range is 1.14v ~ 1.26v. Update their hard codes accordingly to make sure they work in a safe range compliant for ver 1.0/2.0/2.1/3.0 UFS devices. Signed-off-by: Can Guo <cang@codeaurora.org> --- drivers/scsi/ufs/ufs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)