diff mbox series

target/core: Document target_cmd_size_check()

Message ID 20191107215458.64242-1-bvanassche@acm.org (mailing list archive)
State Accepted
Headers show
Series target/core: Document target_cmd_size_check() | expand

Commit Message

Bart Van Assche Nov. 7, 2019, 9:54 p.m. UTC 
Since it is nontrivial to derive the meaning of the size argument from
the code, add a documentation header above target_cmd_size_check().

Cc: Mike Christie <mchristi@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/target/target_core_transport.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

Comments

Martin K. Petersen Nov. 19, 2019, 5:29 a.m. UTC | #1 
Bart,

> Since it is nontrivial to derive the meaning of the size argument from
> the code, add a documentation header above target_cmd_size_check().

Applied to 5.5/scsi-queue. Thanks!
diff mbox series

Patch

diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
index d7d4004f83f9..ba7a01bcad7c 100644
--- a/drivers/target/target_core_transport.c
+++ b/drivers/target/target_core_transport.c
@@ -1243,6 +1243,19 @@  target_check_max_data_sg_nents(struct se_cmd *cmd, struct se_device *dev,
 	return TCM_NO_SENSE;
 }
 
+/**
+ * target_cmd_size_check - Check whether there will be a residual.
+ * @cmd: SCSI command.
+ * @size: Data buffer size derived from CDB. The data buffer size provided by
+ *   the SCSI transport driver is available in @cmd->data_length.
+ *
+ * Compare the data buffer size from the CDB with the data buffer limit from the transport
+ * header. Set @cmd->residual_count and SCF_OVERFLOW_BIT or SCF_UNDERFLOW_BIT if necessary.
+ *
+ * Note: target drivers set @cmd->data_length by calling transport_init_se_cmd().
+ *
+ * Return: TCM_NO_SENSE
+ */
 sense_reason_t
 target_cmd_size_check(struct se_cmd *cmd, unsigned int size)
 {