| Message ID | 20191115121544.2339036-6-niklas.cassel@linaro.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for QCOM Core Power Reduction | expand |
Hi Niklas, On 11/15/19 2:15 PM, Niklas Cassel wrote: > Enable CONFIG_ARM_QCOM_CPUFREQ_NVMEM. Shouldn't this be selected from qcom-cpr.c Kconfig ? > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index 4385033c0a34..09aaffd473a0 100644 > --- a/arch/arm64/configs/defconfig > +++ b/arch/arm64/configs/defconfig > @@ -88,6 +88,7 @@ CONFIG_ACPI_CPPC_CPUFREQ=m > CONFIG_ARM_ARMADA_37XX_CPUFREQ=y > CONFIG_ARM_SCPI_CPUFREQ=y > CONFIG_ARM_IMX_CPUFREQ_DT=m > +CONFIG_ARM_QCOM_CPUFREQ_NVMEM=y > CONFIG_ARM_QCOM_CPUFREQ_HW=y > CONFIG_ARM_RASPBERRYPI_CPUFREQ=m > CONFIG_ARM_TEGRA186_CPUFREQ=y >
On Fri, Nov 15, 2019 at 02:44:03PM +0200, Stanimir Varbanov wrote: > Hi Niklas, > > On 11/15/19 2:15 PM, Niklas Cassel wrote: > > Enable CONFIG_ARM_QCOM_CPUFREQ_NVMEM. > > Shouldn't this be selected from qcom-cpr.c Kconfig ? Hello Stan, I can see where this is coming from. If e.g. CONFIG_ARM_QCOM_CPUFREQ_NVMEM is selected but CONFIG_QCOM_CPR is not, then the cpufreq driver will return -EPROBE_DEFER, and will never probe successfully. However, I don't really see a difference to any other driver using a framework that the user has not enabled. The driver will then use that framework's stubs, which usually only return -ENODEV or similar. So even though these both need to be enabled to work as intended, they can be compiled/build tested separately. Kind regards, Niklas > > > > > Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> > > --- > > arch/arm64/configs/defconfig | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > > index 4385033c0a34..09aaffd473a0 100644 > > --- a/arch/arm64/configs/defconfig > > +++ b/arch/arm64/configs/defconfig > > @@ -88,6 +88,7 @@ CONFIG_ACPI_CPPC_CPUFREQ=m > > CONFIG_ARM_ARMADA_37XX_CPUFREQ=y > > CONFIG_ARM_SCPI_CPUFREQ=y > > CONFIG_ARM_IMX_CPUFREQ_DT=m > > +CONFIG_ARM_QCOM_CPUFREQ_NVMEM=y > > CONFIG_ARM_QCOM_CPUFREQ_HW=y > > CONFIG_ARM_RASPBERRYPI_CPUFREQ=m > > CONFIG_ARM_TEGRA186_CPUFREQ=y > > > > -- > regards, > Stan
diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 4385033c0a34..09aaffd473a0 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defconfig @@ -88,6 +88,7 @@ CONFIG_ACPI_CPPC_CPUFREQ=m CONFIG_ARM_ARMADA_37XX_CPUFREQ=y CONFIG_ARM_SCPI_CPUFREQ=y CONFIG_ARM_IMX_CPUFREQ_DT=m +CONFIG_ARM_QCOM_CPUFREQ_NVMEM=y CONFIG_ARM_QCOM_CPUFREQ_HW=y CONFIG_ARM_RASPBERRYPI_CPUFREQ=m CONFIG_ARM_TEGRA186_CPUFREQ=y
Enable CONFIG_ARM_QCOM_CPUFREQ_NVMEM. Signed-off-by: Niklas Cassel <niklas.cassel@linaro.org> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+)