| Message ID | 20191120031622.88949-2-stephen@brennan.io (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Raspberry Pi 4 HWRNG Support | expand |
Hi Stephen, Stefan, On Wed, Nov 20 2019, Stephen Brennan wrote: > From: Stefan Wahren <wahrenst@gmx.net> > > The BCM2711 has a RNG200 block, so document its compatible string. > > Signed-off-by: Stefan Wahren <wahrenst@gmx.net> > Signed-off-by: Stephen Brennan <stephen@brennan.io> Isn't that duplicate of Florian's commit 6223949a1531? > --- > Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt > index c223e54452da..802523196ee5 100644 > --- a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt > +++ b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt > @@ -2,6 +2,7 @@ HWRNG support for the iproc-rng200 driver > > Required properties: > - compatible : Must be one of: > + "brcm,bcm2711-rng200" > "brcm,bcm7211-rng200" Isn't this clear text duplication? Am I missing something obvious? I was looking at versions of this patch series wondering why no one noticed that. baruch > "brcm,bcm7278-rng200" > "brcm,iproc-rng200"
Hi Baruch, On Wed Nov 20, 2019 at 6:50 AM, Baruch Siach wrote: > Hi Stephen, Stefan, > > > On Wed, Nov 20 2019, Stephen Brennan wrote: > > > > From: Stefan Wahren <wahrenst@gmx.net> > > > > The BCM2711 has a RNG200 block, so document its compatible string. > > > > Signed-off-by: Stefan Wahren <wahrenst@gmx.net> > > Signed-off-by: Stephen Brennan <stephen@brennan.io> > > > Isn't that duplicate of Florian's commit 6223949a1531? > > > > --- > > Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt > > index c223e54452da..802523196ee5 100644 > > --- a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt > > +++ b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt > > @@ -2,6 +2,7 @@ HWRNG support for the iproc-rng200 driver > > > > Required properties: > > - compatible : Must be one of: > > + "brcm,bcm2711-rng200" > > "brcm,bcm7211-rng200" > > > Isn't this clear text duplication? Am I missing something obvious? > I understand the confusion, but they're different, we're looking at the difference between: bcm2711 bcm7211 ^^ These are apparently separate but related chips, leading to confusion in other places [1] as well. I double checked the commit 6223949a1531 you pointed out, as well as 1fa6d053b2a5 from your other email, to verify that this is the case. No duplication (as far as I can tell) is in the series. [1]: https://github.com/raspberrypi/linux/issues/3163 Regards, Stephen > > I was looking at versions of this patch series wondering why no one > noticed that. > > > baruch > > > > "brcm,bcm7278-rng200" > > "brcm,iproc-rng200" > > > -- > http://baruch.siach.name/blog/ ~. .~ Tk Open Systems > =}------------------------------------------------ooO--U--Ooo------------{= > - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il - > > > >
On 11/19/19 7:16 PM, Stephen Brennan wrote: > From: Stefan Wahren <wahrenst@gmx.net> > > The BCM2711 has a RNG200 block, so document its compatible string. > > Signed-off-by: Stefan Wahren <wahrenst@gmx.net> > Signed-off-by: Stephen Brennan <stephen@brennan.io> Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
On Tue, 19 Nov 2019 19:16:19 -0800, Stephen Brennan wrote: > From: Stefan Wahren <wahrenst@gmx.net> > > The BCM2711 has a RNG200 block, so document its compatible string. > > Signed-off-by: Stefan Wahren <wahrenst@gmx.net> > Signed-off-by: Stephen Brennan <stephen@brennan.io> > --- > Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt | 1 + > 1 file changed, 1 insertion(+) > Acked-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt index c223e54452da..802523196ee5 100644 --- a/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt +++ b/Documentation/devicetree/bindings/rng/brcm,iproc-rng200.txt @@ -2,6 +2,7 @@ HWRNG support for the iproc-rng200 driver Required properties: - compatible : Must be one of: + "brcm,bcm2711-rng200" "brcm,bcm7211-rng200" "brcm,bcm7278-rng200" "brcm,iproc-rng200"