[for-rc,0/3] Broadcom's roce dirver bug fixes

Message

Devesh Sharma Nov. 19, 2019, 3:48 p.m. UTC

This series contain 3 patches patch 1 and patch 2 are specific to
Gen P5 devices. Patch 3 is a generic fix to silence few sparse
warnings.

changes for V0 to V1
 - originally this series had only 1 patch which is the first patch.
 - Added Fixes tag on the first patch.
 - added two more patches to fix other quick bug fixes.

Devesh Sharma (2):
  RDMA/bnxt_re: fix stat push into dma buffer on gen p5 devices
  RDMA/bnxt_re: fix sparse warnings

Luke Starrett (1):
  RDMA/bnxt_re: Fix chip number validation Broadcom's Gen P5 series

 drivers/infiniband/hw/bnxt_re/main.c      | 9 +++++----
 drivers/infiniband/hw/bnxt_re/qplib_res.h | 8 ++++++--
 2 files changed, 11 insertions(+), 6 deletions(-)

Comments

Jason Gunthorpe Nov. 19, 2019, 7:38 p.m. UTC | #1

On Tue, Nov 19, 2019 at 10:48:48AM -0500, Devesh Sharma wrote:
> This series contain 3 patches patch 1 and patch 2 are specific to
> Gen P5 devices. Patch 3 is a generic fix to silence few sparse
> warnings.

These commit messages are not suitable for -rc, and a sparse warning
fix is rarely appropriate

You need to describe what the user impact is of these bugs.

-rc is done anyhow unless something urgent comes up.

Jason

Devesh Sharma Nov. 20, 2019, 5:22 a.m. UTC | #2

On Wed, Nov 20, 2019 at 1:08 AM Jason Gunthorpe <[e-mail]> wrote:
>
> On Tue, Nov 19, 2019 at 10:48:48AM -0500, Devesh Sharma wrote:
> > This series contain 3 patches patch 1 and patch 2 are specific to
> > Gen P5 devices. Patch 3 is a generic fix to silence few sparse
> > warnings.
>
> These commit messages are not suitable for -rc, and a sparse warning
> fix is rarely appropriate
>
> You need to describe what the user impact is of these bugs.
>
> -rc is done anyhow unless something urgent comes up.
Got your point. Let's drop sparse fixes patch from this series.

For first patch the impact catastrophic as consumer wont be able to use the
cards as it won't be listed the dev_list.

For second patch the impact is that the end-user won't be able to read
the hardware
stats.

Let me add both points in the commit description respectively.
>
> Jason

Jason Gunthorpe Nov. 20, 2019, 1:32 p.m. UTC | #3

On Wed, Nov 20, 2019 at 10:52:01AM +0530, Devesh Sharma wrote:
> On Wed, Nov 20, 2019 at 1:08 AM Jason Gunthorpe <[e-mail]> wrote:
> >
> > On Tue, Nov 19, 2019 at 10:48:48AM -0500, Devesh Sharma wrote:
> > > This series contain 3 patches patch 1 and patch 2 are specific to
> > > Gen P5 devices. Patch 3 is a generic fix to silence few sparse
> > > warnings.
> >
> > These commit messages are not suitable for -rc, and a sparse warning
> > fix is rarely appropriate
> >
> > You need to describe what the user impact is of these bugs.
> >
> > -rc is done anyhow unless something urgent comes up.
> Got your point. Let's drop sparse fixes patch from this series.

Why? it can go to -next, like I said, there won't be another -rc

> For first patch the impact catastrophic as consumer wont be able to use the
> cards as it won't be listed the dev_list.

Supporting a new card is a new feature, not -rc material

Jason

Devesh Sharma Nov. 20, 2019, 4:17 p.m. UTC | #4

On Wed, Nov 20, 2019 at 7:02 PM Jason Gunthorpe <[e-mail]> wrote:
>
> On Wed, Nov 20, 2019 at 10:52:01AM +0530, Devesh Sharma wrote:
> > On Wed, Nov 20, 2019 at 1:08 AM Jason Gunthorpe <[e-mail]> wrote:
> > >
> > > On Tue, Nov 19, 2019 at 10:48:48AM -0500, Devesh Sharma wrote:
> > > > This series contain 3 patches patch 1 and patch 2 are specific to
> > > > Gen P5 devices. Patch 3 is a generic fix to silence few sparse
> > > > warnings.
> > >
> > > These commit messages are not suitable for -rc, and a sparse warning
> > > fix is rarely appropriate
> > >
> > > You need to describe what the user impact is of these bugs.
> > >
> > > -rc is done anyhow unless something urgent comes up.
> > Got your point. Let's drop sparse fixes patch from this series.
>
> Why? it can go to -next, like I said, there won't be another -rc
Yup, it can certainly go.
>
> > For first patch the impact catastrophic as consumer wont be able to use the
> > cards as it won't be listed the dev_list.
>
> Supporting a new card is a new feature, not -rc material
Alright, I shall move the series to for-next and add back the sparse
warning fix. Please ignore V2 which have posted already.
>
> Jason