diff mbox series

[v3,4/4] ARM: dts: bcm2711: Enable HWRNG support

Message ID 20191120031622.88949-5-stephen@brennan.io (mailing list archive)
State New, archived
Headers show
Series Raspberry Pi 4 HWRNG Support | expand

Commit Message

Stephen Brennan Nov. 20, 2019, 3:16 a.m. UTC 
This enables hardware random number generator support for the BCM2711
on the Raspberry Pi 4 board.

Signed-off-by: Stephen Brennan <stephen@brennan.io>
---
 arch/arm/boot/dts/bcm2711.dtsi | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Comments

Stefan Wahren Nov. 20, 2019, 4:21 p.m. UTC | #1 
Am 20.11.19 um 04:16 schrieb Stephen Brennan:
> This enables hardware random number generator support for the BCM2711
> on the Raspberry Pi 4 board.
>
> Signed-off-by: Stephen Brennan <stephen@brennan.io>

Acked-by: Stefan Wahren <wahrenst@gmx.net>

Thanks
Nicolas Saenz Julienne Nov. 20, 2019, 7:45 p.m. UTC | #2 
On Tue, 2019-11-19 at 19:16 -0800, Stephen Brennan wrote:
> This enables hardware random number generator support for the BCM2711
> on the Raspberry Pi 4 board.
> 
> Signed-off-by: Stephen Brennan <stephen@brennan.io>
> ---
>  arch/arm/boot/dts/bcm2711.dtsi | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
> index ac83dac2e6ba..ed0877d5a1e9 100644
> --- a/arch/arm/boot/dts/bcm2711.dtsi
> +++ b/arch/arm/boot/dts/bcm2711.dtsi
> @@ -92,10 +92,9 @@ pm: watchdog@7e100000 {
>  		};
>  
>  		rng@7e104000 {
> -			interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
> -
> -			/* RNG is incompatible with brcm,bcm2835-rng */
> -			status = "disabled";
> +			compatible = "brcm,bcm2711-rng200";
> +			reg = <0x7e104000 0x28>;
> +			status = "okay";

Small nitpick, the 'okay' status is set by default, so no need for this. But
it's something we can edit out once we pick the patch.

Regards,
Nicolas
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
index ac83dac2e6ba..ed0877d5a1e9 100644
--- a/arch/arm/boot/dts/bcm2711.dtsi
+++ b/arch/arm/boot/dts/bcm2711.dtsi
@@ -92,10 +92,9 @@  pm: watchdog@7e100000 {
 		};
 
 		rng@7e104000 {
-			interrupts = <GIC_SPI 125 IRQ_TYPE_LEVEL_HIGH>;
-
-			/* RNG is incompatible with brcm,bcm2835-rng */
-			status = "disabled";
+			compatible = "brcm,bcm2711-rng200";
+			reg = <0x7e104000 0x28>;
+			status = "okay";
 		};
 
 		uart2: serial@7e201400 {