| Message ID | 59793b1ae533636528942b2cec14ec68b9830fcf.1574510649.git.agx@sigxcpu.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | arm64: dts: imx8mq: Add eLCDIF controller | expand |
Hi Guido, On Sat, Nov 23, 2019 at 9:09 AM Guido Günther <agx@sigxcpu.org> wrote: > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 7f9319452b58..00aa63bfd816 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -448,6 +448,23 @@ > fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; > }; > > + lcdif: lcdif@30320000 { > + compatible = "fsl,imx8mq-lcdif", "fsl,imx28-lcdif"; fsl,imx8mq-lcdif should also be documented. Reviewed-by: Fabio Estevam <festevam@gmail.com> Thanks
On Sat, Nov 23, 2019 at 9:09 AM Guido Günther <agx@sigxcpu.org> wrote: > > Add a node for the eLCDIF controller, "disabled" by default. > > Signed-off-by: Guido Günther <agx@sigxcpu.org> > --- > With some minimal support on imx8mq we might as well add it to the DT > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 7f9319452b58..00aa63bfd816 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -448,6 +448,23 @@ > fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; > }; > > + lcdif: lcdif@30320000 { Forgot to say that generic node names are preferred, so maybe: lcdif: lcd-controller@30320000 { instead?
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index 7f9319452b58..00aa63bfd816 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -448,6 +448,23 @@ fsl,sdma-ram-script-name = "imx/sdma/sdma-imx7d.bin"; }; + lcdif: lcdif@30320000 { + compatible = "fsl,imx8mq-lcdif", "fsl,imx28-lcdif"; + reg = <0x30320000 0x10000>; + interrupts = <GIC_SPI 5 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clk IMX8MQ_CLK_LCDIF_PIXEL>; + clock-names = "pix"; + assigned-clocks = <&clk IMX8MQ_VIDEO_PLL1_REF_SEL>, + <&clk IMX8MQ_VIDEO_PLL1_BYPASS>, + <&clk IMX8MQ_CLK_LCDIF_PIXEL>, + <&clk IMX8MQ_VIDEO_PLL1>; + assigned-clock-parents = <&clk IMX8MQ_CLK_25M>, + <&clk IMX8MQ_VIDEO_PLL1>, + <&clk IMX8MQ_VIDEO_PLL1_OUT>; + assigned-clock-rates = <0>, <0>, <0>, <594000000>; + status = "disabled"; + }; + iomuxc: iomuxc@30330000 { compatible = "fsl,imx8mq-iomuxc"; reg = <0x30330000 0x10000>;
Add a node for the eLCDIF controller, "disabled" by default. Signed-off-by: Guido Günther <agx@sigxcpu.org> --- With some minimal support on imx8mq we might as well add it to the DT arch/arm64/boot/dts/freescale/imx8mq.dtsi | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)