| Message ID | 20191125132147.97111-2-anup.patel@wdc.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | QEMU Virt Machine Kconfig option | expand |
On Mon, 2019-11-25 at 13:22 +0000, Anup Patel wrote: > We add kconfig option for QEMU virt machine and select all > required VIRTIO drivers using this kconfig option. > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > --- > arch/riscv/Kconfig.socs | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs > index 536c0ef4aee8..62383951bf2e 100644 > --- a/arch/riscv/Kconfig.socs > +++ b/arch/riscv/Kconfig.socs > @@ -10,4 +10,24 @@ config SOC_SIFIVE > help > This enables support for SiFive SoC platform hardware. > > +config SOC_VIRT > + bool "QEMU Virt Machine" > + select VIRTIO_PCI > + select VIRTIO_BALLOON > + select VIRTIO_MMIO > + select VIRTIO_CONSOLE > + select VIRTIO_NET > + select NET_9P_VIRTIO > + select VIRTIO_BLK > + select SCSI_VIRTIO > + select DRM_VIRTIO_GPU > + select HW_RANDOM_VIRTIO > + select RPMSG_CHAR > + select RPMSG_VIRTIO > + select CRYPTO_DEV_VIRTIO > + select VIRTIO_INPUT > + select SIFIVE_PLIC > + help > + This enables support for QEMU Virt Machine. > + > endmenu Looks good. Reviewed-by: Atish Patra <atish.patra@wdc.com>
On Mon, 25 Nov 2019 05:22:23 PST (-0800), Anup Patel wrote: > We add kconfig option for QEMU virt machine and select all > required VIRTIO drivers using this kconfig option. > > Signed-off-by: Anup Patel <anup.patel@wdc.com> > --- > arch/riscv/Kconfig.socs | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs > index 536c0ef4aee8..62383951bf2e 100644 > --- a/arch/riscv/Kconfig.socs > +++ b/arch/riscv/Kconfig.socs > @@ -10,4 +10,24 @@ config SOC_SIFIVE > help > This enables support for SiFive SoC platform hardware. > > +config SOC_VIRT > + bool "QEMU Virt Machine" > + select VIRTIO_PCI > + select VIRTIO_BALLOON > + select VIRTIO_MMIO > + select VIRTIO_CONSOLE > + select VIRTIO_NET > + select NET_9P_VIRTIO > + select VIRTIO_BLK > + select SCSI_VIRTIO > + select DRM_VIRTIO_GPU > + select HW_RANDOM_VIRTIO > + select RPMSG_CHAR > + select RPMSG_VIRTIO > + select CRYPTO_DEV_VIRTIO > + select VIRTIO_INPUT > + select SIFIVE_PLIC > + help > + This enables support for QEMU Virt Machine. > + > endmenu Reviewed-by: Palmer Dabbelt <palmerdabbelt@google.com>
WARNING: unmet direct dependencies detected for DRM_VIRTIO_GPU Depends on [m]: HAS_IOMEM [=y] && DRM [=m] && VIRTIO [=y] && MMU [=y] Selected by [y]: - SOC_VIRT [=y] WARNING: unmet direct dependencies detected for NET_9P_VIRTIO Depends on [m]: NET [=y] && NET_9P [=m] && VIRTIO [=y] Selected by [y]: - SOC_VIRT [=y] Andreas.
> -----Original Message----- > From: Andreas Schwab <schwab@suse.de> > Sent: 09 March 2020 15:42 > To: Anup Patel <Anup.Patel@wdc.com> > Cc: Palmer Dabbelt <palmer@sifive.com>; Paul Walmsley > <paul.walmsley@sifive.com>; Albert Ou <aou@eecs.berkeley.edu>; Atish > Patra <Atish.Patra@wdc.com>; Alistair Francis <Alistair.Francis@wdc.com>; > Christoph Hellwig <hch@lst.de>; Anup Patel <anup@brainfault.org>; linux- > riscv@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH 1/4] RISC-V: Add kconfig option for QEMU virt machine > > WARNING: unmet direct dependencies detected for DRM_VIRTIO_GPU > Depends on [m]: HAS_IOMEM [=y] && DRM [=m] && VIRTIO [=y] && MMU > [=y] > Selected by [y]: > - SOC_VIRT [=y] > > WARNING: unmet direct dependencies detected for NET_9P_VIRTIO > Depends on [m]: NET [=y] && NET_9P [=m] && VIRTIO [=y] > Selected by [y]: > - SOC_VIRT [=y] We don't see this warning with rv32_defconfig and defconfig. Perhaps selecting DRM and NET_9P from SOC_VIRT will help. Can you try and send patch ? Regards, Anup
On Mär 09 2020, Anup Patel wrote: > Perhaps selecting DRM and NET_9P from SOC_VIRT will help. Can you > try and send patch ? No, the config option should be removed. It is useless. Andreas.
On Tue, Mar 10, 2020 at 3:51 PM Andreas Schwab <schwab@suse.de> wrote: > > On Mär 09 2020, Anup Patel wrote: > > > Perhaps selecting DRM and NET_9P from SOC_VIRT will help. Can you > > try and send patch ? > > No, the config option should be removed. It is useless. It's not useless. Going forward, we are adding SOC kconfig option for each supported platform. In case of SOC_VIRT, we over-selected all required VIRTIO drivers. Instead, we should only select essential drivers from SOC_VIRT and enable the rest of drivers via defconfigs. Regards, Anup
diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs index 536c0ef4aee8..62383951bf2e 100644 --- a/arch/riscv/Kconfig.socs +++ b/arch/riscv/Kconfig.socs @@ -10,4 +10,24 @@ config SOC_SIFIVE help This enables support for SiFive SoC platform hardware. +config SOC_VIRT + bool "QEMU Virt Machine" + select VIRTIO_PCI + select VIRTIO_BALLOON + select VIRTIO_MMIO + select VIRTIO_CONSOLE + select VIRTIO_NET + select NET_9P_VIRTIO + select VIRTIO_BLK + select SCSI_VIRTIO + select DRM_VIRTIO_GPU + select HW_RANDOM_VIRTIO + select RPMSG_CHAR + select RPMSG_VIRTIO + select CRYPTO_DEV_VIRTIO + select VIRTIO_INPUT + select SIFIVE_PLIC + help + This enables support for QEMU Virt Machine. + endmenu
We add kconfig option for QEMU virt machine and select all required VIRTIO drivers using this kconfig option. Signed-off-by: Anup Patel <anup.patel@wdc.com> --- arch/riscv/Kconfig.socs | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)