| Message ID | 20191127231926.162437-1-heidifahim@google.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 70efb58bbbc28f0cbd4060c9aa581d79201c8b1a |
| Headers | show |
| Series | kunit: testing kunit: Bug fix in test_run_timeout function | expand |
On Wed, Nov 27, 2019 at 3:19 PM Heidi Fahim <heidifahim@google.com> wrote: > > Assert in test_run_timeout was not updated with the build_dir argument > and caused the following error: > AssertionError: Expected call: run_kernel(timeout=3453) > Actual call: run_kernel(build_dir=None, timeout=3453) > > Needed to update kunit_tool_test to reflect this fix > https://lkml.org/lkml/2019/9/6/3 Wrong url, here is the correct link to the fix that caused this bug: https://lkml.org/lkml/2019/9/6/351
On Thu, Nov 28, 2019 at 12:58 AM Heidi Fahim <heidifahim@google.com> wrote: > > On Wed, Nov 27, 2019 at 3:19 PM Heidi Fahim <heidifahim@google.com> wrote: > > > > Assert in test_run_timeout was not updated with the build_dir argument > > and caused the following error: > > AssertionError: Expected call: run_kernel(timeout=3453) > > Actual call: run_kernel(build_dir=None, timeout=3453) > > > > Needed to update kunit_tool_test to reflect this fix > > https://lkml.org/lkml/2019/9/6/3 > > Wrong url, here is the correct link to the fix that caused this bug: > https://lkml.org/lkml/2019/9/6/351 Reviewed-by: SeongJae Park <sjpark@amazon.de> Thanks, SeongJae Park
On Wed, Nov 27, 2019 at 3:19 PM Heidi Fahim <heidifahim@google.com> wrote: > > Assert in test_run_timeout was not updated with the build_dir argument > and caused the following error: > AssertionError: Expected call: run_kernel(timeout=3453) > Actual call: run_kernel(build_dir=None, timeout=3453) > > Needed to update kunit_tool_test to reflect this fix > https://lkml.org/lkml/2019/9/6/3 > > Signed-off-by: Heidi Fahim <heidifahim@google.com> > Change-Id: I6f161c72c6a5f071a4dc31582ba08b91974502ce Change-Id should not be used on LKML patches. Did you run checkpatch?
diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py index 4a12baa0cd4e..a2a8ea6beae3 100755 --- a/tools/testing/kunit/kunit_tool_test.py +++ b/tools/testing/kunit/kunit_tool_test.py @@ -199,7 +199,7 @@ class KUnitMainTest(unittest.TestCase): timeout = 3453 kunit.main(['run', '--timeout', str(timeout)], self.linux_source_mock) assert self.linux_source_mock.build_reconfig.call_count == 1 - self.linux_source_mock.run_kernel.assert_called_once_with(timeout=timeout) + self.linux_source_mock.run_kernel.assert_called_once_with(build_dir=None, timeout=timeout) self.print_mock.assert_any_call(StrContains('Testing complete.')) if __name__ == '__main__':
Assert in test_run_timeout was not updated with the build_dir argument and caused the following error: AssertionError: Expected call: run_kernel(timeout=3453) Actual call: run_kernel(build_dir=None, timeout=3453) Needed to update kunit_tool_test to reflect this fix https://lkml.org/lkml/2019/9/6/3 Signed-off-by: Heidi Fahim <heidifahim@google.com> Change-Id: I6f161c72c6a5f071a4dc31582ba08b91974502ce --- tools/testing/kunit/kunit_tool_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)