[v2,02/27] nvdimm: remove prototypes for nonexistent functions

Commit Message

Alastair D'Silva Dec. 3, 2019, 3:46 a.m. UTC

From: Alastair D'Silva <[e-mail]>

These functions don't exist, so remove the prototypes for them.

Signed-off-by: Alastair D'Silva <[e-mail]>
Reviewed-by: Frederic Barrat <[e-mail]>
---
 drivers/nvdimm/nd-core.h | 4 ----
 1 file changed, 4 deletions(-)

Comments

Andrew Donnellan Dec. 3, 2019, 4:47 a.m. UTC | #1

On 3/12/19 2:46 pm, Alastair D'Silva wrote:
> From: Alastair D'Silva <[e-mail]>
> 
> These functions don't exist, so remove the prototypes for them.
> 
> Signed-off-by: Alastair D'Silva <[e-mail]>
> Reviewed-by: Frederic Barrat <[e-mail]>

Reviewed-by: Andrew Donnellan <[e-mail]>

Dan Williams Dec. 4, 2019, 12:10 a.m. UTC | #2

On Mon, Dec 2, 2019 at 7:48 PM Alastair D'Silva <[e-mail]> wrote:
>
> From: Alastair D'Silva <[e-mail]>
>
> These functions don't exist, so remove the prototypes for them.
>
> Signed-off-by: Alastair D'Silva <[e-mail]>
> Reviewed-by: Frederic Barrat <[e-mail]>
> ---

This was already merged as commit:

    cda93d6965a1 libnvdimm: Remove prototypes for nonexistent functions

You should have received a notification from the patchwork bot that it
was already accepted.

What baseline did you use for this submission?

Dan Williams Jan. 23, 2020, 9:49 p.m. UTC | #3

[ add Aneesh ]


On Tue, Dec 3, 2019 at 4:10 PM Dan Williams <[e-mail]> wrote:
>
> On Mon, Dec 2, 2019 at 7:48 PM Alastair D'Silva <[e-mail]> wrote:
> >
> > From: Alastair D'Silva <[e-mail]>
> >
> > These functions don't exist, so remove the prototypes for them.
> >
> > Signed-off-by: Alastair D'Silva <[e-mail]>
> > Reviewed-by: Frederic Barrat <[e-mail]>
> > ---
>
> This was already merged as commit:
>
>     cda93d6965a1 libnvdimm: Remove prototypes for nonexistent functions
>
> You should have received a notification from the patchwork bot that it
> was already accepted.
>
> What baseline did you use for this submission?

I never got an answer to this, and I have not seen any updates. Can I
ask you to get an initial review from Aneesh who has been doing good
work in the nvdimm core, and then we can look to get this in the
pipeline for the v5.7 kernel?

Patch

diff --git a/drivers/nvdimm/nd-core.h b/drivers/nvdimm/nd-core.h
index 25fa121104d0..9f121a6aeb02 100644
--- a/drivers/nvdimm/nd-core.h
+++ b/drivers/nvdimm/nd-core.h
@@ -124,11 +124,7 @@  void nd_region_create_dax_seed(struct nd_region *nd_region);
 int nvdimm_bus_create_ndctl(struct nvdimm_bus *nvdimm_bus);
 void nvdimm_bus_destroy_ndctl(struct nvdimm_bus *nvdimm_bus);
 void nd_synchronize(void);
-int nvdimm_bus_register_dimms(struct nvdimm_bus *nvdimm_bus);
-int nvdimm_bus_register_regions(struct nvdimm_bus *nvdimm_bus);
-int nvdimm_bus_init_interleave_sets(struct nvdimm_bus *nvdimm_bus);
 void __nd_device_register(struct device *dev);
-int nd_match_dimm(struct device *dev, void *data);
 struct nd_label_id;
 char *nd_label_gen_id(struct nd_label_id *label_id, u8 *uuid, u32 flags);
 bool nd_is_uuid_unique(struct device *dev, u8 *uuid);