| Message ID | 20191203094845.610692-1-unixbhaskar@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] Enlist running kernel modules information | expand |
On Tue, Dec 3, 2019 at 6:49 PM Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote: > > This is new file to show running kernel modules list.One line bash > script. > > Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> > --- > scripts/kernel_modules_info.sh | 23 +++++++++++++++++++++++ > 1 file changed, 23 insertions(+) > create mode 100755 scripts/kernel_modules_info.sh > > diff --git a/scripts/kernel_modules_info.sh b/scripts/kernel_modules_info.sh > new file mode 100755 > index 000000000000..f005c47a3aa6 > --- /dev/null > +++ b/scripts/kernel_modules_info.sh > @@ -0,0 +1,23 @@ > +#!/bin/bash - > +#SPDX-License-Identifier: GPL-2.0 > +#=============================================================================== > +# > +# FILE: kernel_modules_info.sh > +# > +# USAGE: ./kernel_modules_info.sh > +# > +# DESCRIPTION: Running kernel modules information. > +# > +# OPTIONS: --- > +# REQUIREMENTS: awk > +# BUGS: --- > +# NOTES: --- > +# AUTHOR: Bhaskar Chowdhury (https://about.me/unixbhaskar), unixbhaskar@gmail.com > +# ORGANIZATION: Independent > +# CREATED: 12/03/2019 13:52 > +# REVISION: --- > +#=============================================================================== > + > +set -o nounset # Treat unset variables as an error > + > +awk '{print $1}' "/proc/modules" | xargs modinfo | awk '/^(filename|desc|depends)/' I want to see a good reason (e.g. useful for other developers) for upstreaming. This script looks like your custom script, which you can maintain locally.
On 12:10 Wed 04 Dec 2019, Masahiro Yamada wrote: >On Tue, Dec 3, 2019 at 6:49 PM Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote: >> >> This is new file to show running kernel modules list.One line bash >> script. >> >> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> >> --- >> scripts/kernel_modules_info.sh | 23 +++++++++++++++++++++++ >> 1 file changed, 23 insertions(+) >> create mode 100755 scripts/kernel_modules_info.sh >> >> diff --git a/scripts/kernel_modules_info.sh b/scripts/kernel_modules_info.sh >> new file mode 100755 >> index 000000000000..f005c47a3aa6 >> --- /dev/null >> +++ b/scripts/kernel_modules_info.sh >> @@ -0,0 +1,23 @@ >> +#!/bin/bash - >> +#SPDX-License-Identifier: GPL-2.0 >> +#=============================================================================== >> +# >> +# FILE: kernel_modules_info.sh >> +# >> +# USAGE: ./kernel_modules_info.sh >> +# >> +# DESCRIPTION: Running kernel modules information. >> +# >> +# OPTIONS: --- >> +# REQUIREMENTS: awk >> +# BUGS: --- >> +# NOTES: --- >> +# AUTHOR: Bhaskar Chowdhury (https://about.me/unixbhaskar), unixbhaskar@gmail.com >> +# ORGANIZATION: Independent >> +# CREATED: 12/03/2019 13:52 >> +# REVISION: --- >> +#=============================================================================== >> + >> +set -o nounset # Treat unset variables as an error >> + >> +awk '{print $1}' "/proc/modules" | xargs modinfo | awk '/^(filename|desc|depends)/' > > > >I want to see a good reason (e.g. useful for other developers) for upstreaming. >This script looks like your custom script, which you can maintain locally. I think the usefulness comes from developers wants to see what are the modules are using by the running kernel in formatted way. This is very simple way to enlist all the modules with descriptions of it.So , they can easily parse it with other scripts. I believe you have already copy and paste the single line on your terminal to see the output it produces, if not, I have already sent a mail which includes the out of it. If and only if, no other tool or mechanism(which might have skips my eyes and knowledge) to find and display information this way. Kindly, share me the other way , you can achieve that. This is a generic script,and expecting stuff in common place, so everybody can use it.No, special requirement is needed. Here is little output,if you missed my other mail with it... filename:/lib/modules/5.4.1-arch1-1ArchLinux-5.4.1/kernel/drivers/usb/host/xhci-pci.ko.xz description: xHCI PCI Host Controller Driver depends: xhci-hcd These output can be parse by other scripts too(cliche...sorry) .. Thanks, Bhaskar > > >-- >Best Regards >Masahiro Yamada
On 04.12.19 05:22, Bhaskar Chowdhury wrote: Hi, > I think the usefulness comes from developers wants to see what are the > modules are using by the running kernel in formatted way. > This is very simple way to enlist all the modules with descriptions of > it.So , they can easily parse it with other scripts. IMHO, this is a good thing to have. I can even imagine it shipped by distros, for better bug reports. OTOH, if it's about the currently running kernel and loaded modules, why not putting this into /proc or /sys ? --mtx
On Wed, Dec 04, 2019 at 12:10:25PM +0900, Masahiro Yamada wrote: > On Tue, Dec 3, 2019 at 6:49 PM Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote: > > +awk '{print $1}' "/proc/modules" | xargs modinfo | awk '/^(filename|desc|depends)/' > > I want to see a good reason (e.g. useful for other developers) for upstreaming. > This script looks like your custom script, which you can maintain locally. I think the verbosity should be added to either lsmod or modinfo, not some script in kernel git.
On 16:07 Wed 04 Dec 2019, David Sterba wrote: >On Wed, Dec 04, 2019 at 12:10:25PM +0900, Masahiro Yamada wrote: >> On Tue, Dec 3, 2019 at 6:49 PM Bhaskar Chowdhury <unixbhaskar@gmail.com> wrote: >> > +awk '{print $1}' "/proc/modules" | xargs modinfo | awk '/^(filename|desc|depends)/' >> >> I want to see a good reason (e.g. useful for other developers) for upstreaming. >> This script looks like your custom script, which you can maintain locally. > >I think the verbosity should be added to either lsmod or modinfo, not >some script in kernel git. lsmod and modinfo already are pretty verbose and the one liner is using one of them to cut thing out of it....can you give it another look??? Moreover,this is sort and precise and can be parsed by other scripts. The whole point behind this is to give the developers a convenient point without going through all the rigorous details.
On 01:08 Fri 06 Dec 2019, Masahiro Yamada wrote: > On Thu, Dec 5, 2019 at 12:25 PM Bhaskar Chowdhury > <[1]unixbhaskar@gmail.com> wrote: > > On 16:07 Wed 04 Dec 2019, David Sterba wrote: > >On Wed, Dec 04, 2019 at 12:10:25PM +0900, Masahiro Yamada wrote: > >> On Tue, Dec 3, 2019 at 6:49 PM Bhaskar Chowdhury > <[2]unixbhaskar@gmail.com> wrote: > >> > +awk '{print $1}' "/proc/modules" | xargs modinfo | awk > '/^(filename|desc|depends)/' > >> > >> I want to see a good reason (e.g. useful for other developers) > for upstreaming. > >> This script looks like your custom script, which you can maintain > locally. > > > >I think the verbosity should be added to either lsmod or modinfo, > not > >some script in kernel git. > lsmod and modinfo already are pretty verbose and the one liner is > using > one of them to cut thing out of it....can you give it another > look??? > Moreover,this is sort and precise and can be parsed by other > scripts. > The whole point behind this is to give the developers a convenient > point > without going through all the rigorous details. > > lsmod and modinfo are good. > If you are not satisfied with the current format, > talk to the kmod maintainer. > As a maintainer, I need to avoid the situation > where upstream tree is flooded with weird scripts like this. > One more thing: > Despite advice from Randy over again, > you are still not able to submit a patch correctly. > (see what you sent as v2). > Do not get me wrong. I am not saying you to send v3. > I do not like this patch. Please stop. > -- I completely get you. I should stop sending this. Thanks for the heads up. And I was not denying the verbosity of lsmod and modinfo , as I was pointing out to someone else. About the V2, this was a mistake , I know once I saw it alas! after sending it you. So, my apology. One thing get it straight , I am NOT trying to flooding with some airy fairy script , I know what it takes to maintain that bloody thing. Your time is precious like mine, never try to gobbles it by sending garbage. I was thinking make it easy for others, not sure why you think it's wired. Again , thanks for the heads up...above statements are STRICTLY NOT in my defence not to cover the mistake. > Best Regards > Masahiro Yamada > >References > > 1. mailto:unixbhaskar@gmail.com > 2. mailto:unixbhaskar@gmail.com
On 05.12.19 04:25, Bhaskar Chowdhury wrote: Hi, > The whole point behind this is to give the developers a convenient point > without going through all the rigorous details. I see your point, but I wonder whether it maybe better should go into kmod. --mtx --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287
diff --git a/scripts/kernel_modules_info.sh b/scripts/kernel_modules_info.sh new file mode 100755 index 000000000000..f005c47a3aa6 --- /dev/null +++ b/scripts/kernel_modules_info.sh @@ -0,0 +1,23 @@ +#!/bin/bash - +#SPDX-License-Identifier: GPL-2.0 +#=============================================================================== +# +# FILE: kernel_modules_info.sh +# +# USAGE: ./kernel_modules_info.sh +# +# DESCRIPTION: Running kernel modules information. +# +# OPTIONS: --- +# REQUIREMENTS: awk +# BUGS: --- +# NOTES: --- +# AUTHOR: Bhaskar Chowdhury (https://about.me/unixbhaskar), unixbhaskar@gmail.com +# ORGANIZATION: Independent +# CREATED: 12/03/2019 13:52 +# REVISION: --- +#=============================================================================== + +set -o nounset # Treat unset variables as an error + +awk '{print $1}' "/proc/modules" | xargs modinfo | awk '/^(filename|desc|depends)/'
This is new file to show running kernel modules list.One line bash script. Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com> --- scripts/kernel_modules_info.sh | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) create mode 100755 scripts/kernel_modules_info.sh